Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about HMR WebSocket with express to upgrading #30905

Merged
merged 3 commits into from
Nov 3, 2021
Merged

Add note about HMR WebSocket with express to upgrading #30905

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d8a1a0
Add note about HMR WebSocket with express to upgrading
ijjk Nov 3, 2021
642f69f
Apply suggestions from code review
ijjk Nov 3, 2021
9f67292
Merge branch 'canary' into docs/ws-express-note
ijjk Nov 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions docs/upgrading.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,14 @@ location /_next/webpack-hmr {
}
```

For custom servers, such as `express`, you may need to use `app.all` to ensure the request is passed correctly, for example:

```js
app.all('/_next/webpack-hmr', (req, res) => {
nextjsRequestHandler(req, res)
})
```

### Webpack 4 support has been removed

If you are already using webpack 5 you can skip this section.
Expand Down