Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node.js 17 to CI #30760

Merged
merged 3 commits into from
Nov 1, 2021
Merged

Add Node.js 17 to CI #30760

merged 3 commits into from
Nov 1, 2021

Conversation

styfle
Copy link
Member

@styfle styfle commented Nov 1, 2021

This will make sure #30743 doesn't regress

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Nov 1, 2021
Co-authored-by: JJ Kasper <[email protected]>
@ijjk

This comment has been minimized.

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once v17 is passing, thanks!

@ijjk
Copy link
Member

ijjk commented Nov 1, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js add-nodejs-17-gh-ci Change
buildDuration 23.5s 23.4s -105ms
buildDurationCached 5s 5s -48ms
nodeModulesSize 293 MB 293 MB ⚠️ +6 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js add-nodejs-17-gh-ci Change
/ failed reqs 0 0
/ total time (seconds) 4.012 3.936 -0.08
/ avg req/sec 623.11 635.22 +12.11
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.073 2.017 -0.06
/error-in-render avg req/sec 1205.84 1239.5 +33.66
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js add-nodejs-17-gh-ci Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js add-nodejs-17-gh-ci Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js add-nodejs-17-gh-ci Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js add-nodejs-17-gh-ci Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js add-nodejs-17-gh-ci Change
index.html gzip 534 B 534 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js add-nodejs-17-gh-ci Change
buildDuration 25.2s 25.3s ⚠️ +83ms
buildDurationCached 4.9s 4.8s -38ms
nodeModulesSize 293 MB 293 MB ⚠️ +6 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js add-nodejs-17-gh-ci Change
/ failed reqs 0 0
/ total time (seconds) 3.9 3.893 -0.01
/ avg req/sec 640.96 642.11 +1.15
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.074 1.996 -0.08
/error-in-render avg req/sec 1205.66 1252.67 +47.01
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js add-nodejs-17-gh-ci Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js add-nodejs-17-gh-ci Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js add-nodejs-17-gh-ci Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js add-nodejs-17-gh-ci Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js add-nodejs-17-gh-ci Change
index.html gzip 535 B 535 B
link.html gzip 548 B 548 B
withRouter.html gzip 529 B 529 B
Overall change 1.61 kB 1.61 kB
Commit: f1901b0

@kodiakhq kodiakhq bot merged commit beedff2 into canary Nov 1, 2021
@kodiakhq kodiakhq bot deleted the add-nodejs-17-gh-ci branch November 1, 2021 21:24
timneutkens pushed a commit to timneutkens/next.js that referenced this pull request Nov 2, 2021
This will make sure vercel#30743 doesn't regress
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants