Fix missing trace items and migrate required files test #29649

ijjk · 2021-10-05T18:12:00Z

This ensures we include all traced files even if they are in the webpack dependency map since they can still be required outside of a chunk. This also migrates the required-server-files suite to leverage the new test utils.

Bug

Related issues linked using fixes #number
Integration tests added
Errors have helpful link attached, see contributing.md

Fixes: #25538 (comment)

ijjk · 2021-10-05T18:26:53Z

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	ijjk/next.js fix/tracing-client-items	Change
buildDuration	14.4s	14.4s	⚠️ +28ms
buildDurationCached	3.7s	3.7s	-53ms
nodeModulesSize	193 MB	193 MB	-775 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js fix/tracing-client-items	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.19	3.17	-0.02
/ avg req/sec	783.61	788.64	+5.03
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.519	1.513	-0.01
/error-in-render avg req/sec	1645.72	1651.88	+6.16

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js fix/tracing-client-items	Change
779.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	26.9 kB	26.9 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	70.8 kB	70.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js fix/tracing-client-items	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js fix/tracing-client-items	Change
_app-HASH.js gzip	977 B	977 B	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	311 B	311 B	✓
css-HASH.js gzip	328 B	328 B	✓
dynamic-HASH.js gzip	2.67 kB	2.67 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	918 B	918 B	✓
image-HASH.js gzip	4.15 kB	4.15 kB	✓
index-HASH.js gzip	260 B	260 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	320 B	320 B	✓
script-HASH.js gzip	386 B	386 B	✓
withRouter-HASH.js gzip	319 B	319 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	13 kB	13 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js fix/tracing-client-items	Change
_buildManifest.js gzip	494 B	494 B	✓
Overall change	494 B	494 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js fix/tracing-client-items	Change
index.html gzip	538 B	538 B	✓
link.html gzip	550 B	550 B	✓
withRouter.html gzip	532 B	532 B	✓
Overall change	1.62 kB	1.62 kB	✓

Default Build with SWC (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	ijjk/next.js fix/tracing-client-items	Change
buildDuration	7.6s	7.6s	✓
buildDurationCached	3.6s	3.6s	-10ms
nodeModulesSize	193 MB	193 MB	-775 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js fix/tracing-client-items	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.136	3.187	⚠️ +0.05
/ avg req/sec	797.27	784.45	⚠️ -12.82
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.509	1.491	-0.02
/error-in-render avg req/sec	1656.4	1676.27	+19.87

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js fix/tracing-client-items	Change
675-HASH.js gzip	13.8 kB	13.8 kB	✓
770.HASH.js gzip	178 B	178 B	✓
framework-HASH.js gzip	50.7 kB	50.7 kB	✓
main-HASH.js gzip	34.9 kB	34.9 kB	✓
webpack-HASH.js gzip	1.64 kB	1.64 kB	✓
Overall change	101 kB	101 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js fix/tracing-client-items	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js fix/tracing-client-items	Change
_app-HASH.js gzip	1.33 kB	1.33 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	315 B	315 B	✓
css-HASH.js gzip	331 B	331 B	✓
dynamic-HASH.js gzip	2.79 kB	2.79 kB	✓
head-HASH.js gzip	356 B	356 B	✓
hooks-HASH.js gzip	637 B	637 B	✓
image-HASH.js gzip	573 B	573 B	✓
index-HASH.js gzip	262 B	262 B	✓
link-HASH.js gzip	2.2 kB	2.2 kB	✓
routerDirect..HASH.js gzip	326 B	326 B	✓
script-HASH.js gzip	393 B	393 B	✓
withRouter-HASH.js gzip	322 B	322 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	10.1 kB	10.1 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js fix/tracing-client-items	Change
_buildManifest.js gzip	511 B	511 B	✓
Overall change	511 B	511 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js fix/tracing-client-items	Change
index.html gzip	538 B	538 B	✓
link.html gzip	551 B	551 B	✓
withRouter.html gzip	532 B	532 B	✓
Overall change	1.62 kB	1.62 kB	✓

Commit: 3a1174e

ijjk · 2021-10-05T18:34:33Z

Failing test suites

Commit: 3a1174e

test/integration/gssp-ssr-change-reloading/test/index.test.js

GS(S)P Server-Side Change Reloading > should not reload page when client-side is changed too GSP
GS(S)P Server-Side Change Reloading > should update page when getStaticProps is changed only
GS(S)P Server-Side Change Reloading > should show indicator when re-fetching data
GS(S)P Server-Side Change Reloading > should update page when getStaticPaths is changed only
GS(S)P Server-Side Change Reloading > should not reload page when client-side is changed too GSSP
GS(S)P Server-Side Change Reloading > should update page when getServerSideProps is changed only

Expand output

● GS(S)P Server-Side Change Reloading › should not reload page when client-side is changed too GSP

expect(received).toEqual(expected) // deep equality

- Expected  - 1
+ Received  + 1

  Object {
    "count": 1,
    "params": Object {
      "post": "first",
    },
-   "random": 0.6439643804391368,
+   "random": 0.4137220238808492,
  }

  54 |     await browser.eval(() => (window.beforeChange = 'hi'))
  55 |
> 56 |     const props = JSON.parse(await browser.elementByCss('#props').text())
     |                   ^
  57 |     expect(props.count).toBe(1)
  58 |
  59 |     const page = new File(join(appDir, 'pages/gsp-blog/[post].js'))

  at Object.<anonymous> (integration/gssp-ssr-change-reloading/test/index.test.js:56:19)

● GS(S)P Server-Side Change Reloading › should update page when getStaticProps is changed only

TIMED OUT: 2

1

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (integration/gssp-ssr-change-reloading/test/index.test.js:78:5)

● GS(S)P Server-Side Change Reloading › should show indicator when re-fetching data

expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: 2

  93 |     expect(await browser.eval(() => window.beforeChange)).toBe('hi')
  94 |     expect(await browser.eval(() => window.showedBuilder)).toBe(true)
> 95 |     page.restore()
     |                 ^
  96 |
  97 |     await check(
  98 |       async () =>

  at Object.<anonymous> (integration/gssp-ssr-change-reloading/test/index.test.js:95:17)

● GS(S)P Server-Side Change Reloading › should update page when getStaticPaths is changed only

expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: 2

  87 |
  88 |     await check(
> 89 |       async () =>
     |                  ^
  90 |         JSON.parse(await browser.elementByCss('#props').text()).count + '',
  91 |       '2'
  92 |     )

  at Object.<anonymous> (integration/gssp-ssr-change-reloading/test/index.test.js:89:29)

● GS(S)P Server-Side Change Reloading › should not reload page when client-side is changed too GSSP

Failed to replace content.

Pattern: change me

Content: export default function Gssp(props) {
  return (
    <>
      <p id="change">changed</p>
      <p id="props">{JSON.stringify(props)}</p>
    </>
  )
}

export const getServerSideProps = ({ params }) => {
  const count = 2

  return {
    props: {
      count,
      params,
      random: Math.random(),
    },
  }
}

  467 |     } else if (typeof pattern === 'string') {
  468 |       if (!currentContent.includes(pattern)) {
> 469 |         throw new Error(
      |               ^
  470 |           `Failed to replace content.\n\nPattern: ${pattern}\n\nContent: ${currentContent}`
  471 |         )
  472 |       }

  at File.replace (lib/next-test-utils.js:469:15)
  at Object.<anonymous> (integration/gssp-ssr-change-reloading/test/index.test.js:163:63)

● GS(S)P Server-Side Change Reloading › should update page when getServerSideProps is changed only

expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: 2

  185 |       async () =>
  186 |         JSON.parse(await browser.elementByCss('#props').text()).count + '',
> 187 |       '1'
      |          ^
  188 |     )
  189 |   })
  190 | })

  at Object.<anonymous> (integration/gssp-ssr-change-reloading/test/index.test.js:187:10)

Fix missing trace items and migrate required files test

3a1174e

ijjk requested review from huozhi, padmaia, shuding, styfle and timneutkens as code owners October 5, 2021 18:12

ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Oct 5, 2021

ijjk mentioned this pull request Oct 5, 2021

Add entrypoint tracing #25538

Merged

2 tasks

styfle approved these changes Oct 5, 2021

View reviewed changes

ijjk merged commit ebc1b0e into vercel:canary Oct 5, 2021

ijjk deleted the fix/tracing-client-items branch October 5, 2021 18:52

ijjk added the hacktoberfest-accepted label Oct 6, 2021

vercel locked as resolved and limited conversation to collaborators Jan 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix missing trace items and migrate required files test #29649

Fix missing trace items and migrate required files test #29649

ijjk commented Oct 5, 2021

ijjk commented Oct 5, 2021

ijjk commented Oct 5, 2021

Fix missing trace items and migrate required files test #29649

Fix missing trace items and migrate required files test #29649

Conversation

ijjk commented Oct 5, 2021

Bug

ijjk commented Oct 5, 2021

Stats from current PR

ijjk commented Oct 5, 2021

Failing test suites