type custom, for redirect and rewrite has #27431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 23, 2021 10:21
hacknlove
requested review from
huozhi,
ijjk,
leerob,
lfades,
padmaia,
shuding,
styfle and
timneutkens
as code owners
ijjk
requested changes
Jul 23, 2021
There was a problem hiding this comment.
Hi, the custom-routes fields need to be serializable since they are stored in a manifest during build time which is then leveraged for next start so a function can not be provided in this case. We are investigating adding an inverse hasNot mode for routes which should cover most cases mentioned.
I'm gonna close this as further discussion can continue on the mentioned thread.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
It's a secondary request in this discussion: #25931
And it's related with this PR #27103
The "has not" would be simple, it only redirects on absence.
If the developer wants to redirect when the value is not equal, he can use the custom check.
Also the custom check makes it possible to write conditional redirections for any scenario, like regular expressions, or