fix(types): allow other attributes on script component

[advaiyalad]

This allows for other attributes on the script component (as the docs say) to exist.

NOTE: This is my first PR, so I hope I didn't do anything wrong in the contrib process... I didn't add integration tests, because this is a types-only change, but could add one if required (I would need help though).

fixes #26236

Bug

• Related issues linked using fixes #number
• Integration tests added

[deadcoder0904]

Thank you. Looks good to me!

[deadcoder0904]

This one can be merged :)

[styfle]

The current <script> and <Script> have the same properties due to the extends ScriptHTMLAttributes here.

So if you were setting unknown props on <script> you would get the same TS error as <Script>.

Similarly, this is the same error you would get for <Image> with unknown props.

If for some reason there are props missing, its best to get this changed upstream in the ScriptHTMLAttributes interface via @types/react

[deadcoder0904]

@styfle So is there no fix to this? I am assuming what you are saying essentially doesn't allow me to use the custom attributes on Script tag that Utterances needs to use.

Any way to work around that as I feel this isn't going to be merged? Or do I need to send a PR here but don't know if it'll be accepted either?

[styfle]

Yep, DefinitelyTyped is the correct repository 👍

[deadcoder0904]

Confused 🤔

Do I send this PR there?

[styfle]

Yes if there is a prop missing from the <script> types but are available in the DOM, you can add it to DefinitelyTyped.

If you want to define custom types, you can extend the internal Next.js type

declare module "next/script" {
  interface Props {
    someNewProp?: string
  }
}

Although now that I see this, we need to fix the interface name in PR #26990 so it will become:

declare module "next/script" {
  interface ScriptProps {
    someNewProp?: string
  }
}