Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Wrap entire app with Styletron provider for with-styletron #21908

Merged
merged 2 commits into from
Feb 7, 2021

Conversation

giraffesyo
Copy link
Contributor

This PR fixes #21825. The user was having issues where the Layout they were defining wasn't available on page load, so they saw different styling when performing client side routing vs server side rendering. This was brought up once before on the styletron repo.

At the same time, I've updated React to 17 in this PR to clear up the message about Next 11. If this should be split out into a separate request, please advise.

@ijjk ijjk added the examples Issue was opened via the examples template. label Feb 5, 2021
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! 🙏

@leerob leerob changed the title Wrap entire app with styletron provider [examples] Wrap entire app with Styletron provider for with-styletron Feb 7, 2021
@leerob leerob merged commit 1773b99 into vercel:canary Feb 7, 2021
This was referenced Jan 18, 2022
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout broken after page reload (using with-styletron)
3 participants