-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples] Wrap entire app with Styletron provider for with-styletron #21908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giraffesyo
requested review from
chibicode,
ijjk,
lfades,
Timer and
timneutkens
as code owners
February 5, 2021 23:59
leerob
approved these changes
Feb 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much! 🙏
leerob
changed the title
Wrap entire app with styletron provider
[examples] Wrap entire app with Styletron provider for with-styletron
Feb 7, 2021
This was referenced Apr 12, 2021
This was referenced Jan 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #21825. The user was having issues where the
Layout
they were defining wasn't available on page load, so they saw different styling when performing client side routing vs server side rendering. This was brought up once before on the styletron repo.At the same time, I've updated React to 17 in this PR to clear up the message about Next 11. If this should be split out into a separate request, please advise.