Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click-to-open error state for development overlay #14461 #21819

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

yang-feng-yfeng
Copy link
Contributor

@yang-feng-yfeng yang-feng-yfeng commented Feb 3, 2021

image
Fix #14461
The error was ignored when click on "open in your editor" failed. As we have the code error already in the modal, the alert is not a good approach. Also because of this error about "open in your editor" is not that critique, we think it is sufficient to put just a log in the console.

@leerob
Copy link
Member

leerob commented Feb 3, 2021

Thank you so much for contributing! 🙏

@ijjk
Copy link
Member

ijjk commented Feb 3, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary yang-feng-yfeng/next.js master Change
buildDuration 8.1s 8.5s ⚠️ +401ms
nodeModulesSize 75.1 MB 75.1 MB ⚠️ +158 B
Page Load Tests Overall increase ✓
vercel/next.js canary yang-feng-yfeng/next.js master Change
/ failed reqs 0 0
/ total time (seconds) 1.63 1.594 -0.04
/ avg req/sec 1534.21 1568.28 +34.07
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.057 1.038 -0.02
/error-in-render avg req/sec 2364.21 2408.25 +44.04
Client Bundles (main, webpack, commons)
vercel/next.js canary yang-feng-yfeng/next.js master Change
677f882d2ed8..49c4.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 59.5 kB 59.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary yang-feng-yfeng/next.js master Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary yang-feng-yfeng/next.js master Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary yang-feng-yfeng/next.js master Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Rendered Page Sizes
vercel/next.js canary yang-feng-yfeng/next.js master Change
index.html gzip 615 B 615 B
link.html gzip 621 B 621 B
withRouter.html gzip 609 B 609 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary yang-feng-yfeng/next.js master Change
buildDuration 9.8s 9.9s ⚠️ +148ms
nodeModulesSize 75.1 MB 75.1 MB ⚠️ +158 B
Client Bundles (main, webpack, commons)
vercel/next.js canary yang-feng-yfeng/next.js master Change
677f882d2ed8..49c4.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 59.5 kB 59.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary yang-feng-yfeng/next.js master Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary yang-feng-yfeng/next.js master Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary yang-feng-yfeng/next.js master Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Serverless bundles
vercel/next.js canary yang-feng-yfeng/next.js master Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.06 MB 1.06 MB
withRouter.js 1.06 MB 1.06 MB
Overall change 5.19 MB 5.19 MB

Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary yang-feng-yfeng/next.js master Change
buildDuration 10.2s 10.1s -98ms
nodeModulesSize 75.1 MB 75.1 MB ⚠️ +158 B
Page Load Tests Overall increase ✓
vercel/next.js canary yang-feng-yfeng/next.js master Change
/ failed reqs 0 0
/ total time (seconds) 1.707 1.618 -0.09
/ avg req/sec 1464.92 1545.03 +80.11
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.049 1.051 0
/error-in-render avg req/sec 2382.52 2379.14 ⚠️ -3.38
Client Bundles (main, webpack, commons)
vercel/next.js canary yang-feng-yfeng/next.js master Change
597-6c246419..806f.js gzip 13 kB 13 kB
framework.HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 6.58 kB 6.58 kB
webpack-HASH.js gzip 954 B 954 B
Overall change 59.9 kB 59.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary yang-feng-yfeng/next.js master Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary yang-feng-yfeng/next.js master Change
_app-6e0a903..b885.js gzip 1.26 kB 1.26 kB
_error-7a100..a392.js gzip 3.38 kB 3.38 kB
hooks-f7e199..11b9.js gzip 904 B 904 B
index-3dc22c..ffbb.js gzip 232 B 232 B
link-c010d28..b60a.js gzip 1.63 kB 1.63 kB
routerDirect..323a.js gzip 308 B 308 B
withRouter-a..2ef8.js gzip 304 B 304 B
Overall change 8.02 kB 8.02 kB
Client Build Manifests
vercel/next.js canary yang-feng-yfeng/next.js master Change
_buildManifest.js gzip 299 B 299 B
Overall change 299 B 299 B
Rendered Page Sizes
vercel/next.js canary yang-feng-yfeng/next.js master Change
index.html gzip 586 B 586 B
link.html gzip 593 B 593 B
withRouter.html gzip 579 B 579 B
Overall change 1.76 kB 1.76 kB

Diffs

Diff for index.html
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "-NxVs21OzvZIWNZT9Dvwb",
+        "buildId": "l3mH4wq_Tug-C1HsTIm-E",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/-NxVs21OzvZIWNZT9Dvwb/_buildManifest.js"
+      src="/_next/static/l3mH4wq_Tug-C1HsTIm-E/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/-NxVs21OzvZIWNZT9Dvwb/_ssgManifest.js"
+      src="/_next/static/l3mH4wq_Tug-C1HsTIm-E/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "-NxVs21OzvZIWNZT9Dvwb",
+        "buildId": "l3mH4wq_Tug-C1HsTIm-E",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/-NxVs21OzvZIWNZT9Dvwb/_buildManifest.js"
+      src="/_next/static/l3mH4wq_Tug-C1HsTIm-E/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/-NxVs21OzvZIWNZT9Dvwb/_ssgManifest.js"
+      src="/_next/static/l3mH4wq_Tug-C1HsTIm-E/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "-NxVs21OzvZIWNZT9Dvwb",
+        "buildId": "l3mH4wq_Tug-C1HsTIm-E",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/-NxVs21OzvZIWNZT9Dvwb/_buildManifest.js"
+      src="/_next/static/l3mH4wq_Tug-C1HsTIm-E/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/-NxVs21OzvZIWNZT9Dvwb/_ssgManifest.js"
+      src="/_next/static/l3mH4wq_Tug-C1HsTIm-E/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 4b12d08

@timneutkens timneutkens merged commit 06770e4 into vercel:canary Nov 17, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Click-to-open error state for development overlay
4 participants