Revert #14580 #16757

Timer · 2020-09-01T17:45:33Z

#14580 broke the return value of the promise, yielding unhandled rejection errors. It also meant the method would resolve before the prefetch was complete.

I pointed out this bug in review but it seems to have been accidentally marked as resolve while it was still broken.

This pull request reverts the change requestIdleCallback change instead of fixing it because it was added in the wrong place. This method needed to be called around where we are configuring the observers, not inserting the link itself (the link is already low priority).

Fixes #16624
Reopens #14463

ijjk · 2020-09-01T17:55:08Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	Timer/next.js revert/14580	Change
buildDuration	12.4s	12.9s	⚠️ +452ms
nodeModulesSize	55.9 MB	55.9 MB	-498 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	Timer/next.js revert/14580	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.256	2.267	⚠️ +0.01
/ avg req/sec	1108.34	1102.84	⚠️ -5.5
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.248	1.247	0
/error-in-render avg req/sec	2003.91	2005.52	+1.61

Client Bundles (main, webpack, commons) Overall decrease ✓

	vercel/next.js canary	Timer/next.js revert/14580	Change
677f882d2ed8..9ff9.js gzip	10.3 kB	10.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-cc92da0..0b67.js gzip	7.35 kB	7.32 kB	-26 B
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.3 kB	57.3 kB	-26 B

Client Bundles (main, webpack, commons) Modern Overall decrease ✓

	vercel/next.js canary	Timer/next.js revert/14580	Change
677f882d2ed8..dule.js gzip	6.13 kB	6.13 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-0ed168f..dule.js gzip	6.41 kB	6.38 kB	-33 B
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.3 kB	52.2 kB	-33 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js revert/14580	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	Timer/next.js revert/14580	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-ae98065..267e.js gzip	1.29 kB	1.29 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.69 kB	7.69 kB	✓

Client Pages Modern

	vercel/next.js canary	Timer/next.js revert/14580	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-cb244c4..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.35 kB	5.35 kB	✓

Client Build Manifests

	vercel/next.js canary	Timer/next.js revert/14580	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes Overall decrease ✓

	vercel/next.js canary	Timer/next.js revert/14580	Change
index.html gzip	970 B	969 B	-1 B
link.html gzip	976 B	975 B	-1 B
withRouter.html gzip	964 B	963 B	-1 B
Overall change	2.91 kB	2.91 kB	-3 B

Diffs

Diff for main-0ed0039..df.module.js

@@ -1275,12 +1275,6 @@
       var relPreloadStyle = "fetch";
       var hasNoModule = "noModule" in document.createElement("script");
 
-      var requestIdleCallback =
-        window.requestIdleCallback ||
-        function(cb) {
-          return setTimeout(cb, 1);
-        };
-
       function normalizeRoute(route) {
         if (route[0] !== "/") {
           throw new Error(
@@ -1473,9 +1467,11 @@
           var { pathname: hrefPathname } = (0,
           _parseRelativeUrl.parseRelativeUrl)(href);
           var route = normalizeRoute(hrefPathname);
-          return this.promisedSsgManifest.then((s, _dataHref) => {
-            requestIdleCallback(() => {
-              // Check if the route requires a data file
+          return this.promisedSsgManifest.then(
+            (
+              s,
+              _dataHref // Check if the route requires a data file
+            ) =>
               s.has(route) && // Try to generate data href, noop when falsy
               (_dataHref = this.getDataHref(href, asPath, true)) && // noop when data has already been prefetched (dedupe)
               !document.querySelector(
@@ -1483,9 +1479,10 @@
                   .concat(relPrefetch, '"][href^="')
                   .concat(_dataHref, '"]')
               ) && // Inject the `<link rel=prefetch>` tag for above computed `href`.
-                appendLink(_dataHref, relPrefetch, "fetch");
-            });
-          });
+              appendLink(_dataHref, relPrefetch, "fetch").catch(() => {
+                /* ignore prefetch error */
+              })
+          );
         }
 
         loadPage(route) {

Diff for main-4b573dc..f6f186bef.js

@@ -1618,12 +1618,6 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
       var relPreloadStyle = "fetch";
       var hasNoModule = "noModule" in document.createElement("script");
 
-      var requestIdleCallback =
-        window.requestIdleCallback ||
-        function(cb) {
-          return setTimeout(cb, 1);
-        };
-
       function normalizeRoute(route) {
         if (route[0] !== "/") {
           throw new Error(
@@ -1855,7 +1849,7 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
 
               var route = normalizeRoute(hrefPathname);
               return this.promisedSsgManifest.then(function(s, _dataHref) {
-                requestIdleCallback(function() {
+                return (
                   // Check if the route requires a data file
                   s.has(route) && // Try to generate data href, noop when falsy
                   (_dataHref = _this3.getDataHref(href, asPath, true)) && // noop when data has already been prefetched (dedupe)
@@ -1864,8 +1858,12 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
                       .concat(relPrefetch, '"][href^="')
                       .concat(_dataHref, '"]')
                   ) && // Inject the `<link rel=prefetch>` tag for above computed `href`.
-                    appendLink(_dataHref, relPrefetch, "fetch");
-                });
+                  appendLink(_dataHref, relPrefetch, "fetch")["catch"](
+                    function() {
+                      /* ignore prefetch error */
+                    }
+                  )
+                );
               });
             }
           },

Diff for index.html

@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-0ed0039a9b022173a5df.module.js"
+      href="/_next/static/chunks/main-47482a86632c4815882e.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -82,13 +82,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-4b573dcf7e6f6f186bef.js"
+      src="/_next/static/chunks/main-7137891f43bf76bfb800.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-0ed0039a9b022173a5df.module.js"
+      src="/_next/static/chunks/main-47482a86632c4815882e.module.js"
       async=""
       crossorigin="anonymous"
       type="module"

Diff for link.html

@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-0ed0039a9b022173a5df.module.js"
+      href="/_next/static/chunks/main-47482a86632c4815882e.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -87,13 +87,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-4b573dcf7e6f6f186bef.js"
+      src="/_next/static/chunks/main-7137891f43bf76bfb800.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-0ed0039a9b022173a5df.module.js"
+      src="/_next/static/chunks/main-47482a86632c4815882e.module.js"
       async=""
       crossorigin="anonymous"
       type="module"

Diff for withRouter.html

@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-0ed0039a9b022173a5df.module.js"
+      href="/_next/static/chunks/main-47482a86632c4815882e.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -82,13 +82,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-4b573dcf7e6f6f186bef.js"
+      src="/_next/static/chunks/main-7137891f43bf76bfb800.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-0ed0039a9b022173a5df.module.js"
+      src="/_next/static/chunks/main-47482a86632c4815882e.module.js"
       async=""
       crossorigin="anonymous"
       type="module"

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	Timer/next.js revert/14580	Change
buildDuration	14.4s	14.2s	-164ms
nodeModulesSize	55.9 MB	55.9 MB	-498 B

Client Bundles (main, webpack, commons) Overall decrease ✓

	vercel/next.js canary	Timer/next.js revert/14580	Change
677f882d2ed8..9ff9.js gzip	10.3 kB	10.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-cc92da0..0b67.js gzip	7.35 kB	N/A	N/A
webpack-e067..f178.js gzip	751 B	751 B	✓
main-f659c41..be04.js gzip	N/A	7.32 kB	N/A
Overall change	57.3 kB	57.3 kB	-26 B

Client Bundles (main, webpack, commons) Modern Overall decrease ✓

	vercel/next.js canary	Timer/next.js revert/14580	Change
677f882d2ed8..dule.js gzip	6.13 kB	6.13 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-0ed168f..dule.js gzip	6.41 kB	N/A	N/A
webpack-07c5..dule.js gzip	751 B	751 B	✓
main-f01650b..dule.js gzip	N/A	6.38 kB	N/A
Overall change	52.3 kB	52.2 kB	-33 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js revert/14580	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	Timer/next.js revert/14580	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-ae98065..267e.js gzip	1.29 kB	1.29 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.69 kB	7.69 kB	✓

Client Pages Modern

	vercel/next.js canary	Timer/next.js revert/14580	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-cb244c4..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.35 kB	5.35 kB	✓

Client Build Manifests

	vercel/next.js canary	Timer/next.js revert/14580	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	Timer/next.js revert/14580	Change
_error.js	1.03 MB	1.03 MB	✓
404.html	4.22 kB	4.22 kB	✓
hooks.html	3.86 kB	3.86 kB	✓
index.js	1.03 MB	1.03 MB	✓
link.js	1.07 MB	1.07 MB	✓
routerDirect.js	1.07 MB	1.07 MB	✓
withRouter.js	1.07 MB	1.07 MB	✓
Overall change	5.28 MB	5.28 MB	✓

Commit: bf87f65

ijjk · 2020-09-01T18:03:07Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	Timer/next.js revert/14580	Change
buildDuration	14.2s	13.4s	-737ms
nodeModulesSize	55.9 MB	55.9 MB	-498 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	Timer/next.js revert/14580	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.535	2.527	-0.01
/ avg req/sec	986.23	989.14	+2.91
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.5	1.562	⚠️ +0.06
/error-in-render avg req/sec	1667.07	1600.62	⚠️ -66.45

Client Bundles (main, webpack, commons) Overall decrease ✓

	vercel/next.js canary	Timer/next.js revert/14580	Change
677f882d2ed8..9ff9.js gzip	10.3 kB	10.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-cc92da0..0b67.js gzip	7.35 kB	7.32 kB	-26 B
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.3 kB	57.3 kB	-26 B

Client Bundles (main, webpack, commons) Modern Overall decrease ✓

	vercel/next.js canary	Timer/next.js revert/14580	Change
677f882d2ed8..dule.js gzip	6.13 kB	6.13 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-0ed168f..dule.js gzip	6.41 kB	6.38 kB	-33 B
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.3 kB	52.2 kB	-33 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js revert/14580	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	Timer/next.js revert/14580	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-ae98065..267e.js gzip	1.29 kB	1.29 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.69 kB	7.69 kB	✓

Client Pages Modern

	vercel/next.js canary	Timer/next.js revert/14580	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-cb244c4..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.35 kB	5.35 kB	✓

Client Build Manifests

	vercel/next.js canary	Timer/next.js revert/14580	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes Overall decrease ✓

	vercel/next.js canary	Timer/next.js revert/14580	Change
index.html gzip	970 B	969 B	-1 B
link.html gzip	976 B	975 B	-1 B
withRouter.html gzip	964 B	963 B	-1 B
Overall change	2.91 kB	2.91 kB	-3 B

Diffs

Diff for main-0ed0039..df.module.js

@@ -1275,12 +1275,6 @@
       var relPreloadStyle = "fetch";
       var hasNoModule = "noModule" in document.createElement("script");
 
-      var requestIdleCallback =
-        window.requestIdleCallback ||
-        function(cb) {
-          return setTimeout(cb, 1);
-        };
-
       function normalizeRoute(route) {
         if (route[0] !== "/") {
           throw new Error(
@@ -1473,9 +1467,11 @@
           var { pathname: hrefPathname } = (0,
           _parseRelativeUrl.parseRelativeUrl)(href);
           var route = normalizeRoute(hrefPathname);
-          return this.promisedSsgManifest.then((s, _dataHref) => {
-            requestIdleCallback(() => {
-              // Check if the route requires a data file
+          return this.promisedSsgManifest.then(
+            (
+              s,
+              _dataHref // Check if the route requires a data file
+            ) =>
               s.has(route) && // Try to generate data href, noop when falsy
               (_dataHref = this.getDataHref(href, asPath, true)) && // noop when data has already been prefetched (dedupe)
               !document.querySelector(
@@ -1483,9 +1479,10 @@
                   .concat(relPrefetch, '"][href^="')
                   .concat(_dataHref, '"]')
               ) && // Inject the `<link rel=prefetch>` tag for above computed `href`.
-                appendLink(_dataHref, relPrefetch, "fetch");
-            });
-          });
+              appendLink(_dataHref, relPrefetch, "fetch").catch(() => {
+                /* ignore prefetch error */
+              })
+          );
         }
 
         loadPage(route) {

Diff for main-4b573dc..f6f186bef.js

@@ -1618,12 +1618,6 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
       var relPreloadStyle = "fetch";
       var hasNoModule = "noModule" in document.createElement("script");
 
-      var requestIdleCallback =
-        window.requestIdleCallback ||
-        function(cb) {
-          return setTimeout(cb, 1);
-        };
-
       function normalizeRoute(route) {
         if (route[0] !== "/") {
           throw new Error(
@@ -1855,7 +1849,7 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
 
               var route = normalizeRoute(hrefPathname);
               return this.promisedSsgManifest.then(function(s, _dataHref) {
-                requestIdleCallback(function() {
+                return (
                   // Check if the route requires a data file
                   s.has(route) && // Try to generate data href, noop when falsy
                   (_dataHref = _this3.getDataHref(href, asPath, true)) && // noop when data has already been prefetched (dedupe)
@@ -1864,8 +1858,12 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
                       .concat(relPrefetch, '"][href^="')
                       .concat(_dataHref, '"]')
                   ) && // Inject the `<link rel=prefetch>` tag for above computed `href`.
-                    appendLink(_dataHref, relPrefetch, "fetch");
-                });
+                  appendLink(_dataHref, relPrefetch, "fetch")["catch"](
+                    function() {
+                      /* ignore prefetch error */
+                    }
+                  )
+                );
               });
             }
           },

Diff for index.html

@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-0ed0039a9b022173a5df.module.js"
+      href="/_next/static/chunks/main-47482a86632c4815882e.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -82,13 +82,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-4b573dcf7e6f6f186bef.js"
+      src="/_next/static/chunks/main-7137891f43bf76bfb800.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-0ed0039a9b022173a5df.module.js"
+      src="/_next/static/chunks/main-47482a86632c4815882e.module.js"
       async=""
       crossorigin="anonymous"
       type="module"

Diff for link.html

@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-0ed0039a9b022173a5df.module.js"
+      href="/_next/static/chunks/main-47482a86632c4815882e.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -87,13 +87,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-4b573dcf7e6f6f186bef.js"
+      src="/_next/static/chunks/main-7137891f43bf76bfb800.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-0ed0039a9b022173a5df.module.js"
+      src="/_next/static/chunks/main-47482a86632c4815882e.module.js"
       async=""
       crossorigin="anonymous"
       type="module"

Diff for withRouter.html

@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-0ed0039a9b022173a5df.module.js"
+      href="/_next/static/chunks/main-47482a86632c4815882e.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -82,13 +82,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-4b573dcf7e6f6f186bef.js"
+      src="/_next/static/chunks/main-7137891f43bf76bfb800.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-0ed0039a9b022173a5df.module.js"
+      src="/_next/static/chunks/main-47482a86632c4815882e.module.js"
       async=""
       crossorigin="anonymous"
       type="module"

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	Timer/next.js revert/14580	Change
buildDuration	15.4s	15.9s	⚠️ +520ms
nodeModulesSize	55.9 MB	55.9 MB	-498 B

Client Bundles (main, webpack, commons) Overall decrease ✓

	vercel/next.js canary	Timer/next.js revert/14580	Change
677f882d2ed8..9ff9.js gzip	10.3 kB	10.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-cc92da0..0b67.js gzip	7.35 kB	N/A	N/A
webpack-e067..f178.js gzip	751 B	751 B	✓
main-f659c41..be04.js gzip	N/A	7.32 kB	N/A
Overall change	57.3 kB	57.3 kB	-26 B

Client Bundles (main, webpack, commons) Modern Overall decrease ✓

	vercel/next.js canary	Timer/next.js revert/14580	Change
677f882d2ed8..dule.js gzip	6.13 kB	6.13 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-0ed168f..dule.js gzip	6.41 kB	N/A	N/A
webpack-07c5..dule.js gzip	751 B	751 B	✓
main-f01650b..dule.js gzip	N/A	6.38 kB	N/A
Overall change	52.3 kB	52.2 kB	-33 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js revert/14580	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	Timer/next.js revert/14580	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-ae98065..267e.js gzip	1.29 kB	1.29 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.69 kB	7.69 kB	✓

Client Pages Modern

	vercel/next.js canary	Timer/next.js revert/14580	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-cb244c4..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.35 kB	5.35 kB	✓

Client Build Manifests

	vercel/next.js canary	Timer/next.js revert/14580	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	Timer/next.js revert/14580	Change
_error.js	1.03 MB	1.03 MB	✓
404.html	4.22 kB	4.22 kB	✓
hooks.html	3.86 kB	3.86 kB	✓
index.js	1.03 MB	1.03 MB	✓
link.js	1.07 MB	1.07 MB	✓
routerDirect.js	1.07 MB	1.07 MB	✓
withRouter.js	1.07 MB	1.07 MB	✓
Overall change	5.28 MB	5.28 MB	✓

Commit: 56b5f16

Revert vercel#14580

bf87f65

Timer requested review from ijjk, lfades and timneutkens as code owners September 1, 2020 17:45

ijjk added the type: next label Sep 1, 2020

ijjk approved these changes Sep 1, 2020

View reviewed changes

Merge branch 'canary' into revert/14580

56b5f16

Merge branch 'canary' into revert/14580

8061975

Timer merged commit e34e5e0 into vercel:canary Sep 1, 2020

Timer deleted the revert/14580 branch September 1, 2020 18:09

ijjk pushed a commit to ijjk/next.js that referenced this pull request Sep 2, 2020

Revert vercel#14580 (vercel#16757)

d3cf1ce

nickluger mentioned this pull request Oct 5, 2020

Event: Non-Error promise rejection captured with keys: currentTarget, isTrusted, target, type getsentry/sentry-javascript#2546

Closed

5 tasks

vercel locked as resolved and limited conversation to collaborators Jan 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert #14580 #16757

Revert #14580 #16757

Timer commented Sep 1, 2020 •

edited

Loading

ijjk commented Sep 1, 2020

Diffs

ijjk commented Sep 1, 2020

Diffs

Revert #14580 #16757

Revert #14580 #16757

Conversation

Timer commented Sep 1, 2020 • edited Loading

ijjk commented Sep 1, 2020

Stats from current PR

Diffs

ijjk commented Sep 1, 2020

Stats from current PR

Diffs

Timer commented Sep 1, 2020 •

edited

Loading