examples/with-styled-components: Fix missing peerDependency #16532

simnalamburt · 2020-08-24T21:05:40Z

styled-components requires 'react-is' as a peerDependency

Reference

https://github.com/styled-components/styled-components/blob/b19d17f/packages/styled-components/package.json#L78

styled-components requires 'react-is' as a peerDependency Reference: https://github.com/styled-components/styled-components/blob/b19d17f/packages/styled-components/package.json#L78

ijjk · 2020-08-24T21:14:14Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
buildDuration	11.1s	11.3s	⚠️ +188ms
nodeModulesSize	57.5 MB	57.5 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.085	1.951	-0.13
/ avg req/sec	1199.05	1281.3	+82.25
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.052	1.092	⚠️ +0.04
/error-in-render avg req/sec	2375.52	2288.66	⚠️ -86.86

Client Bundles (main, webpack, commons)

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
677f882d2ed8..7f47.js gzip	10.3 kB	10.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-7e72e5b..8b35.js gzip	7.2 kB	7.2 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
677f882d2ed8..dule.js gzip	6.15 kB	6.15 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-e35d22e..dule.js gzip	6.24 kB	6.24 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.1 kB	52.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-28298..e0c9.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-000f151..65d4.js gzip	1.29 kB	1.29 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.69 kB	7.69 kB	✓

Client Pages Modern

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-65c8a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-4cfda7a..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.35 kB	5.35 kB	✓

Client Build Manifests

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
index.html gzip	948 B	948 B	✓
link.html gzip	954 B	954 B	✓
withRouter.html gzip	939 B	939 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
buildDuration	12.8s	12.8s	⚠️ +47ms
nodeModulesSize	57.5 MB	57.5 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
677f882d2ed8..7f47.js gzip	10.3 kB	10.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-7e72e5b..8b35.js gzip	7.2 kB	7.2 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
677f882d2ed8..dule.js gzip	6.15 kB	6.15 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-e35d22e..dule.js gzip	6.24 kB	6.24 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.1 kB	52.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-28298..e0c9.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-000f151..65d4.js gzip	1.29 kB	1.29 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.69 kB	7.69 kB	✓

Client Pages Modern

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-65c8a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-4cfda7a..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.35 kB	5.35 kB	✓

Client Build Manifests

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
_error.js	1.03 MB	1.03 MB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.03 MB	1.03 MB	✓
link.js	1.07 MB	1.07 MB	✓
routerDirect.js	1.07 MB	1.07 MB	✓
withRouter.js	1.07 MB	1.07 MB	✓
Overall change	5.28 MB	5.28 MB	✓

Commit: e0daaac

lfades

@simnalamburt Thank you!

lfades

Just noticed something, can you please make the PR to canary 🙏 . canary is our default branch and all PRs should go there.

changed merge target

ijjk · 2020-08-25T04:41:06Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
buildDuration	12.2s	11.9s	-320ms
nodeModulesSize	57.5 MB	57.5 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.109	2.135	⚠️ +0.03
/ avg req/sec	1185.61	1171.16	⚠️ -14.45
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.286	1.33	⚠️ +0.04
/error-in-render avg req/sec	1943.29	1880.35	⚠️ -62.94

Client Bundles (main, webpack, commons)

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
677f882d2ed8..7f47.js gzip	10.3 kB	10.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-7e72e5b..8b35.js gzip	7.2 kB	7.2 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
677f882d2ed8..dule.js gzip	6.15 kB	6.15 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-e35d22e..dule.js gzip	6.24 kB	6.24 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.1 kB	52.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-28298..e0c9.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-000f151..65d4.js gzip	1.29 kB	1.29 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.69 kB	7.69 kB	✓

Client Pages Modern

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-65c8a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-4cfda7a..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.35 kB	5.35 kB	✓

Client Build Manifests

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
index.html gzip	948 B	948 B	✓
link.html gzip	954 B	954 B	✓
withRouter.html gzip	939 B	939 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
buildDuration	13.4s	13.2s	-250ms
nodeModulesSize	57.5 MB	57.5 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
677f882d2ed8..7f47.js gzip	10.3 kB	10.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-7e72e5b..8b35.js gzip	7.2 kB	7.2 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
677f882d2ed8..dule.js gzip	6.15 kB	6.15 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-e35d22e..dule.js gzip	6.24 kB	6.24 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.1 kB	52.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-28298..e0c9.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-000f151..65d4.js gzip	1.29 kB	1.29 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.69 kB	7.69 kB	✓

Client Pages Modern

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-65c8a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-4cfda7a..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.35 kB	5.35 kB	✓

Client Build Manifests

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	simnalamburt/next.js patch-1	Change
_error.js	1.03 MB	1.03 MB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.03 MB	1.03 MB	✓
link.js	1.07 MB	1.07 MB	✓
routerDirect.js	1.07 MB	1.07 MB	✓
withRouter.js	1.07 MB	1.07 MB	✓
Overall change	5.28 MB	5.28 MB	✓

Commit: e9b3dc0

simnalamburt · 2020-08-25T07:54:56Z

Just noticed something, can you please make the PR to canary 🙏 . canary is our default branch and all PRs should go there.

Oops I didn't noticed that!

changed merge target

Thanks!

examples/with-styled-components: Fix missing peerDependency

e0daaac

styled-components requires 'react-is' as a peerDependency Reference: https://github.com/styled-components/styled-components/blob/b19d17f/packages/styled-components/package.json#L78

simnalamburt requested review from chibicode, ijjk, lfades, Timer and timneutkens as code owners August 24, 2020 21:05

ijjk added the examples Issue was opened via the examples template. label Aug 24, 2020

lfades approved these changes Aug 24, 2020

View reviewed changes

lfades previously requested changes Aug 24, 2020

View reviewed changes

Timer changed the base branch from master to canary August 25, 2020 04:30

Timer approved these changes Aug 25, 2020

View reviewed changes

kodiakhq bot added 2 commits August 25, 2020 04:31

Merge branch 'canary' into patch-1

f59c7fd

Merge branch 'canary' into patch-1

e9b3dc0

kodiakhq bot merged commit 35a90d0 into vercel:canary Aug 25, 2020

simnalamburt deleted the patch-1 branch August 25, 2020 08:35

vercel locked as resolved and limited conversation to collaborators Jan 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

examples/with-styled-components: Fix missing peerDependency #16532

examples/with-styled-components: Fix missing peerDependency #16532

simnalamburt commented Aug 24, 2020

ijjk commented Aug 24, 2020

lfades left a comment

lfades left a comment

ijjk commented Aug 25, 2020

simnalamburt commented Aug 25, 2020

examples/with-styled-components: Fix missing peerDependency #16532

examples/with-styled-components: Fix missing peerDependency #16532

Conversation

simnalamburt commented Aug 24, 2020

Reference

ijjk commented Aug 24, 2020

Stats from current PR

lfades left a comment

Choose a reason for hiding this comment

lfades left a comment

Choose a reason for hiding this comment

ijjk commented Aug 25, 2020

Stats from current PR

simnalamburt commented Aug 25, 2020