Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove experimental example #16497

Merged
merged 1 commit into from
Aug 23, 2020
Merged

Remove experimental example #16497

merged 1 commit into from
Aug 23, 2020

Conversation

lfades
Copy link
Member

@lfades lfades commented Aug 23, 2020

@Timer This example seems to not be needed anymore

@ijjk ijjk added the examples Issue was opened via the examples template. label Aug 23, 2020
@ijjk
Copy link
Member

ijjk commented Aug 23, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary lfades/next.js examples/remove-z-experimental-refresh Change
buildDuration 9.5s 9.4s -68ms
nodeModulesSize 57.5 MB 57.5 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary lfades/next.js examples/remove-z-experimental-refresh Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.796 1.77 -0.03
/ avg req/sec 1391.9 1412.58 +20.68
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 0.917 0.981 ⚠️ +0.06
/error-in-render avg req/sec 2724.86 2548.22 ⚠️ -176.64
Client Bundles (main, webpack, commons)
vercel/next.js canary lfades/next.js examples/remove-z-experimental-refresh Change
677f882d2ed8..7f47.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-978aff6..e7ab.js gzip 7.2 kB 7.2 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary lfades/next.js examples/remove-z-experimental-refresh Change
677f882d2ed8..dule.js gzip 6.15 kB 6.15 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-46b15db..dule.js gzip 6.24 kB 6.24 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.1 kB 52.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary lfades/next.js examples/remove-z-experimental-refresh Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary lfades/next.js examples/remove-z-experimental-refresh Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary lfades/next.js examples/remove-z-experimental-refresh Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary lfades/next.js examples/remove-z-experimental-refresh Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary lfades/next.js examples/remove-z-experimental-refresh Change
index.html gzip 949 B 949 B ✓
link.html gzip 955 B 955 B ✓
withRouter.html gzip 940 B 940 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary lfades/next.js examples/remove-z-experimental-refresh Change
buildDuration 11.2s 10.5s -721ms
nodeModulesSize 57.5 MB 57.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary lfades/next.js examples/remove-z-experimental-refresh Change
677f882d2ed8..7f47.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-978aff6..e7ab.js gzip 7.2 kB 7.2 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary lfades/next.js examples/remove-z-experimental-refresh Change
677f882d2ed8..dule.js gzip 6.15 kB 6.15 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-46b15db..dule.js gzip 6.24 kB 6.24 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.1 kB 52.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary lfades/next.js examples/remove-z-experimental-refresh Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary lfades/next.js examples/remove-z-experimental-refresh Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary lfades/next.js examples/remove-z-experimental-refresh Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary lfades/next.js examples/remove-z-experimental-refresh Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary lfades/next.js examples/remove-z-experimental-refresh Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.28 MB 5.28 MB ✓
Commit: 03b3fbc

@kodiakhq kodiakhq bot merged commit ec281df into vercel:canary Aug 23, 2020
@Timer
Copy link
Member

Timer commented Aug 24, 2020

Aah, I actually used this example nearly daily haha. I would've preferred to just remove the experimental name from it and make it like fast-refresh-demo or something.

@lfades lfades mentioned this pull request Aug 24, 2020
Closed
@YichiZ YichiZ mentioned this pull request Aug 26, 2020
Merged
kodiakhq bot pushed a commit that referenced this pull request Sep 1, 2020
@YichiZ
Add Fast Refresh Demo (#16576)
9e4bb5a 
Closes #16538 

Basically reverts #16497 and some minor changes. Also adds a link in the docs.

This reverts commit ec281df.
ijjk pushed a commit to ijjk/next.js that referenced this pull request Sep 2, 2020
@YichiZ @ijjk
Add Fast Refresh Demo (vercel#16576)
936d3f3 
Closes vercel#16538 

Basically reverts vercel#16497 and some minor changes. Also adds a link in the docs.

This reverts commit ec281df.
HitoriSensei pushed a commit to HitoriSensei/next.js that referenced this pull request Sep 26, 2020
@YichiZ
Add Fast Refresh Demo (vercel#16576)
251b0e7 
Closes vercel#16538 

Basically reverts vercel#16497 and some minor changes. Also adds a link in the docs.

This reverts commit ec281df.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lfades @ijjk @Timer @timneutkens