Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webpack 5 caching for css optimizer #16467

Merged

Conversation

timneutkens
Copy link
Member

This makes sure we leverage caching for the css optimizer.

@ijjk
Copy link
Member

ijjk commented Aug 22, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/webpack-5-caching-css-optimization Change
buildDuration 11.4s 12.1s ⚠️ +639ms
nodeModulesSize 57.5 MB 57.5 MB ⚠️ +2.9 kB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js add/webpack-5-caching-css-optimization Change
/ failed reqs 0 0
/ total time (seconds) 2.107 2.112 0
/ avg req/sec 1186.8 1183.5 ⚠️ -3.3
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.174 1.126 -0.05
/error-in-render avg req/sec 2129.74 2220.05 +90.31
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/webpack-5-caching-css-optimization Change
677f882d2ed8..1962.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39 kB 39 kB
main-3aeb17d..193e.js gzip 7.2 kB 7.2 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js add/webpack-5-caching-css-optimization Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-e67bd4d..dule.js gzip 6.21 kB 6.21 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52 kB 52 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/webpack-5-caching-css-optimization Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js add/webpack-5-caching-css-optimization Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-000f151..65d4.js gzip 1.29 kB 1.29 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.69 kB 7.69 kB
Client Pages Modern
vercel/next.js canary timneutkens/next.js add/webpack-5-caching-css-optimization Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.35 kB 5.35 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/webpack-5-caching-css-optimization Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 330 B 330 B
Overall change 652 B 652 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/webpack-5-caching-css-optimization Change
index.html gzip 945 B 945 B
link.html gzip 952 B 952 B
withRouter.html gzip 937 B 937 B
Overall change 2.83 kB 2.83 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/webpack-5-caching-css-optimization Change
buildDuration 13.3s 13.5s ⚠️ +216ms
nodeModulesSize 57.5 MB 57.5 MB ⚠️ +2.9 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/webpack-5-caching-css-optimization Change
677f882d2ed8..1962.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39 kB 39 kB
main-3aeb17d..193e.js gzip 7.2 kB 7.2 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js add/webpack-5-caching-css-optimization Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-e67bd4d..dule.js gzip 6.21 kB 6.21 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52 kB 52 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/webpack-5-caching-css-optimization Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js add/webpack-5-caching-css-optimization Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-000f151..65d4.js gzip 1.29 kB 1.29 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.69 kB 7.69 kB
Client Pages Modern
vercel/next.js canary timneutkens/next.js add/webpack-5-caching-css-optimization Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.35 kB 5.35 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/webpack-5-caching-css-optimization Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 330 B 330 B
Overall change 652 B 652 B
Serverless bundles
vercel/next.js canary timneutkens/next.js add/webpack-5-caching-css-optimization Change
_error.js 1.03 MB 1.03 MB
404.html 4.18 kB 4.18 kB
hooks.html 3.82 kB 3.82 kB
index.js 1.03 MB 1.03 MB
link.js 1.07 MB 1.07 MB
routerDirect.js 1.07 MB 1.07 MB
withRouter.js 1.07 MB 1.07 MB
Overall change 5.28 MB 5.28 MB
Commit: df1d06b

@timneutkens timneutkens merged commit d075499 into vercel:canary Aug 22, 2020
@timneutkens timneutkens deleted the add/webpack-5-caching-css-optimization branch August 22, 2020 12:16
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants