Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error when document component isn't rendered #16459

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Add error when document component isn't rendered #16459

merged 2 commits into from
Aug 24, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 21, 2020

If a custom _document is added but not all of the expected document components are rendered it can cause unintended errors as noticed in #10219 so this adds detecting when one of the expected document components isn't rendered and shows an error.

Closes: #10219

@ijjk
Copy link
Member Author

ijjk commented Aug 21, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js error/missing-document-component Change
buildDuration 12.1s 12.1s -52ms
nodeModulesSize 57.5 MB 57.5 MB ⚠️ +3.48 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js error/missing-document-component Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.233 2.162 -0.07
/ avg req/sec 1119.47 1156.13 +36.66
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.221 1.2 -0.02
/error-in-render avg req/sec 2047.96 2083.2 +35.24
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js error/missing-document-component Change
677f882d2ed8..4e55.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-3aeb17d..193e.js gzip 7.2 kB 7.2 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js error/missing-document-component Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-e67bd4d..dule.js gzip 6.21 kB 6.21 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52 kB 52 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js error/missing-document-component Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js error/missing-document-component Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js error/missing-document-component Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js error/missing-document-component Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js error/missing-document-component Change
index.html gzip 946 B 946 B ✓
link.html gzip 952 B 952 B ✓
withRouter.html gzip 937 B 937 B ✓
Overall change 2.83 kB 2.83 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js error/missing-document-component Change
buildDuration 14.1s 13.8s -315ms
nodeModulesSize 57.5 MB 57.5 MB ⚠️ +3.48 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js error/missing-document-component Change
677f882d2ed8..4e55.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-3aeb17d..193e.js gzip 7.2 kB 7.2 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js error/missing-document-component Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-e67bd4d..dule.js gzip 6.21 kB 6.21 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52 kB 52 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js error/missing-document-component Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js error/missing-document-component Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js error/missing-document-component Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js error/missing-document-component Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js error/missing-document-component Change
_error.js 1.03 MB 1.03 MB ⚠️ +362 B
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ⚠️ +362 B
link.js 1.07 MB 1.07 MB ⚠️ +362 B
routerDirect.js 1.07 MB 1.07 MB ⚠️ +362 B
withRouter.js 1.07 MB 1.07 MB ⚠️ +362 B
Overall change 5.28 MB 5.28 MB ⚠️ +1.81 kB
Commit: d90c291

Timer
Timer approved these changes Aug 24, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Epic!

@ijjk
Copy link
Member Author

ijjk commented Aug 24, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js error/missing-document-component Change
buildDuration 12s 12.2s ⚠️ +235ms
nodeModulesSize 57.5 MB 57.5 MB ⚠️ +3.48 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js error/missing-document-component Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.103 2.182 ⚠️ +0.08
/ avg req/sec 1188.96 1145.85 ⚠️ -43.11
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.223 1.178 -0.05
/error-in-render avg req/sec 2043.76 2122.88 +79.12
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js error/missing-document-component Change
677f882d2ed8..7f47.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-978aff6..e7ab.js gzip 7.2 kB 7.2 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js error/missing-document-component Change
677f882d2ed8..dule.js gzip 6.15 kB 6.15 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-46b15db..dule.js gzip 6.24 kB 6.24 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.1 kB 52.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js error/missing-document-component Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js error/missing-document-component Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js error/missing-document-component Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js error/missing-document-component Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js error/missing-document-component Change
index.html gzip 949 B 949 B ✓
link.html gzip 955 B 955 B ✓
withRouter.html gzip 940 B 940 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js error/missing-document-component Change
buildDuration 13.3s 13.2s -118ms
nodeModulesSize 57.5 MB 57.5 MB ⚠️ +3.48 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js error/missing-document-component Change
677f882d2ed8..7f47.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-978aff6..e7ab.js gzip 7.2 kB 7.2 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js error/missing-document-component Change
677f882d2ed8..dule.js gzip 6.15 kB 6.15 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-46b15db..dule.js gzip 6.24 kB 6.24 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.1 kB 52.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js error/missing-document-component Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js error/missing-document-component Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js error/missing-document-component Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js error/missing-document-component Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js error/missing-document-component Change
_error.js 1.03 MB 1.03 MB ⚠️ +362 B
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ⚠️ +362 B
link.js 1.07 MB 1.07 MB ⚠️ +362 B
routerDirect.js 1.07 MB 1.07 MB ⚠️ +362 B
withRouter.js 1.07 MB 1.07 MB ⚠️ +362 B
Overall change 5.28 MB 5.28 MB ⚠️ +1.81 kB
Commit: 8aaf216

@kodiakhq kodiakhq bot merged commit a7550bf into vercel:canary Aug 24, 2020
@ijjk ijjk deleted the error/missing-document-component branch September 2, 2020 06:19
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pruhstal pruhstal pruhstal left review comments

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

global css in _app throwing error
3 participants
@ijjk @Timer @pruhstal