Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support className prop in next/link #1642

Closed
wants to merge 1 commit into from

Conversation

winglian
Copy link

@winglian winglian commented Apr 6, 2017

Currently the className prop when passed to next/link is dropped. This will at least allow it to be targetable/styled by class.

@sergiodxa
Copy link
Contributor

sergiodxa commented Apr 6, 2017

You must add your className to the <a /> you place inside the <Link />. Link it's just a HOC to handle the route change using the Next Router, it's not supposed to receive any other props. Check this old issues:

@arunoda
Copy link
Contributor

arunoda commented Apr 7, 2017

Thanks @sergiodxa for the refs.
As we discussed, we are not going to add this.

@arunoda arunoda closed this Apr 7, 2017
@ghost ghost mentioned this pull request Jun 14, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants