Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rewrite params query appending #16189

Merged
merged 4 commits into from
Aug 14, 2020
Merged

Update rewrite params query appending #16189

merged 4 commits into from
Aug 14, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 14, 2020

This updates to not automatically append params to the query for rewrites if one or more of the params are already used in the destination's path. No other behavior is being changed and if the user still wants the params in the query after using them in the destination's path they can manually add them like with redirects.

Closes: #15626

@ijjk ijjk mentioned this pull request Aug 14, 2020
Merged
@ijjk
Copy link
Member Author

ijjk commented Aug 14, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
buildDuration 11.7s 11.8s ⚠️ +122ms
nodeModulesSize 57.3 MB 57.3 MB ⚠️ +1.86 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.187 2.216 ⚠️ +0.03
/ avg req/sec 1143.02 1127.92 ⚠️ -15.1
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.367 1.301 -0.07
/error-in-render avg req/sec 1828.5 1920.91 +92.41
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
677f882d2ed8..c139.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-d9f8cd0..c4c7.js gzip 6.74 kB 6.74 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-b9a17ec..dule.js gzip 5.82 kB 5.82 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 650 B 650 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
index.html gzip 946 B 946 B ✓
link.html gzip 954 B 954 B ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
buildDuration 13.6s 13.6s -60ms
nodeModulesSize 57.3 MB 57.3 MB ⚠️ +1.86 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
677f882d2ed8..c139.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-d9f8cd0..c4c7.js gzip 6.74 kB 6.74 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-b9a17ec..dule.js gzip 5.82 kB 5.82 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 650 B 650 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
_error.js 1.03 MB 1.03 MB ⚠️ +1.34 kB
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ⚠️ +1.34 kB
link.js 1.07 MB 1.07 MB ⚠️ +1.34 kB
routerDirect.js 1.06 MB 1.06 MB ⚠️ +1.34 kB
withRouter.js 1.06 MB 1.06 MB ⚠️ +1.34 kB
Overall change 5.26 MB 5.27 MB ⚠️ +6.68 kB
Commit: 595d9f1

timneutkens
timneutkens previously approved these changes Aug 14, 2020
View reviewed changes
@ijjk

This comment has been minimized.

Sign in to view
@ijjk ijjk requested a review from timneutkens August 14, 2020 15:27
@ijjk
Copy link
Member Author

ijjk commented Aug 14, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
buildDuration 14s 13.7s -225ms
nodeModulesSize 57.3 MB 57.3 MB ⚠️ +1.86 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.526 2.512 -0.01
/ avg req/sec 989.8 995.03 +5.23
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.537 1.555 ⚠️ +0.02
/error-in-render avg req/sec 1626.11 1607.29 ⚠️ -18.82
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
677f882d2ed8..c139.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-d9f8cd0..c4c7.js gzip 6.74 kB 6.74 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-b9a17ec..dule.js gzip 5.82 kB 5.82 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 650 B 650 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
index.html gzip 946 B 946 B ✓
link.html gzip 954 B 954 B ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
buildDuration 15.5s 15.5s -24ms
nodeModulesSize 57.3 MB 57.3 MB ⚠️ +1.86 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
677f882d2ed8..c139.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-d9f8cd0..c4c7.js gzip 6.74 kB 6.74 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-b9a17ec..dule.js gzip 5.82 kB 5.82 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 650 B 650 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
_error.js 1.03 MB 1.03 MB ⚠️ +1.34 kB
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ⚠️ +1.34 kB
link.js 1.07 MB 1.07 MB ⚠️ +1.34 kB
routerDirect.js 1.06 MB 1.06 MB ⚠️ +1.34 kB
withRouter.js 1.06 MB 1.06 MB ⚠️ +1.34 kB
Overall change 5.26 MB 5.27 MB ⚠️ +6.68 kB
Commit: 021febf

kodiakhq bot pushed a commit to vercel/vercel that referenced this pull request Aug 14, 2020
@ijjk
[routing-utils] Update rewrite params query appending (#5040)
070bbd5 
This updates to not automatically append params to the query for rewrites if one or more of the params are already used in the destination's path. No other behavior is being changed and if the user still wants the params in the query after using them in the destination's path they can manually add them like with redirects.

x-ref: vercel/next.js#16189
@ijjk
Copy link
Member Author

ijjk commented Aug 14, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
buildDuration 13.9s 13.9s ⚠️ +40ms
nodeModulesSize 57.3 MB 57.3 MB ⚠️ +1.86 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.506 2.618 ⚠️ +0.11
/ avg req/sec 997.65 954.86 ⚠️ -42.79
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.522 1.515 -0.01
/error-in-render avg req/sec 1642.32 1650.21 +7.89
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
677f882d2ed8..c139.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-d9f8cd0..c4c7.js gzip 6.74 kB 6.74 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-b9a17ec..dule.js gzip 5.82 kB 5.82 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 650 B 650 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
index.html gzip 946 B 946 B ✓
link.html gzip 954 B 954 B ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
buildDuration 16.1s 15.6s -490ms
nodeModulesSize 57.3 MB 57.3 MB ⚠️ +1.86 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
677f882d2ed8..c139.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-d9f8cd0..c4c7.js gzip 6.74 kB 6.74 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-b9a17ec..dule.js gzip 5.82 kB 5.82 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 650 B 650 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/rewrite-query-appending Change
_error.js 1.03 MB 1.03 MB ⚠️ +1.34 kB
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ⚠️ +1.34 kB
link.js 1.07 MB 1.07 MB ⚠️ +1.34 kB
routerDirect.js 1.06 MB 1.06 MB ⚠️ +1.34 kB
withRouter.js 1.06 MB 1.06 MB ⚠️ +1.34 kB
Overall change 5.26 MB 5.27 MB ⚠️ +6.68 kB
Commit: fddd30b

@kodiakhq kodiakhq bot merged commit 1b4d463 into vercel:canary Aug 14, 2020
@ijjk ijjk deleted the update/rewrite-query-appending branch August 14, 2020 20:32
m-lautenbach pushed a commit to m-lautenbach/next.js that referenced this pull request Aug 20, 2020
@ijjk
Update rewrite params query appending (vercel#16189)
0b92d83 
This updates to not automatically append params to the query for rewrites if one or more of the params are already used in the destination's path. No other behavior is being changed and if the user still wants the params in the query after using them in the destination's path they can manually add them like with redirects.

Closes: vercel#15626
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite adds query param when re-appending a matched path param to the destination
2 participants
@ijjk @timneutkens