Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strongly type Head Manager #16144

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Strongly type Head Manager #16144

merged 1 commit into from
Aug 13, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented Aug 13, 2020

This strongly types the head manager in prep for typing next/client.


Fixes #16143

@ijjk
Copy link
Member

ijjk commented Aug 13, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js types/head-manager Change
buildDuration 12.5s 12.9s ⚠️ +342ms
nodeModulesSize 57.3 MB 57.3 MB ⚠️ +425 B
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js types/head-manager Change
/ failed reqs 0 0
/ total time (seconds) 2.202 2.248 ⚠️ +0.05
/ avg req/sec 1135.58 1111.93 ⚠️ -23.65
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.24 1.225 -0.01
/error-in-render avg req/sec 2016 2040.65 +24.65
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js types/head-manager Change
677f882d2ed8..ee8a.js gzip 10 kB 10 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-25aa383..eece.js gzip 6.72 kB 6.72 kB
webpack-ccf5..276a.js gzip 751 B 751 B
Overall change 56.6 kB 56.6 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js types/head-manager Change
677f882d2ed8..dule.js gzip 5.92 kB 5.92 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-08f768c..dule.js gzip 5.79 kB 5.79 kB
webpack-10c7..dule.js gzip 751 B 751 B
Overall change 51.6 kB 51.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js types/head-manager Change
polyfills-75..1629.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary Timer/next.js types/head-manager Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB
hooks-585f07..95a3.js gzip 887 B 887 B
index-c7b63f..fc02.js gzip 227 B 227 B
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB
routerDirect..ebc7.js gzip 284 B 284 B
withRouter-2..db68.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary Timer/next.js types/head-manager Change
_app-97e743e..dule.js gzip 626 B 626 B
_error-b4004..dule.js gzip 2.3 kB 2.3 kB
hooks-696209..dule.js gzip 387 B 387 B
index-a4dd74..dule.js gzip 226 B 226 B
link-236a801..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-1..dule.js gzip 282 B 282 B
Overall change 5.37 kB 5.37 kB
Client Build Manifests
vercel/next.js canary Timer/next.js types/head-manager Change
_buildManifest.js gzip 273 B 273 B
_buildManife..dule.js gzip 279 B 279 B
Overall change 552 B 552 B
Rendered Page Sizes
vercel/next.js canary Timer/next.js types/head-manager Change
index.html gzip 947 B 947 B
link.html gzip 955 B 955 B
withRouter.html gzip 939 B 939 B
Overall change 2.84 kB 2.84 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js types/head-manager Change
buildDuration 14.3s 14.2s -120ms
nodeModulesSize 57.3 MB 57.3 MB ⚠️ +425 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js types/head-manager Change
677f882d2ed8..ee8a.js gzip 10 kB 10 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-25aa383..eece.js gzip 6.72 kB 6.72 kB
webpack-ccf5..276a.js gzip 751 B 751 B
Overall change 56.6 kB 56.6 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js types/head-manager Change
677f882d2ed8..dule.js gzip 5.92 kB 5.92 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-08f768c..dule.js gzip 5.79 kB 5.79 kB
webpack-10c7..dule.js gzip 751 B 751 B
Overall change 51.6 kB 51.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js types/head-manager Change
polyfills-75..1629.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary Timer/next.js types/head-manager Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB
hooks-585f07..95a3.js gzip 887 B 887 B
index-c7b63f..fc02.js gzip 227 B 227 B
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB
routerDirect..ebc7.js gzip 284 B 284 B
withRouter-2..db68.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary Timer/next.js types/head-manager Change
_app-97e743e..dule.js gzip 626 B 626 B
_error-b4004..dule.js gzip 2.3 kB 2.3 kB
hooks-696209..dule.js gzip 387 B 387 B
index-a4dd74..dule.js gzip 226 B 226 B
link-236a801..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-1..dule.js gzip 282 B 282 B
Overall change 5.37 kB 5.37 kB
Client Build Manifests
vercel/next.js canary Timer/next.js types/head-manager Change
_buildManifest.js gzip 273 B 273 B
_buildManife..dule.js gzip 279 B 279 B
Overall change 552 B 552 B
Serverless bundles
vercel/next.js canary Timer/next.js types/head-manager Change
_error.js 1.03 MB 1.03 MB
404.html 4.18 kB 4.18 kB
hooks.html 3.82 kB 3.82 kB
index.js 1.03 MB 1.03 MB
link.js 1.07 MB 1.07 MB
routerDirect.js 1.06 MB 1.06 MB
withRouter.js 1.06 MB 1.06 MB
Overall change 5.26 MB 5.26 MB
Commit: cf5971f

@Timer Timer merged commit 16e4f9e into vercel:canary Aug 13, 2020
@Timer Timer deleted the types/head-manager branch August 13, 2020 03:54
m-lautenbach pushed a commit to m-lautenbach/next.js that referenced this pull request Aug 20, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[internal] Strongly type Head Manager
2 participants