Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in export-all-in-page #15925

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

matamatanot
Copy link
Contributor

No description provided.

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@ijjk
Copy link
Member

ijjk commented Aug 6, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary matamatanot/next.js fix-Re-exporting-typo Change
buildDuration 12.7s 12.9s ⚠️ +136ms
nodeModulesSize 66 MB 66 MB
Page Load Tests Overall increase ✓
vercel/next.js canary matamatanot/next.js fix-Re-exporting-typo Change
/ failed reqs 0 0
/ total time (seconds) 2.279 2.248 -0.03
/ avg req/sec 1097.02 1111.85 +14.83
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.293 1.267 -0.03
/error-in-render avg req/sec 1933.15 1973 +39.85
Client Bundles (main, webpack, commons)
vercel/next.js canary matamatanot/next.js fix-Re-exporting-typo Change
677f882d2ed8..8895.js gzip 10.3 kB 10.3 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-da9f477..d581.js gzip 6.73 kB 6.73 kB
webpack-ccf5..276a.js gzip 751 B 751 B
Overall change 56.9 kB 56.9 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary matamatanot/next.js fix-Re-exporting-typo Change
677f882d2ed8..dule.js gzip 6.21 kB 6.21 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-ccc9938..dule.js gzip 5.81 kB 5.81 kB
webpack-10c7..dule.js gzip 751 B 751 B
Overall change 51.9 kB 51.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary matamatanot/next.js fix-Re-exporting-typo Change
polyfills-75..1629.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary matamatanot/next.js fix-Re-exporting-typo Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB
hooks-585f07..95a3.js gzip 887 B 887 B
index-c7b63f..fc02.js gzip 227 B 227 B
link-f4d2979..e57b.js gzip 1.29 kB 1.29 kB
routerDirect..ebc7.js gzip 284 B 284 B
withRouter-2..db68.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary matamatanot/next.js fix-Re-exporting-typo Change
_app-97e743e..dule.js gzip 626 B 626 B
_error-b4004..dule.js gzip 2.3 kB 2.3 kB
hooks-696209..dule.js gzip 387 B 387 B
index-a4dd74..dule.js gzip 226 B 226 B
link-653c74f..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-1..dule.js gzip 282 B 282 B
Overall change 5.37 kB 5.37 kB
Client Build Manifests
vercel/next.js canary matamatanot/next.js fix-Re-exporting-typo Change
_buildManifest.js gzip 273 B 273 B
_buildManife..dule.js gzip 280 B 280 B
Overall change 553 B 553 B
Rendered Page Sizes
vercel/next.js canary matamatanot/next.js fix-Re-exporting-typo Change
index.html gzip 947 B 947 B
link.html gzip 953 B 953 B
withRouter.html gzip 942 B 942 B
Overall change 2.84 kB 2.84 kB

Serverless Mode
General
vercel/next.js canary matamatanot/next.js fix-Re-exporting-typo Change
buildDuration 14.2s 14.3s ⚠️ +138ms
nodeModulesSize 66 MB 66 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary matamatanot/next.js fix-Re-exporting-typo Change
677f882d2ed8..8895.js gzip 10.3 kB 10.3 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-da9f477..d581.js gzip 6.73 kB 6.73 kB
webpack-ccf5..276a.js gzip 751 B 751 B
Overall change 56.9 kB 56.9 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary matamatanot/next.js fix-Re-exporting-typo Change
677f882d2ed8..dule.js gzip 6.21 kB 6.21 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-ccc9938..dule.js gzip 5.81 kB 5.81 kB
webpack-10c7..dule.js gzip 751 B 751 B
Overall change 51.9 kB 51.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary matamatanot/next.js fix-Re-exporting-typo Change
polyfills-75..1629.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary matamatanot/next.js fix-Re-exporting-typo Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB
hooks-585f07..95a3.js gzip 887 B 887 B
index-c7b63f..fc02.js gzip 227 B 227 B
link-f4d2979..e57b.js gzip 1.29 kB 1.29 kB
routerDirect..ebc7.js gzip 284 B 284 B
withRouter-2..db68.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary matamatanot/next.js fix-Re-exporting-typo Change
_app-97e743e..dule.js gzip 626 B 626 B
_error-b4004..dule.js gzip 2.3 kB 2.3 kB
hooks-696209..dule.js gzip 387 B 387 B
index-a4dd74..dule.js gzip 226 B 226 B
link-653c74f..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-1..dule.js gzip 282 B 282 B
Overall change 5.37 kB 5.37 kB
Client Build Manifests
vercel/next.js canary matamatanot/next.js fix-Re-exporting-typo Change
_buildManifest.js gzip 273 B 273 B
_buildManife..dule.js gzip 280 B 280 B
Overall change 553 B 553 B
Serverless bundles
vercel/next.js canary matamatanot/next.js fix-Re-exporting-typo Change
_error.js 1.02 MB 1.02 MB
404.html 4.18 kB 4.18 kB
hooks.html 3.82 kB 3.82 kB
index.js 1.02 MB 1.02 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.22 MB 5.22 MB
Commit: 7a65db3

@kodiakhq kodiakhq bot merged commit 2c42444 into vercel:canary Aug 6, 2020
@matamatanot matamatanot deleted the fix-Re-exporting-typo branch October 30, 2021 09:54
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants