Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance module not found error #15860

Merged
merged 8 commits into from
Aug 5, 2020
Merged

Enhance module not found error #15860

merged 8 commits into from
Aug 5, 2020

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Aug 4, 2020 •
edited
Loading

Adds handling for module not found errors exposed by webpack. This ensures you see the actual stack line and code instead of a short message where you don't know where to go.

Previous

Screen Shot 2020-08-05 at 18 02 06

New

Screen Shot 2020-08-05 at 14 20 23

Fixes #14711

@ijjk
Copy link
Member

ijjk commented Aug 4, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
buildDuration 12.9s 13.1s ⚠️ +222ms
nodeModulesSize 65.5 MB 65.5 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.431 2.422 -0.01
/ avg req/sec 1028.45 1032.36 +3.91
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.522 1.504 -0.02
/error-in-render avg req/sec 1642.3 1661.94 +19.64
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-2ecb3b8..bd63.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-dbff266..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-e97733c..af21.js gzip 1.3 kB 1.3 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_buildManifest.js gzip 272 B 272 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 552 B 552 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
index.html gzip 944 B 944 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 940 B 940 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
buildDuration 14.2s 14.8s ⚠️ +656ms
nodeModulesSize 65.5 MB 65.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-2ecb3b8..bd63.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-dbff266..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-e97733c..af21.js gzip 1.3 kB 1.3 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_buildManifest.js gzip 272 B 272 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 552 B 552 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_error.js 1.02 MB 1.02 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.2 MB 5.2 MB ✓
Commit: 0c3de1a

Timer
Timer requested changes Aug 5, 2020
View reviewed changes
test/acceptance/ReactRefreshLogBox.test.js Outdated Show resolved Hide resolved
@ijjk ijjk added the type: next label Aug 5, 2020
@ijjk
Copy link
Member

ijjk commented Aug 5, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
buildDuration 14.3s 14.2s -25ms
nodeModulesSize 66 MB 66 MB ⚠️ +6.47 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.553 2.56 ⚠️ +0.01
/ avg req/sec 979.1 976.47 ⚠️ -2.63
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.553 1.589 ⚠️ +0.04
/error-in-render avg req/sec 1609.55 1573.23 ⚠️ -36.32
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-76d73eb..95d8.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-0b6ca7d..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-e97733c..af21.js gzip 1.3 kB 1.3 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_buildManifest.js gzip 272 B 272 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 552 B 552 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
index.html gzip 945 B 945 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
buildDuration 15.6s 15.5s -108ms
nodeModulesSize 66 MB 66 MB ⚠️ +6.47 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-76d73eb..95d8.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-0b6ca7d..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-e97733c..af21.js gzip 1.3 kB 1.3 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_buildManifest.js gzip 272 B 272 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 552 B 552 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_error.js 1.02 MB 1.02 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.2 MB 5.2 MB ✓
Commit: c381760

@ijjk
Copy link
Member

ijjk commented Aug 5, 2020 •
edited
Loading

Failing test suites

Commit: c381760

test/integration/jsconfig-paths/test/index.test.js

  • TypeScript Features > default behavior > should have correct module not found error
Expand output

● TypeScript Features › default behavior › should have correct module not found error

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  78 |       )
  79 |       await fs.writeFile(basicPage, contents)
> 80 |       expect(found).toBe(true)
     |                     ^
  81 |     })
  82 |   })
  83 | })

  at Object.<anonymous> (integration/jsconfig-paths/test/index.test.js:80:21)

test/integration/jsconfig-baseurl/test/index.test.js

  • TypeScript Features > default behavior > should have correct module not found error
Expand output

● TypeScript Features › default behavior › should have correct module not found error

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  61 |       )
  62 |       await fs.writeFile(basicPage, contents)
> 63 |       expect(found).toBe(true)
     |                     ^
  64 |     })
  65 |   })
  66 | })

  at Object.<anonymous> (integration/jsconfig-baseurl/test/index.test.js:63:21)

@ijjk
Copy link
Member

ijjk commented Aug 5, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
buildDuration 11.8s 12.7s ⚠️ +909ms
nodeModulesSize 66 MB 66 MB ⚠️ +6.43 kB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.159 2.233 ⚠️ +0.07
/ avg req/sec 1158.17 1119.46 ⚠️ -38.71
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.244 1.196 -0.05
/error-in-render avg req/sec 2009.22 2090.49 +81.27
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-76d73eb..95d8.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-0b6ca7d..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-e97733c..af21.js gzip 1.3 kB 1.3 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_buildManifest.js gzip 272 B 272 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 552 B 552 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
index.html gzip 945 B 945 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
buildDuration 13.1s 13.6s ⚠️ +478ms
nodeModulesSize 66 MB 66 MB ⚠️ +6.43 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-76d73eb..95d8.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-0b6ca7d..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-e97733c..af21.js gzip 1.3 kB 1.3 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_buildManifest.js gzip 272 B 272 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 552 B 552 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_error.js 1.02 MB 1.02 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.2 MB 5.2 MB ✓
Commit: fb6db7c

@ijjk
Copy link
Member

ijjk commented Aug 5, 2020 •
edited
Loading

Failing test suites

Commit: fb6db7c

test/integration/jsconfig-baseurl/test/index.test.js

  • TypeScript Features > default behavior > should have correct module not found error
Expand output

● TypeScript Features › default behavior › should have correct module not found error

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  61 |       )
  62 |       await fs.writeFile(basicPage, contents)
> 63 |       expect(found).toBe(true)
     |                     ^
  64 |     })
  65 |   })
  66 | })

  at Object.<anonymous> (integration/jsconfig-baseurl/test/index.test.js:63:21)

test/integration/jsconfig-paths/test/index.test.js

  • TypeScript Features > default behavior > should have correct module not found error
Expand output

● TypeScript Features › default behavior › should have correct module not found error

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  78 |       )
  79 |       await fs.writeFile(basicPage, contents)
> 80 |       expect(found).toBe(true)
     |                     ^
  81 |     })
  82 |   })
  83 | })

  at Object.<anonymous> (integration/jsconfig-paths/test/index.test.js:80:21)

@ijjk
Copy link
Member

ijjk commented Aug 5, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
buildDuration 12.4s 12s -395ms
nodeModulesSize 66 MB 66 MB ⚠️ +6.89 kB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.236 2.193 -0.04
/ avg req/sec 1117.99 1139.95 +21.96
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.257 1.218 -0.04
/error-in-render avg req/sec 1988.97 2051.85 +62.88
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-76d73eb..95d8.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-0b6ca7d..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-e97733c..af21.js gzip 1.3 kB 1.3 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_buildManifest.js gzip 272 B 272 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 552 B 552 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
index.html gzip 945 B 945 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
buildDuration 13.9s 13.6s -283ms
nodeModulesSize 66 MB 66 MB ⚠️ +6.89 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-76d73eb..95d8.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-0b6ca7d..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-e97733c..af21.js gzip 1.3 kB 1.3 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_buildManifest.js gzip 272 B 272 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 552 B 552 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_error.js 1.02 MB 1.02 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.2 MB 5.2 MB ✓
Commit: 8d7402b

@ijjk
Copy link
Member

ijjk commented Aug 5, 2020

Failing test suites

Commit: 8d7402b

test/integration/jsconfig-paths/test/index.test.js

  • TypeScript Features > default behavior > should have correct module not found error
Expand output

● TypeScript Features › default behavior › should have correct module not found error

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  78 |       )
  79 |       await fs.writeFile(basicPage, contents)
> 80 |       expect(found).toBe(true)
     |                     ^
  81 |     })
  82 |   })
  83 | })

  at Object.<anonymous> (integration/jsconfig-paths/test/index.test.js:80:21)

@ijjk
Copy link
Member

ijjk commented Aug 5, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
buildDuration 12.2s 13.1s ⚠️ +977ms
nodeModulesSize 66 MB 66 MB ⚠️ +7.36 kB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.45 2.435 -0.02
/ avg req/sec 1020.25 1026.51 +6.26
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.598 1.549 -0.05
/error-in-render avg req/sec 1564.01 1614.22 +50.21
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-76d73eb..95d8.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-0b6ca7d..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-e97733c..af21.js gzip 1.3 kB 1.3 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_buildManifest.js gzip 272 B 272 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 552 B 552 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
index.html gzip 945 B 945 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
buildDuration 13.9s 13.4s -537ms
nodeModulesSize 66 MB 66 MB ⚠️ +7.36 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-76d73eb..95d8.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-0b6ca7d..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-e97733c..af21.js gzip 1.3 kB 1.3 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_buildManifest.js gzip 272 B 272 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 552 B 552 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_error.js 1.02 MB 1.02 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.2 MB 5.2 MB ✓
Commit: 95434e1

@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Aug 5, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
buildDuration 12.2s 12.5s ⚠️ +274ms
nodeModulesSize 66 MB 66 MB ⚠️ +7.36 kB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.164 2.207 ⚠️ +0.04
/ avg req/sec 1155.44 1132.64 ⚠️ -22.8
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.318 1.17 -0.15
/error-in-render avg req/sec 1897.35 2137.63 +240.28
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-76d73eb..95d8.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-0b6ca7d..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-e97733c..af21.js gzip 1.3 kB 1.3 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_buildManifest.js gzip 272 B 272 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 552 B 552 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
index.html gzip 945 B 945 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
buildDuration 13.7s 13.9s ⚠️ +183ms
nodeModulesSize 66 MB 66 MB ⚠️ +7.36 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-76d73eb..95d8.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-0b6ca7d..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-e97733c..af21.js gzip 1.3 kB 1.3 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_buildManifest.js gzip 272 B 272 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 552 B 552 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_error.js 1.02 MB 1.02 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.2 MB 5.2 MB ✓
Commit: e4128cd

@timneutkens timneutkens changed the title Add test for module not found error Enhance module not found error Aug 5, 2020
Timer
Timer requested changes Aug 5, 2020
View reviewed changes
packages/react-dev-overlay/src/middleware.ts Outdated
})

if (!sourcePosition.source) {
return null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This leaks the consumer, missing:

consumer.destroy()

Maybe we should wrap this in a try { } finally { }?

Timer
Timer approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ijjk
Copy link
Member

ijjk commented Aug 5, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
buildDuration 10.4s 10.6s ⚠️ +226ms
nodeModulesSize 66 MB 66 MB ⚠️ +7.36 kB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.885 1.909 ⚠️ +0.02
/ avg req/sec 1326.55 1309.59 ⚠️ -16.96
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.044 0.993 -0.05
/error-in-render avg req/sec 2394.62 2517.1 +122.48
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..8895.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-735b134..e108.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..dule.js gzip 6.21 kB 6.21 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-e1dadb6..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.9 kB 51.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-f4d2979..e57b.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-653c74f..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 553 B 553 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
index.html gzip 946 B 946 B ✓
link.html gzip 952 B 952 B ✓
withRouter.html gzip 941 B 941 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
buildDuration 11.7s 11.7s ⚠️ +58ms
nodeModulesSize 66 MB 66 MB ⚠️ +7.36 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..8895.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-735b134..e108.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..dule.js gzip 6.21 kB 6.21 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-e1dadb6..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.9 kB 51.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-f4d2979..e57b.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-653c74f..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 553 B 553 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_error.js 1.02 MB 1.02 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.21 MB 5.21 MB ✓
Commit: 34c13f1

@ijjk
Copy link
Member

ijjk commented Aug 5, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
buildDuration 12.2s 12.3s ⚠️ +32ms
nodeModulesSize 66 MB 66 MB ⚠️ +7.36 kB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.196 2.194 0
/ avg req/sec 1138.46 1139.54 +1.08
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.227 1.175 -0.05
/error-in-render avg req/sec 2037.91 2128.4 +90.49
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..8895.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-735b134..e108.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..dule.js gzip 6.21 kB 6.21 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-e1dadb6..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.9 kB 51.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-f4d2979..e57b.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-653c74f..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 553 B 553 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
index.html gzip 946 B 946 B ✓
link.html gzip 952 B 952 B ✓
withRouter.html gzip 941 B 941 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
buildDuration 13.7s 13.5s -220ms
nodeModulesSize 66 MB 66 MB ⚠️ +7.36 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..8895.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-735b134..e108.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
677f882d2ed8..dule.js gzip 6.21 kB 6.21 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-e1dadb6..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.9 kB 51.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-f4d2979..e57b.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-653c74f..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 553 B 553 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/module-not-found-test Change
_error.js 1.02 MB 1.02 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.21 MB 5.21 MB ✓
Commit: 0888cef

@kodiakhq kodiakhq bot merged commit 405e42e into vercel:canary Aug 5, 2020
@timneutkens timneutkens deleted the fix/module-not-found-test branch August 6, 2020 09:32
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad module not found error from webpack
3 participants
@timneutkens @ijjk @Timer