Move next-codemod to Next.js monorepo #15536

timneutkens · 2020-07-27T20:13:29Z

Moves the next-codemod code into the Next.js monorepo. This doesn't cover publishing to npm yet as we still have to write the CLI for it.

# Conflicts: # yarn.lock

ijjk · 2020-08-10T08:25:12Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
buildDuration	12.8s	12.9s	⚠️ +9ms
nodeModulesSize	65.7 MB	65.7 MB	⚠️ +1 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.241	2.272	⚠️ +0.03
/ avg req/sec	1115.76	1100.27	⚠️ -15.49
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.286	1.245	-0.04
/error-in-render avg req/sec	1943.32	2007.75	+64.43

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
677f882d2ed8..ec1a.js gzip	9.99 kB	9.99 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-bbd130c..8538.js gzip	6.74 kB	6.74 kB	✓
webpack-ccf5..276a.js gzip	751 B	751 B	✓
Overall change	56.6 kB	56.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
677f882d2ed8..dule.js gzip	5.89 kB	5.89 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-c06fea5..dule.js gzip	5.81 kB	5.81 kB	✓
webpack-10c7..dule.js gzip	751 B	751 B	✓
Overall change	51.6 kB	51.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
polyfills-75..1629.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
_app-874bd8a..0103.js gzip	1.28 kB	1.28 kB	✓
_error-fa39c..ec40.js gzip	3.45 kB	3.45 kB	✓
hooks-585f07..95a3.js gzip	887 B	887 B	✓
index-c7b63f..fc02.js gzip	227 B	227 B	✓
link-f4d2979..e57b.js gzip	1.29 kB	1.29 kB	✓
routerDirect..ebc7.js gzip	284 B	284 B	✓
withRouter-2..db68.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
_app-97e743e..dule.js gzip	626 B	626 B	✓
_error-b4004..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-696209..dule.js gzip	387 B	387 B	✓
index-a4dd74..dule.js gzip	226 B	226 B	✓
link-653c74f..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-1..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
_buildManifest.js gzip	273 B	273 B	✓
_buildManife..dule.js gzip	280 B	280 B	✓
Overall change	553 B	553 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
index.html gzip	946 B	946 B	✓
link.html gzip	954 B	954 B	✓
withRouter.html gzip	941 B	941 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
buildDuration	14.1s	14.1s	⚠️ +82ms
nodeModulesSize	65.7 MB	65.7 MB	⚠️ +1 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
677f882d2ed8..ec1a.js gzip	9.99 kB	9.99 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-bbd130c..8538.js gzip	6.74 kB	6.74 kB	✓
webpack-ccf5..276a.js gzip	751 B	751 B	✓
Overall change	56.6 kB	56.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
677f882d2ed8..dule.js gzip	5.89 kB	5.89 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-c06fea5..dule.js gzip	5.81 kB	5.81 kB	✓
webpack-10c7..dule.js gzip	751 B	751 B	✓
Overall change	51.6 kB	51.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
polyfills-75..1629.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
_app-874bd8a..0103.js gzip	1.28 kB	1.28 kB	✓
_error-fa39c..ec40.js gzip	3.45 kB	3.45 kB	✓
hooks-585f07..95a3.js gzip	887 B	887 B	✓
index-c7b63f..fc02.js gzip	227 B	227 B	✓
link-f4d2979..e57b.js gzip	1.29 kB	1.29 kB	✓
routerDirect..ebc7.js gzip	284 B	284 B	✓
withRouter-2..db68.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
_app-97e743e..dule.js gzip	626 B	626 B	✓
_error-b4004..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-696209..dule.js gzip	387 B	387 B	✓
index-a4dd74..dule.js gzip	226 B	226 B	✓
link-653c74f..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-1..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
_buildManifest.js gzip	273 B	273 B	✓
_buildManife..dule.js gzip	280 B	280 B	✓
Overall change	553 B	553 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
_error.js	1.03 MB	1.03 MB	⚠️ +349 B
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.03 MB	1.03 MB	⚠️ +349 B
link.js	1.07 MB	1.07 MB	⚠️ +349 B
routerDirect.js	1.06 MB	1.06 MB	⚠️ +349 B
withRouter.js	1.06 MB	1.06 MB	⚠️ +349 B
Overall change	5.26 MB	5.26 MB	⚠️ +1.75 kB

Commit: ec85d6f

ijjk · 2020-08-10T08:47:21Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
buildDuration	12s	12s	⚠️ +22ms
nodeModulesSize	65.7 MB	65.7 MB	⚠️ +1 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.243	2.166	-0.08
/ avg req/sec	1114.57	1154.22	+39.65
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.408	1.399	-0.01
/error-in-render avg req/sec	1775.85	1787.33	+11.48

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
677f882d2ed8..ec1a.js gzip	9.99 kB	9.99 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-bbd130c..8538.js gzip	6.74 kB	6.74 kB	✓
webpack-ccf5..276a.js gzip	751 B	751 B	✓
Overall change	56.6 kB	56.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
677f882d2ed8..dule.js gzip	5.89 kB	5.89 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-c06fea5..dule.js gzip	5.81 kB	5.81 kB	✓
webpack-10c7..dule.js gzip	751 B	751 B	✓
Overall change	51.6 kB	51.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
polyfills-75..1629.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
_app-874bd8a..0103.js gzip	1.28 kB	1.28 kB	✓
_error-fa39c..ec40.js gzip	3.45 kB	3.45 kB	✓
hooks-585f07..95a3.js gzip	887 B	887 B	✓
index-c7b63f..fc02.js gzip	227 B	227 B	✓
link-f4d2979..e57b.js gzip	1.29 kB	1.29 kB	✓
routerDirect..ebc7.js gzip	284 B	284 B	✓
withRouter-2..db68.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
_app-97e743e..dule.js gzip	626 B	626 B	✓
_error-b4004..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-696209..dule.js gzip	387 B	387 B	✓
index-a4dd74..dule.js gzip	226 B	226 B	✓
link-653c74f..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-1..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
_buildManifest.js gzip	273 B	273 B	✓
_buildManife..dule.js gzip	280 B	280 B	✓
Overall change	553 B	553 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
index.html gzip	946 B	946 B	✓
link.html gzip	954 B	954 B	✓
withRouter.html gzip	941 B	941 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
buildDuration	13.3s	13.5s	⚠️ +258ms
nodeModulesSize	65.7 MB	65.7 MB	⚠️ +1 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
677f882d2ed8..ec1a.js gzip	9.99 kB	9.99 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-bbd130c..8538.js gzip	6.74 kB	6.74 kB	✓
webpack-ccf5..276a.js gzip	751 B	751 B	✓
Overall change	56.6 kB	56.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
677f882d2ed8..dule.js gzip	5.89 kB	5.89 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-c06fea5..dule.js gzip	5.81 kB	5.81 kB	✓
webpack-10c7..dule.js gzip	751 B	751 B	✓
Overall change	51.6 kB	51.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
polyfills-75..1629.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
_app-874bd8a..0103.js gzip	1.28 kB	1.28 kB	✓
_error-fa39c..ec40.js gzip	3.45 kB	3.45 kB	✓
hooks-585f07..95a3.js gzip	887 B	887 B	✓
index-c7b63f..fc02.js gzip	227 B	227 B	✓
link-f4d2979..e57b.js gzip	1.29 kB	1.29 kB	✓
routerDirect..ebc7.js gzip	284 B	284 B	✓
withRouter-2..db68.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
_app-97e743e..dule.js gzip	626 B	626 B	✓
_error-b4004..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-696209..dule.js gzip	387 B	387 B	✓
index-a4dd74..dule.js gzip	226 B	226 B	✓
link-653c74f..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-1..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
_buildManifest.js gzip	273 B	273 B	✓
_buildManife..dule.js gzip	280 B	280 B	✓
Overall change	553 B	553 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
_error.js	1.03 MB	1.03 MB	⚠️ +349 B
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.03 MB	1.03 MB	⚠️ +349 B
link.js	1.07 MB	1.07 MB	⚠️ +349 B
routerDirect.js	1.06 MB	1.06 MB	⚠️ +349 B
withRouter.js	1.06 MB	1.06 MB	⚠️ +349 B
Overall change	5.26 MB	5.26 MB	⚠️ +1.75 kB

Commit: 99314e3

ijjk · 2020-08-10T08:58:42Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
buildDuration	11.2s	10.6s	-569ms
nodeModulesSize	65.7 MB	65.7 MB	⚠️ +1 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.849	1.949	⚠️ +0.1
/ avg req/sec	1352.45	1282.85	⚠️ -69.6
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	0.987	1.116	⚠️ +0.13
/error-in-render avg req/sec	2533.07	2240.07	⚠️ -293

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
677f882d2ed8..ec1a.js gzip	9.99 kB	9.99 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-bbd130c..8538.js gzip	6.74 kB	6.74 kB	✓
webpack-ccf5..276a.js gzip	751 B	751 B	✓
Overall change	56.6 kB	56.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
677f882d2ed8..dule.js gzip	5.89 kB	5.89 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-c06fea5..dule.js gzip	5.81 kB	5.81 kB	✓
webpack-10c7..dule.js gzip	751 B	751 B	✓
Overall change	51.6 kB	51.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
polyfills-75..1629.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
_app-874bd8a..0103.js gzip	1.28 kB	1.28 kB	✓
_error-fa39c..ec40.js gzip	3.45 kB	3.45 kB	✓
hooks-585f07..95a3.js gzip	887 B	887 B	✓
index-c7b63f..fc02.js gzip	227 B	227 B	✓
link-f4d2979..e57b.js gzip	1.29 kB	1.29 kB	✓
routerDirect..ebc7.js gzip	284 B	284 B	✓
withRouter-2..db68.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
_app-97e743e..dule.js gzip	626 B	626 B	✓
_error-b4004..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-696209..dule.js gzip	387 B	387 B	✓
index-a4dd74..dule.js gzip	226 B	226 B	✓
link-653c74f..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-1..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
_buildManifest.js gzip	273 B	273 B	✓
_buildManife..dule.js gzip	280 B	280 B	✓
Overall change	553 B	553 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
index.html gzip	946 B	946 B	✓
link.html gzip	954 B	954 B	✓
withRouter.html gzip	941 B	941 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
buildDuration	11.9s	11.8s	-102ms
nodeModulesSize	65.7 MB	65.7 MB	⚠️ +1 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
677f882d2ed8..ec1a.js gzip	9.99 kB	9.99 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-bbd130c..8538.js gzip	6.74 kB	6.74 kB	✓
webpack-ccf5..276a.js gzip	751 B	751 B	✓
Overall change	56.6 kB	56.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
677f882d2ed8..dule.js gzip	5.89 kB	5.89 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-c06fea5..dule.js gzip	5.81 kB	5.81 kB	✓
webpack-10c7..dule.js gzip	751 B	751 B	✓
Overall change	51.6 kB	51.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
polyfills-75..1629.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
_app-874bd8a..0103.js gzip	1.28 kB	1.28 kB	✓
_error-fa39c..ec40.js gzip	3.45 kB	3.45 kB	✓
hooks-585f07..95a3.js gzip	887 B	887 B	✓
index-c7b63f..fc02.js gzip	227 B	227 B	✓
link-f4d2979..e57b.js gzip	1.29 kB	1.29 kB	✓
routerDirect..ebc7.js gzip	284 B	284 B	✓
withRouter-2..db68.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
_app-97e743e..dule.js gzip	626 B	626 B	✓
_error-b4004..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-696209..dule.js gzip	387 B	387 B	✓
index-a4dd74..dule.js gzip	226 B	226 B	✓
link-653c74f..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-1..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
_buildManifest.js gzip	273 B	273 B	✓
_buildManife..dule.js gzip	280 B	280 B	✓
Overall change	553 B	553 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/codemods	Change
_error.js	1.03 MB	1.03 MB	⚠️ +349 B
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.03 MB	1.03 MB	⚠️ +349 B
link.js	1.07 MB	1.07 MB	⚠️ +349 B
routerDirect.js	1.06 MB	1.06 MB	⚠️ +349 B
withRouter.js	1.06 MB	1.06 MB	⚠️ +349 B
Overall change	5.26 MB	5.26 MB	⚠️ +1.75 kB

Commit: b1a890f

Move next-codemod to Next.js monorepo

39fc679

timneutkens requested review from ijjk, lfades and Timer as code owners July 27, 2020 20:13

This comment has been minimized.

Sign in to view

timneutkens added 7 commits August 9, 2020 21:02

Revert jest config change

8e2888f

Make tests work

8be1e9a

Run tests for next-codemod

e29a54a

Merge branch 'canary' of github.com:vercel/next.js into add/codemods

b93a1d8

# Conflicts: # yarn.lock

Update yarn.lock

2241334

Merge branch 'canary' of github.com:vercel/next.js into add/codemods

09235e7

# Conflicts: # yarn.lock

Fix types based on node-html-parser updated version

ec85d6f

ijjk added the type: next label Aug 10, 2020

Add missing ignore for non-ts files

99314e3

Add eslintignore items

b1a890f

timneutkens merged commit 62031ff into vercel:canary Aug 10, 2020

timneutkens deleted the add/codemods branch August 10, 2020 09:14

This was referenced Sep 18, 2021

[Snyk] Security upgrade next from 9.4.1 to 9.5.2 Jcrowell74/next.js#327

Open

[Snyk] Security upgrade next from 9.4.1 to 9.5.2 Mement-Mori/next.js#158

Open

vercel locked as resolved and limited conversation to collaborators Jan 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move next-codemod to Next.js monorepo #15536

Move next-codemod to Next.js monorepo #15536

timneutkens commented Jul 27, 2020 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

ijjk commented Aug 10, 2020

ijjk commented Aug 10, 2020

ijjk commented Aug 10, 2020

Move next-codemod to Next.js monorepo #15536

Move next-codemod to Next.js monorepo #15536

Conversation

timneutkens commented Jul 27, 2020 • edited Loading

This comment has been minimized.

This comment has been minimized.

ijjk commented Aug 10, 2020

Stats from current PR

ijjk commented Aug 10, 2020

Stats from current PR

ijjk commented Aug 10, 2020

Stats from current PR

timneutkens commented Jul 27, 2020 •

edited

Loading