Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webpack to land chokidar patch for all Next.js users #15460

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

timneutkens
Copy link
Member

Forces all Next.js users to have this patch installed: https://twitter.com/timneutkens/status/1282129714627448832

Huge thanks to @paulmillr and @sokra 🙏

@ijjk
Copy link
Member

ijjk commented Jul 24, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/upgrade-webpack-4-44 Change
buildDuration 12s 12.3s ⚠️ +233ms
nodeModulesSize 66.4 MB 66.4 MB ⚠️ +7.98 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/upgrade-webpack-4-44 Change
/ failed reqs 0 0
/ total time (seconds) 2.082 2.105 ⚠️ +0.02
/ avg req/sec 1200.66 1187.75 ⚠️ -12.91
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.313 1.466 ⚠️ +0.15
/error-in-render avg req/sec 1903.85 1704.78 ⚠️ -199.07
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/upgrade-webpack-4-44 Change
677f882d2ed8..d2f7.js gzip 10.1 kB 10.1 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-8da3811..3b61.js gzip 6.72 kB 6.72 kB
polyfills-05..1236.js gzip 30.8 kB 30.8 kB
webpack-488d..c0e7.js gzip 751 B 751 B
Overall change 87.6 kB 87.6 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/upgrade-webpack-4-44 Change
677f882d2ed8..dule.js gzip 6.1 kB 6.1 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-43a8e8b..dule.js gzip 5.79 kB 5.79 kB
polyfills-05..dule.js gzip 30.8 kB 30.8 kB
webpack-4f62..dule.js gzip 751 B 751 B
Overall change 82.6 kB 82.6 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/upgrade-webpack-4-44 Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB
hooks-f7f3d0..7465.js gzip 887 B 887 B
index-08fb3f..c0e9.js gzip 227 B 227 B
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB
routerDirect..8aa1.js gzip 284 B 284 B
withRouter-f..e777.js gzip 284 B 284 B
Overall change 7.66 kB 7.66 kB
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/upgrade-webpack-4-44 Change
_app-669dbe5..dule.js gzip 626 B 626 B
_error-663e6..dule.js gzip 2.24 kB 2.24 kB
hooks-805c40..dule.js gzip 387 B 387 B
index-6ba5a4..dule.js gzip 226 B 226 B
link-69bc264..dule.js gzip 1.25 kB 1.25 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-d..dule.js gzip 282 B 282 B
Overall change 5.29 kB 5.29 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/upgrade-webpack-4-44 Change
_buildManifest.js gzip 275 B 275 B
_buildManife..dule.js gzip 281 B 281 B
Overall change 556 B 556 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/upgrade-webpack-4-44 Change
index.html gzip 946 B 946 B
link.html gzip 952 B 952 B
withRouter.html gzip 938 B 938 B
Overall change 2.84 kB 2.84 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/upgrade-webpack-4-44 Change
buildDuration 12.9s 13.7s ⚠️ +851ms
nodeModulesSize 66.4 MB 66.4 MB ⚠️ +7.98 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/upgrade-webpack-4-44 Change
677f882d2ed8..d2f7.js gzip 10.1 kB 10.1 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-8da3811..3b61.js gzip 6.72 kB 6.72 kB
polyfills-05..1236.js gzip 30.8 kB 30.8 kB
webpack-488d..c0e7.js gzip 751 B 751 B
Overall change 87.6 kB 87.6 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/upgrade-webpack-4-44 Change
677f882d2ed8..dule.js gzip 6.1 kB 6.1 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-43a8e8b..dule.js gzip 5.79 kB 5.79 kB
polyfills-05..dule.js gzip 30.8 kB 30.8 kB
webpack-4f62..dule.js gzip 751 B 751 B
Overall change 82.6 kB 82.6 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/upgrade-webpack-4-44 Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB
hooks-f7f3d0..7465.js gzip 887 B 887 B
index-08fb3f..c0e9.js gzip 227 B 227 B
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB
routerDirect..8aa1.js gzip 284 B 284 B
withRouter-f..e777.js gzip 284 B 284 B
Overall change 7.66 kB 7.66 kB
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/upgrade-webpack-4-44 Change
_app-669dbe5..dule.js gzip 626 B 626 B
_error-663e6..dule.js gzip 2.24 kB 2.24 kB
hooks-805c40..dule.js gzip 387 B 387 B
index-6ba5a4..dule.js gzip 226 B 226 B
link-69bc264..dule.js gzip 1.25 kB 1.25 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-d..dule.js gzip 282 B 282 B
Overall change 5.29 kB 5.29 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/upgrade-webpack-4-44 Change
_buildManifest.js gzip 275 B 275 B
_buildManife..dule.js gzip 281 B 281 B
Overall change 556 B 556 B
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/upgrade-webpack-4-44 Change
_error.js 881 kB 881 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.82 kB 3.82 kB
index.js 881 kB 881 kB
link.js 922 kB 922 kB
routerDirect.js 916 kB 916 kB
withRouter.js 916 kB 916 kB
Overall change 4.52 MB 4.52 MB
Commit: 1104cdc

@kodiakhq kodiakhq bot merged commit c5f29b7 into vercel:canary Jul 24, 2020
@timneutkens timneutkens deleted the fix/upgrade-webpack-4-44 branch July 24, 2020 19:57
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants