Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added production, basic, and Fast Refresh test suites on macOS #15366

Merged
merged 4 commits into from
Jul 21, 2020
Merged

Added production, basic, and Fast Refresh test suites on macOS #15366

merged 4 commits into from
Jul 21, 2020

Conversation

darshkpatel
Copy link
Contributor

@darshkpatel darshkpatel commented Jul 21, 2020 •
edited
Loading

Added GitHub action to run Basic, Production, and Acceptance test suites.
Let me know if I should add matrix tests for Ubuntu, macOS, and windows for all the tests albeit increasing the runtime a lot

Edit: Screenshot
Screenshot 2020-07-21 at 5 02 13 PM

Resolves: #15301

@ijjk
Copy link
Member

ijjk commented Jul 21, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
buildDuration 12.3s 11.5s -856ms
nodeModulesSize 66.4 MB 66.4 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.93 1.883 -0.05
/ avg req/sec 1295.59 1327.56 +31.97
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.168 1.15 -0.02
/error-in-render avg req/sec 2140.83 2174.65 +33.82
Client Bundles (main, webpack, commons)
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
677f882d2ed8..7a20.js gzip 9.85 kB 9.85 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-d8a3f1c..06ea.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.3 kB 87.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-e63c4e5..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
index.html gzip 946 B 946 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 938 B 938 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
buildDuration 13.2s 13.3s ⚠️ +98ms
nodeModulesSize 66.4 MB 66.4 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
677f882d2ed8..7a20.js gzip 9.85 kB 9.85 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-d8a3f1c..06ea.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.3 kB 87.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-e63c4e5..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
_error.js 881 kB 881 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 881 kB 881 kB ✓
link.js 923 kB 923 kB ✓
routerDirect.js 917 kB 917 kB ✓
withRouter.js 917 kB 917 kB ✓
Overall change 4.53 MB 4.53 MB ✓
Commit: 12b2308

@ijjk
Copy link
Member

ijjk commented Jul 21, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
buildDuration 13.9s 13.7s -231ms
nodeModulesSize 66.4 MB 66.4 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.36 2.372 ⚠️ +0.01
/ avg req/sec 1059.38 1053.94 ⚠️ -5.44
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.543 1.606 ⚠️ +0.06
/error-in-render avg req/sec 1620.14 1556.24 ⚠️ -63.9
Client Bundles (main, webpack, commons)
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
677f882d2ed8..7a20.js gzip 9.85 kB 9.85 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-d8a3f1c..06ea.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.3 kB 87.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-e63c4e5..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
index.html gzip 946 B 946 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 938 B 938 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
buildDuration 14.9s 15.1s ⚠️ +204ms
nodeModulesSize 66.4 MB 66.4 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
677f882d2ed8..7a20.js gzip 9.85 kB 9.85 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-d8a3f1c..06ea.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.3 kB 87.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-e63c4e5..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
_error.js 881 kB 881 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 881 kB 881 kB ✓
link.js 923 kB 923 kB ✓
routerDirect.js 917 kB 917 kB ✓
withRouter.js 917 kB 917 kB ✓
Overall change 4.53 MB 4.53 MB ✓
Commit: 558a494

@ijjk
Copy link
Member

ijjk commented Jul 21, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
buildDuration 12s 11.3s -718ms
nodeModulesSize 66.4 MB 66.4 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.919 2.011 ⚠️ +0.09
/ avg req/sec 1302.66 1243.18 ⚠️ -59.48
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.329 1.414 ⚠️ +0.08
/error-in-render avg req/sec 1881.32 1767.59 ⚠️ -113.73
Client Bundles (main, webpack, commons)
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
677f882d2ed8..7a20.js gzip 9.85 kB 9.85 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-d8a3f1c..06ea.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.3 kB 87.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-e63c4e5..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
index.html gzip 946 B 946 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 938 B 938 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
buildDuration 12.4s 12.6s ⚠️ +205ms
nodeModulesSize 66.4 MB 66.4 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
677f882d2ed8..7a20.js gzip 9.85 kB 9.85 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-d8a3f1c..06ea.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.3 kB 87.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-e63c4e5..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
_error.js 881 kB 881 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 881 kB 881 kB ✓
link.js 923 kB 923 kB ✓
routerDirect.js 917 kB 917 kB ✓
withRouter.js 917 kB 917 kB ✓
Overall change 4.53 MB 4.53 MB ✓
Commit: 08d3eae

@ijjk
Copy link
Member

ijjk commented Jul 21, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
buildDuration 14.8s 14.9s ⚠️ +119ms
nodeModulesSize 66.4 MB 66.4 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.456 2.402 -0.05
/ avg req/sec 1017.73 1040.66 +22.93
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.72 1.668 -0.05
/error-in-render avg req/sec 1453.37 1498.65 +45.28
Client Bundles (main, webpack, commons)
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
677f882d2ed8..7a20.js gzip 9.85 kB 9.85 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-d8a3f1c..06ea.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.3 kB 87.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-e63c4e5..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
index.html gzip 946 B 946 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 938 B 938 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
buildDuration 14.9s 15.5s ⚠️ +590ms
nodeModulesSize 66.4 MB 66.4 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
677f882d2ed8..7a20.js gzip 9.85 kB 9.85 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-d8a3f1c..06ea.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.3 kB 87.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-e63c4e5..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary MLH-Fellowship/next.js darsh/15301 Change
_error.js 881 kB 881 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 881 kB 881 kB ✓
link.js 923 kB 923 kB ✓
routerDirect.js 917 kB 917 kB ✓
withRouter.js 917 kB 917 kB ✓
Overall change 4.53 MB 4.53 MB ✓
Commit: 6c4e898

timneutkens
timneutkens reviewed Jul 21, 2020
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Will merge this once a stable release is out given that this could break when merged

@Timer
Copy link
Member

Timer commented Jul 21, 2020

Landing since they passed on this PR, thank you!
image

@Timer Timer merged commit 7a266a9 into vercel:canary Jul 21, 2020
@timneutkens timneutkens deleted the darsh/15301 branch July 21, 2020 20:04
@styfle styfle mentioned this pull request Aug 5, 2020
Merged
kodiakhq bot pushed a commit that referenced this pull request Aug 5, 2020
@styfle
Test macOS on canary (#15899)
afc225c 
Only run macOS tests on canary to avoid queued jobs due to [concurrency limit](https://docs.github.com/en/actions/getting-started-with-github-actions/about-github-actions#usage-limits).

Follow up to #15366
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens left review comments

@Timer Timer Timer approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run production, basic, and Fast Refresh test suite on macOS
4 participants
@darshkpatel @ijjk @Timer @timneutkens