Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct order of packages in Sentry example explanation #15334

Merged
merged 3 commits into from
Jul 20, 2020
Merged

Correct order of packages in Sentry example explanation #15334

merged 3 commits into from
Jul 20, 2020

Conversation

obedparla
Copy link
Contributor

The explanation in next config had the pacckage names inverted

@obedparla
correct order of packages in the explanation
c9dd3d6 
The explanation in next config had the pacckage names inverted
@ijjk ijjk added the examples Issue was opened via the examples template. label Jul 20, 2020
Timer
Timer approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk
Copy link
Member

ijjk commented Jul 20, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary obedparla/next.js patch-2 Change
buildDuration 12.7s 13.1s ⚠️ +378ms
nodeModulesSize 66.4 MB 66.4 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary obedparla/next.js patch-2 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.174 2.124 -0.05
/ avg req/sec 1149.79 1177.14 +27.35
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.412 1.468 ⚠️ +0.06
/error-in-render avg req/sec 1770.76 1702.67 ⚠️ -68.09
Client Bundles (main, webpack, commons)
vercel/next.js canary obedparla/next.js patch-2 Change
677f882d2ed8..db49.js gzip 9.7 kB 9.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-f4b1fe1..074d.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.1 kB 87.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary obedparla/next.js patch-2 Change
677f882d2ed8..dule.js gzip 6.1 kB 6.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-6a87989..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary obedparla/next.js patch-2 Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary obedparla/next.js patch-2 Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary obedparla/next.js patch-2 Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary obedparla/next.js patch-2 Change
index.html gzip 947 B 947 B ✓
link.html gzip 954 B 954 B ✓
withRouter.html gzip 940 B 940 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary obedparla/next.js patch-2 Change
buildDuration 14.3s 14s -337ms
nodeModulesSize 66.4 MB 66.4 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary obedparla/next.js patch-2 Change
677f882d2ed8..db49.js gzip 9.7 kB 9.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-f4b1fe1..074d.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.1 kB 87.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary obedparla/next.js patch-2 Change
677f882d2ed8..dule.js gzip 6.1 kB 6.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-6a87989..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary obedparla/next.js patch-2 Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary obedparla/next.js patch-2 Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary obedparla/next.js patch-2 Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary obedparla/next.js patch-2 Change
_error.js 881 kB 881 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 882 kB 882 kB ✓
link.js 923 kB 923 kB ✓
routerDirect.js 917 kB 917 kB ✓
withRouter.js 917 kB 917 kB ✓
Overall change 4.53 MB 4.53 MB ✓
Commit: c9dd3d6

@ijjk
Copy link
Member

ijjk commented Jul 20, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary obedparla/next.js patch-2 Change
buildDuration 13.1s 13.3s ⚠️ +285ms
nodeModulesSize 66.4 MB 66.4 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary obedparla/next.js patch-2 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.209 2.158 -0.05
/ avg req/sec 1131.96 1158.36 +26.4
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.501 1.413 -0.09
/error-in-render avg req/sec 1666.09 1768.74 +102.65
Client Bundles (main, webpack, commons)
vercel/next.js canary obedparla/next.js patch-2 Change
677f882d2ed8..db49.js gzip 9.7 kB 9.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-f4b1fe1..074d.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.1 kB 87.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary obedparla/next.js patch-2 Change
677f882d2ed8..dule.js gzip 6.1 kB 6.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-6a87989..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary obedparla/next.js patch-2 Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary obedparla/next.js patch-2 Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary obedparla/next.js patch-2 Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary obedparla/next.js patch-2 Change
index.html gzip 947 B 947 B ✓
link.html gzip 954 B 954 B ✓
withRouter.html gzip 940 B 940 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary obedparla/next.js patch-2 Change
buildDuration 14.5s 14.4s -63ms
nodeModulesSize 66.4 MB 66.4 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary obedparla/next.js patch-2 Change
677f882d2ed8..db49.js gzip 9.7 kB 9.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-f4b1fe1..074d.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.1 kB 87.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary obedparla/next.js patch-2 Change
677f882d2ed8..dule.js gzip 6.1 kB 6.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-6a87989..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary obedparla/next.js patch-2 Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary obedparla/next.js patch-2 Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary obedparla/next.js patch-2 Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary obedparla/next.js patch-2 Change
_error.js 881 kB 881 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 882 kB 882 kB ✓
link.js 923 kB 923 kB ✓
routerDirect.js 917 kB 917 kB ✓
withRouter.js 917 kB 917 kB ✓
Overall change 4.53 MB 4.53 MB ✓
Commit: ef66a4c

@Timer Timer changed the title correct order of packages in the explanation Correct order of packages in Sentry example explanation Jul 20, 2020
@Timer Timer merged commit 5a00d62 into vercel:canary Jul 20, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@obedparla @ijjk @Timer