Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Examples] Remove with-universal-configuration-runtime #15268

Merged
merged 3 commits into from
Jul 17, 2020
Merged

[Examples] Remove with-universal-configuration-runtime #15268

merged 3 commits into from
Jul 17, 2020

Conversation

lfades
Copy link
Member

@lfades lfades commented Jul 17, 2020

We no longer recommend this kind of config since the release of support for Environment Variables

@ijjk ijjk added the examples Issue was opened via the examples template. label Jul 17, 2020
@ijjk
Copy link
Member

ijjk commented Jul 17, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
buildDuration 13.5s 13.7s ⚠️ +173ms
nodeModulesSize 66.5 MB 66.5 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.115 2.133 ⚠️ +0.02
/ avg req/sec 1182.31 1171.92 ⚠️ -10.39
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.35 1.344 -0.01
/error-in-render avg req/sec 1852.25 1860.69 +8.44
Client Bundles (main, webpack, commons)
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
677f882d2ed8..e4c5.js gzip 9.72 kB 9.72 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-b036624..8f8e.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.2 kB 87.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-0054fa6..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
index.html gzip 947 B 947 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 940 B 940 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
buildDuration 14.3s 14.2s -64ms
nodeModulesSize 66.5 MB 66.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
677f882d2ed8..e4c5.js gzip 9.72 kB 9.72 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-b036624..8f8e.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.2 kB 87.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-0054fa6..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
_error.js 881 kB 881 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 882 kB 882 kB ✓
link.js 923 kB 923 kB ✓
routerDirect.js 917 kB 917 kB ✓
withRouter.js 917 kB 917 kB ✓
Overall change 4.53 MB 4.53 MB ✓
Commit: 60ffa5a

@ijjk
Copy link
Member

ijjk commented Jul 17, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
buildDuration 14.2s 14.6s ⚠️ +379ms
nodeModulesSize 66.5 MB 66.5 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.376 2.382 ⚠️ +0.01
/ avg req/sec 1052.21 1049.6 ⚠️ -2.61
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.572 1.591 ⚠️ +0.02
/error-in-render avg req/sec 1589.84 1571.74 ⚠️ -18.1
Client Bundles (main, webpack, commons)
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
677f882d2ed8..e4c5.js gzip 9.72 kB 9.72 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-b036624..8f8e.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.2 kB 87.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-0054fa6..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
index.html gzip 947 B 947 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 940 B 940 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
buildDuration 15.4s 15.8s ⚠️ +345ms
nodeModulesSize 66.5 MB 66.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
677f882d2ed8..e4c5.js gzip 9.72 kB 9.72 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-b036624..8f8e.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.2 kB 87.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-0054fa6..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
_error.js 881 kB 881 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 882 kB 882 kB ✓
link.js 923 kB 923 kB ✓
routerDirect.js 917 kB 917 kB ✓
withRouter.js 917 kB 917 kB ✓
Overall change 4.53 MB 4.53 MB ✓
Commit: 1625710

@ijjk
Copy link
Member

ijjk commented Jul 17, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
buildDuration 14.1s 14.1s -2ms
nodeModulesSize 66.5 MB 66.5 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.333 2.32 -0.01
/ avg req/sec 1071.78 1077.71 +5.93
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.569 1.613 ⚠️ +0.04
/error-in-render avg req/sec 1592.95 1550.36 ⚠️ -42.59
Client Bundles (main, webpack, commons)
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
677f882d2ed8..e4c5.js gzip 9.72 kB 9.72 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-b036624..8f8e.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.2 kB 87.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-0054fa6..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
index.html gzip 947 B 947 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 940 B 940 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
buildDuration 15s 14.8s -232ms
nodeModulesSize 66.5 MB 66.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
677f882d2ed8..e4c5.js gzip 9.72 kB 9.72 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-b036624..8f8e.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.2 kB 87.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-0054fa6..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary lfades/next.js examples/remove-with-universal-configuration-runtime Change
_error.js 881 kB 881 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 882 kB 882 kB ✓
link.js 923 kB 923 kB ✓
routerDirect.js 917 kB 917 kB ✓
withRouter.js 917 kB 917 kB ✓
Overall change 4.53 MB 4.53 MB ✓
Commit: 03caa26

@Timer Timer merged commit a866937 into vercel:canary Jul 17, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lfades @ijjk @Timer