Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ky-universal-polyfill in webpack 5 #15227

Merged
merged 3 commits into from
Jul 16, 2020

Conversation

timneutkens
Copy link
Member

Solves the failing ky-universal suite mentioned here: #15185 (comment)

Solves the failing `ky-universal` suite mentioned here: vercel#15185 (comment)
@Timer
Copy link
Member

Timer commented Jul 16, 2020

@ijjk
Copy link
Member

ijjk commented Jul 16, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary timneutkens/next.js fix/ky-universal-polyfill Change
buildDuration 14s 14.1s ⚠️ +98ms
nodeModulesSize 66.5 MB 66.5 MB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/ky-universal-polyfill Change
/ failed reqs 0 0
/ total time (seconds) 2.592 2.444 -0.15
/ avg req/sec 964.64 1022.89 +58.25
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.944 1.582 -0.36
/error-in-render avg req/sec 1286.29 1580.29 +294
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/ky-universal-polyfill Change
main-HASH.js gzip 6.72 kB 6.72 kB
webpack-HASH.js gzip 751 B 751 B
19b7e98f51cc..e4c5.js gzip 9.72 kB 9.72 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 56.3 kB 56.3 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/ky-universal-polyfill Change
main-HASH.module.js gzip 5.8 kB 5.8 kB
webpack-HASH..dule.js gzip 751 B 751 B
19b7e98f51cc..dule.js gzip 6.12 kB 6.12 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/ky-universal-polyfill Change
polyfills-HASH.js gzip 30.8 kB 30.8 kB
Overall change 30.8 kB 30.8 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/ky-universal-polyfill Change
_buildManifest.js gzip 267 B 267 B
_buildManife..dule.js gzip 273 B 273 B
Overall change 540 B 540 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/ky-universal-polyfill Change
index.html gzip 954 B 954 B
link.html gzip 961 B 961 B
withRouter.html gzip 947 B 947 B
Overall change 2.86 kB 2.86 kB

Serverless Mode
General
vercel/next.js canary timneutkens/next.js fix/ky-universal-polyfill Change
buildDuration 15s 17s ⚠️ +2s
nodeModulesSize 66.5 MB 66.5 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/ky-universal-polyfill Change
main-HASH.js gzip 6.72 kB 6.72 kB
webpack-HASH.js gzip 751 B 751 B
19b7e98f51cc..e4c5.js gzip 9.72 kB 9.72 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 56.3 kB 56.3 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/ky-universal-polyfill Change
main-HASH.module.js gzip 5.8 kB 5.8 kB
webpack-HASH..dule.js gzip 751 B 751 B
19b7e98f51cc..dule.js gzip 6.12 kB 6.12 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/ky-universal-polyfill Change
polyfills-HASH.js gzip 30.8 kB 30.8 kB
Overall change 30.8 kB 30.8 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/ky-universal-polyfill Change
_buildManifest.js gzip 267 B 267 B
_buildManife..dule.js gzip 273 B 273 B
Overall change 540 B 540 B
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/ky-universal-polyfill Change
_error.js 882 kB 882 kB
404.html 4.17 kB 4.17 kB
hooks.html 3.79 kB 3.79 kB
index.js 882 kB 882 kB
link.js 923 kB 923 kB
routerDirect.js 917 kB 917 kB
withRouter.js 917 kB 917 kB
Overall change 4.53 MB 4.53 MB
Commit: ac62c20

@timneutkens timneutkens merged commit bd9fc12 into vercel:canary Jul 16, 2020
@timneutkens timneutkens deleted the fix/ky-universal-polyfill branch July 16, 2020 22:29
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants