Fix with-expo-typescript install command (2) #15198

arvigeus · 2020-07-15T18:59:26Z

Continuation of #15177

lfades

Thank you! ❤️

ijjk · 2020-07-15T19:07:39Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	arvigeus/next.js patch-1	Change
buildDuration	11.3s	11.7s	⚠️ +383ms
nodeModulesSize	66.5 MB	66.5 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	arvigeus/next.js patch-1	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.92	1.866	-0.05
/ avg req/sec	1301.87	1340.09	+38.22
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.241	1.161	-0.08
/error-in-render avg req/sec	2015.09	2152.74	+137.65

Client Bundles (main, webpack, commons)

	vercel/next.js canary	arvigeus/next.js patch-1	Change
main-HASH.js gzip	6.72 kB	6.72 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..cead.js gzip	9.77 kB	9.77 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.4 kB	56.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	arvigeus/next.js patch-1	Change
main-HASH.module.js gzip	5.8 kB	5.8 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	6.17 kB	6.17 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.9 kB	51.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	arvigeus/next.js patch-1	Change
polyfills-HASH.js gzip	26.4 kB	26.4 kB	✓
Overall change	26.4 kB	26.4 kB	✓

Client Build Manifests

	vercel/next.js canary	arvigeus/next.js patch-1	Change
_buildManifest.js gzip	267 B	267 B	✓
_buildManife..dule.js gzip	273 B	273 B	✓
Overall change	540 B	540 B	✓

Rendered Page Sizes

	vercel/next.js canary	arvigeus/next.js patch-1	Change
index.html gzip	954 B	954 B	✓
link.html gzip	962 B	962 B	✓
withRouter.html gzip	948 B	948 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode

General

	vercel/next.js canary	arvigeus/next.js patch-1	Change
buildDuration	12.6s	11.8s	-801ms
nodeModulesSize	66.5 MB	66.5 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	arvigeus/next.js patch-1	Change
main-HASH.js gzip	6.72 kB	6.72 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..cead.js gzip	9.77 kB	9.77 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.4 kB	56.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	arvigeus/next.js patch-1	Change
main-HASH.module.js gzip	5.8 kB	5.8 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	6.17 kB	6.17 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.9 kB	51.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	arvigeus/next.js patch-1	Change
polyfills-HASH.js gzip	26.4 kB	26.4 kB	✓
Overall change	26.4 kB	26.4 kB	✓

Client Build Manifests

	vercel/next.js canary	arvigeus/next.js patch-1	Change
_buildManifest.js gzip	267 B	267 B	✓
_buildManife..dule.js gzip	273 B	273 B	✓
Overall change	540 B	540 B	✓

Serverless bundles

	vercel/next.js canary	arvigeus/next.js patch-1	Change
_error.js	882 kB	882 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	882 kB	882 kB	✓
link.js	924 kB	924 kB	✓
routerDirect.js	918 kB	918 kB	✓
withRouter.js	918 kB	918 kB	✓
Overall change	4.53 MB	4.53 MB	✓

Commit: b4febaf

ijjk · 2020-07-15T19:07:46Z

Failing test suites

Commit: b4febaf

test/integration/create-next-app/index.test.js

create next app > valid example
create next app > should allow example with GitHub URL
create next app > should allow example with GitHub URL and example-path
create next app > should use --example-path over the file path in the GitHub URL

Expand output

● create next app › valid example

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js valid-example --example basic-css

  90 |     await usingTempDir(async (cwd) => {
  91 |       const projectName = 'valid-example'
> 92 |       const res = await run(cwd, projectName, '--example', 'basic-css')
     |                   ^
  93 |       expect(res.exitCode).toBe(0)
  94 | 
  95 |       expect(

  at makeError (../node_modules/execa/lib/error.js:58:11)
  at handlePromise (../node_modules/execa/index.js:112:26)
  at integration/create-next-app/index.test.js:92:19
  at usingTempDir (integration/create-next-app/index.test.js:30:12)
  at Object.<anonymous> (integration/create-next-app/index.test.js:90:5)

● create next app › should allow example with GitHub URL

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js github-app --example https://github.com/zeit/next-learn-demo/tree/master/1-navigate-between-pages

  109 |     await usingTempDir(async (cwd) => {
  110 |       const projectName = 'github-app'
> 111 |       const res = await run(
      |                   ^
  112 |         cwd,
  113 |         projectName,
  114 |         '--example',

  at makeError (../node_modules/execa/lib/error.js:58:11)
  at handlePromise (../node_modules/execa/index.js:112:26)
  at integration/create-next-app/index.test.js:111:19
  at usingTempDir (integration/create-next-app/index.test.js:30:12)
  at Object.<anonymous> (integration/create-next-app/index.test.js:109:5)

● create next app › should allow example with GitHub URL and example-path

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js github-example-path --example https://github.com/zeit/next-learn-demo/tree/master --example-path 1-navigate-between-pages

  135 |     await usingTempDir(async (cwd) => {
  136 |       const projectName = 'github-example-path'
> 137 |       const res = await run(
      |                   ^
  138 |         cwd,
  139 |         projectName,
  140 |         '--example',

  at makeError (../node_modules/execa/lib/error.js:58:11)
  at handlePromise (../node_modules/execa/index.js:112:26)
  at integration/create-next-app/index.test.js:137:19
  at usingTempDir (integration/create-next-app/index.test.js:30:12)
  at Object.<anonymous> (integration/create-next-app/index.test.js:135:5)

● create next app › should use --example-path over the file path in the GitHub URL

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js github-example-path-2 --example https://github.com/zeit/next-learn-demo/tree/master/1-navigate-between-pages --example-path 1-navigate-between-pages

  163 |     await usingTempDir(async (cwd) => {
  164 |       const projectName = 'github-example-path-2'
> 165 |       const res = await run(
      |                   ^
  166 |         cwd,
  167 |         projectName,
  168 |         '--example',

  at makeError (../node_modules/execa/lib/error.js:58:11)
  at handlePromise (../node_modules/execa/index.js:112:26)
  at integration/create-next-app/index.test.js:165:19
  at usingTempDir (integration/create-next-app/index.test.js:30:12)
  at Object.<anonymous> (integration/create-next-app/index.test.js:163:5)

Update README.md

b4febaf

Continuation of #15177

arvigeus requested review from chibicode, ijjk, lfades, Timer and timneutkens as code owners July 15, 2020 18:59

ijjk added the examples Issue was opened via the examples template. label Jul 15, 2020

lfades approved these changes Jul 15, 2020

View reviewed changes

lfades merged commit 58aa576 into vercel:canary Jul 15, 2020

arvigeus deleted the patch-1 branch July 16, 2020 02:09

vercel locked as resolved and limited conversation to collaborators Jan 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix with-expo-typescript install command (2) #15198

Fix with-expo-typescript install command (2) #15198

arvigeus commented Jul 15, 2020

lfades left a comment

ijjk commented Jul 15, 2020

ijjk commented Jul 15, 2020

Fix with-expo-typescript install command (2) #15198

Fix with-expo-typescript install command (2) #15198

Conversation

arvigeus commented Jul 15, 2020

lfades left a comment

Choose a reason for hiding this comment

ijjk commented Jul 15, 2020

Stats from current PR

ijjk commented Jul 15, 2020

Failing test suites