-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update examples/with-apollo #15178
Update examples/with-apollo #15178
Conversation
apollo-client 2.6.8 -> 3.0.0
Stats from current PRDefault Server Mode (Decrease detected ✓)General
Page Load Tests Overall decrease
|
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.065 | 2.098 | |
/ avg req/sec | 1210.69 | 1191.85 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.275 | 1.275 | ✓ |
/error-in-render avg req/sec | 1960.64 | 1961.18 | +0.54 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
main-HASH.js gzip | 6.72 kB | 6.72 kB | ✓ |
webpack-HASH.js gzip | 751 B | 751 B | ✓ |
19b7e98f51cc..cead.js gzip | 9.77 kB | 9.77 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 56.4 kB | 56.4 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.8 kB | 5.8 kB | ✓ |
webpack-HASH..dule.js gzip | 751 B | 751 B | ✓ |
19b7e98f51cc..dule.js gzip | 6.17 kB | 6.17 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 51.9 kB | 51.9 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.4 kB | 26.4 kB | ✓ |
Overall change | 26.4 kB | 26.4 kB | ✓ |
Client Build Manifests
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
_buildManifest.js gzip | 267 B | 267 B | ✓ |
_buildManife..dule.js gzip | 273 B | 273 B | ✓ |
Overall change | 540 B | 540 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
index.html gzip | 954 B | 954 B | ✓ |
link.html gzip | 960 B | 960 B | ✓ |
withRouter.html gzip | 947 B | 947 B | ✓ |
Overall change | 2.86 kB | 2.86 kB | ✓ |
Serverless Mode
General
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
buildDuration | 13.6s | 13.8s | |
nodeModulesSize | 66.5 MB | 66.5 MB | ✓ |
Client Bundles (main, webpack, commons)
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
main-HASH.js gzip | 6.72 kB | 6.72 kB | ✓ |
webpack-HASH.js gzip | 751 B | 751 B | ✓ |
19b7e98f51cc..cead.js gzip | 9.77 kB | 9.77 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 56.4 kB | 56.4 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.8 kB | 5.8 kB | ✓ |
webpack-HASH..dule.js gzip | 751 B | 751 B | ✓ |
19b7e98f51cc..dule.js gzip | 6.17 kB | 6.17 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 51.9 kB | 51.9 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.4 kB | 26.4 kB | ✓ |
Overall change | 26.4 kB | 26.4 kB | ✓ |
Client Build Manifests
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
_buildManifest.js gzip | 267 B | 267 B | ✓ |
_buildManife..dule.js gzip | 273 B | 273 B | ✓ |
Overall change | 540 B | 540 B | ✓ |
Serverless bundles
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
_error.js | 882 kB | 882 kB | ✓ |
404.html | 4.17 kB | 4.17 kB | ✓ |
hooks.html | 3.79 kB | 3.79 kB | ✓ |
index.js | 882 kB | 882 kB | ✓ |
link.js | 924 kB | 924 kB | ✓ |
routerDirect.js | 918 kB | 918 kB | ✓ |
withRouter.js | 918 kB | 918 kB | ✓ |
Overall change | 4.53 MB | 4.53 MB | ✓ |
apollo-client 2.6.4 -> 3.0.0
Also updated with-apollo-and-redux |
Stats from current PRDefault Server Mode (Decrease detected ✓)General
Page Load Tests Overall decrease
|
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 1.689 | 1.755 | |
/ avg req/sec | 1479.83 | 1424.13 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.058 | 1.051 | -0.01 |
/error-in-render avg req/sec | 2363.42 | 2378.46 | +15.04 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
main-HASH.js gzip | 6.72 kB | 6.72 kB | ✓ |
webpack-HASH.js gzip | 751 B | 751 B | ✓ |
19b7e98f51cc..cead.js gzip | 9.77 kB | 9.77 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 56.4 kB | 56.4 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.8 kB | 5.8 kB | ✓ |
webpack-HASH..dule.js gzip | 751 B | 751 B | ✓ |
19b7e98f51cc..dule.js gzip | 6.17 kB | 6.17 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 51.9 kB | 51.9 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.4 kB | 26.4 kB | ✓ |
Overall change | 26.4 kB | 26.4 kB | ✓ |
Client Build Manifests
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
_buildManifest.js gzip | 267 B | 267 B | ✓ |
_buildManife..dule.js gzip | 273 B | 273 B | ✓ |
Overall change | 540 B | 540 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
index.html gzip | 954 B | 954 B | ✓ |
link.html gzip | 960 B | 960 B | ✓ |
withRouter.html gzip | 947 B | 947 B | ✓ |
Overall change | 2.86 kB | 2.86 kB | ✓ |
Serverless Mode
General
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
buildDuration | 11.6s | 11.7s | |
nodeModulesSize | 66.5 MB | 66.5 MB | ✓ |
Client Bundles (main, webpack, commons)
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
main-HASH.js gzip | 6.72 kB | 6.72 kB | ✓ |
webpack-HASH.js gzip | 751 B | 751 B | ✓ |
19b7e98f51cc..cead.js gzip | 9.77 kB | 9.77 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 56.4 kB | 56.4 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.8 kB | 5.8 kB | ✓ |
webpack-HASH..dule.js gzip | 751 B | 751 B | ✓ |
19b7e98f51cc..dule.js gzip | 6.17 kB | 6.17 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 51.9 kB | 51.9 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.4 kB | 26.4 kB | ✓ |
Overall change | 26.4 kB | 26.4 kB | ✓ |
Client Build Manifests
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
_buildManifest.js gzip | 267 B | 267 B | ✓ |
_buildManife..dule.js gzip | 273 B | 273 B | ✓ |
Overall change | 540 B | 540 B | ✓ |
Serverless bundles
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
_error.js | 882 kB | 882 kB | ✓ |
404.html | 4.17 kB | 4.17 kB | ✓ |
hooks.html | 3.79 kB | 3.79 kB | ✓ |
index.js | 882 kB | 882 kB | ✓ |
link.js | 924 kB | 924 kB | ✓ |
routerDirect.js | 918 kB | 918 kB | ✓ |
withRouter.js | 918 kB | 918 kB | ✓ |
Overall change | 4.53 MB | 4.53 MB | ✓ |
As per the migration guide I think you could also remove Just a guess, but same for |
I could, but Tried to import |
Stats from current PRDefault Server Mode (Decrease detected ✓)General
Page Load Tests Overall decrease
|
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.408 | 2.332 | -0.08 |
/ avg req/sec | 1038.42 | 1072.01 | +33.59 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.563 | 1.643 | |
/error-in-render avg req/sec | 1599.06 | 1521.47 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
main-HASH.js gzip | 6.72 kB | 6.72 kB | ✓ |
webpack-HASH.js gzip | 751 B | 751 B | ✓ |
19b7e98f51cc..cead.js gzip | 9.77 kB | 9.77 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 56.4 kB | 56.4 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.8 kB | 5.8 kB | ✓ |
webpack-HASH..dule.js gzip | 751 B | 751 B | ✓ |
19b7e98f51cc..dule.js gzip | 6.17 kB | 6.17 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 51.9 kB | 51.9 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.4 kB | 26.4 kB | ✓ |
Overall change | 26.4 kB | 26.4 kB | ✓ |
Client Build Manifests
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
_buildManifest.js gzip | 267 B | 267 B | ✓ |
_buildManife..dule.js gzip | 273 B | 273 B | ✓ |
Overall change | 540 B | 540 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
index.html gzip | 954 B | 954 B | ✓ |
link.html gzip | 962 B | 962 B | ✓ |
withRouter.html gzip | 948 B | 948 B | ✓ |
Overall change | 2.86 kB | 2.86 kB | ✓ |
Serverless Mode
General
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
buildDuration | 14.7s | 14.7s | |
nodeModulesSize | 66.5 MB | 66.5 MB | ✓ |
Client Bundles (main, webpack, commons)
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
main-HASH.js gzip | 6.72 kB | 6.72 kB | ✓ |
webpack-HASH.js gzip | 751 B | 751 B | ✓ |
19b7e98f51cc..cead.js gzip | 9.77 kB | 9.77 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 56.4 kB | 56.4 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.8 kB | 5.8 kB | ✓ |
webpack-HASH..dule.js gzip | 751 B | 751 B | ✓ |
19b7e98f51cc..dule.js gzip | 6.17 kB | 6.17 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 51.9 kB | 51.9 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.4 kB | 26.4 kB | ✓ |
Overall change | 26.4 kB | 26.4 kB | ✓ |
Client Build Manifests
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
_buildManifest.js gzip | 267 B | 267 B | ✓ |
_buildManife..dule.js gzip | 273 B | 273 B | ✓ |
Overall change | 540 B | 540 B | ✓ |
Serverless bundles
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
_error.js | 882 kB | 882 kB | ✓ |
404.html | 4.17 kB | 4.17 kB | ✓ |
hooks.html | 3.79 kB | 3.79 kB | ✓ |
index.js | 882 kB | 882 kB | ✓ |
link.js | 924 kB | 924 kB | ✓ |
routerDirect.js | 918 kB | 918 kB | ✓ |
withRouter.js | 918 kB | 918 kB | ✓ |
Overall change | 4.53 MB | 4.53 MB | ✓ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drumm2k LGTM, thank you!
Stats from current PRDefault Server Mode (Decrease detected ✓)General
Page Load Tests Overall decrease
|
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.335 | 2.392 | |
/ avg req/sec | 1070.58 | 1045.28 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.528 | 1.593 | |
/error-in-render avg req/sec | 1635.81 | 1569.45 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
main-HASH.js gzip | 6.72 kB | 6.72 kB | ✓ |
webpack-HASH.js gzip | 751 B | 751 B | ✓ |
19b7e98f51cc..cead.js gzip | 9.77 kB | 9.77 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 56.4 kB | 56.4 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.8 kB | 5.8 kB | ✓ |
webpack-HASH..dule.js gzip | 751 B | 751 B | ✓ |
19b7e98f51cc..dule.js gzip | 6.17 kB | 6.17 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 51.9 kB | 51.9 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.4 kB | 26.4 kB | ✓ |
Overall change | 26.4 kB | 26.4 kB | ✓ |
Client Build Manifests
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
_buildManifest.js gzip | 267 B | 267 B | ✓ |
_buildManife..dule.js gzip | 273 B | 273 B | ✓ |
Overall change | 540 B | 540 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
index.html gzip | 954 B | 954 B | ✓ |
link.html gzip | 962 B | 962 B | ✓ |
withRouter.html gzip | 948 B | 948 B | ✓ |
Overall change | 2.86 kB | 2.86 kB | ✓ |
Serverless Mode
General
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
buildDuration | 15.5s | 15.6s | |
nodeModulesSize | 66.5 MB | 66.5 MB | ✓ |
Client Bundles (main, webpack, commons)
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
main-HASH.js gzip | 6.72 kB | 6.72 kB | ✓ |
webpack-HASH.js gzip | 751 B | 751 B | ✓ |
19b7e98f51cc..cead.js gzip | 9.77 kB | 9.77 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 56.4 kB | 56.4 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.8 kB | 5.8 kB | ✓ |
webpack-HASH..dule.js gzip | 751 B | 751 B | ✓ |
19b7e98f51cc..dule.js gzip | 6.17 kB | 6.17 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 51.9 kB | 51.9 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.4 kB | 26.4 kB | ✓ |
Overall change | 26.4 kB | 26.4 kB | ✓ |
Client Build Manifests
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
_buildManifest.js gzip | 267 B | 267 B | ✓ |
_buildManife..dule.js gzip | 273 B | 273 B | ✓ |
Overall change | 540 B | 540 B | ✓ |
Serverless bundles
vercel/next.js canary | drumm2k/next.js canary | Change | |
---|---|---|---|
_error.js | 882 kB | 882 kB | ✓ |
404.html | 4.17 kB | 4.17 kB | ✓ |
hooks.html | 3.79 kB | 3.79 kB | ✓ |
index.js | 882 kB | 882 kB | ✓ |
link.js | 924 kB | 924 kB | ✓ |
routerDirect.js | 918 kB | 918 kB | ✓ |
withRouter.js | 918 kB | 918 kB | ✓ |
Overall change | 4.53 MB | 4.53 MB | ✓ |
apollo-client 2.6.8 -> 3.0.0