Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find pages/_document.js chunk in development #15172

Merged
merged 2 commits into from
Jul 15, 2020

Conversation

lfades
Copy link
Member

@lfades lfades commented Jul 14, 2020

Chunks already have a normalized path.

Not sure if there are other chunks that require this change, I did a global search and didn't find similar cases.

@ijjk
Copy link
Member

ijjk commented Jul 14, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary lfades/next.js fix/document-chunk Change
buildDuration 12.9s 12.7s -176ms
nodeModulesSize 66.5 MB 66.5 MB -54 B
Page Load Tests Overall increase ✓
vercel/next.js canary lfades/next.js fix/document-chunk Change
/ failed reqs 0 0
/ total time (seconds) 2.214 2.089 -0.12
/ avg req/sec 1129.27 1196.77 +67.5
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.337 1.285 -0.05
/error-in-render avg req/sec 1870.13 1946.2 +76.07
Client Bundles (main, webpack, commons)
vercel/next.js canary lfades/next.js fix/document-chunk Change
main-HASH.js gzip 6.72 kB 6.72 kB
webpack-HASH.js gzip 751 B 751 B
19b7e98f51cc..cead.js gzip 9.77 kB 9.77 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 56.4 kB 56.4 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary lfades/next.js fix/document-chunk Change
main-HASH.module.js gzip 5.8 kB 5.8 kB
webpack-HASH..dule.js gzip 751 B 751 B
19b7e98f51cc..dule.js gzip 6.17 kB 6.17 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.9 kB 51.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary lfades/next.js fix/document-chunk Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB
Overall change 26.4 kB 26.4 kB
Client Build Manifests
vercel/next.js canary lfades/next.js fix/document-chunk Change
_buildManifest.js gzip 267 B 267 B
_buildManife..dule.js gzip 273 B 273 B
Overall change 540 B 540 B
Rendered Page Sizes
vercel/next.js canary lfades/next.js fix/document-chunk Change
index.html gzip 954 B 954 B
link.html gzip 960 B 960 B
withRouter.html gzip 947 B 947 B
Overall change 2.86 kB 2.86 kB

Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary lfades/next.js fix/document-chunk Change
buildDuration 14.1s 14s -105ms
nodeModulesSize 66.5 MB 66.5 MB -54 B
Client Bundles (main, webpack, commons)
vercel/next.js canary lfades/next.js fix/document-chunk Change
main-HASH.js gzip 6.72 kB 6.72 kB
webpack-HASH.js gzip 751 B 751 B
19b7e98f51cc..cead.js gzip 9.77 kB 9.77 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 56.4 kB 56.4 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary lfades/next.js fix/document-chunk Change
main-HASH.module.js gzip 5.8 kB 5.8 kB
webpack-HASH..dule.js gzip 751 B 751 B
19b7e98f51cc..dule.js gzip 6.17 kB 6.17 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.9 kB 51.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary lfades/next.js fix/document-chunk Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB
Overall change 26.4 kB 26.4 kB
Client Build Manifests
vercel/next.js canary lfades/next.js fix/document-chunk Change
_buildManifest.js gzip 267 B 267 B
_buildManife..dule.js gzip 273 B 273 B
Overall change 540 B 540 B
Serverless bundles
vercel/next.js canary lfades/next.js fix/document-chunk Change
_error.js 882 kB 882 kB
404.html 4.17 kB 4.17 kB
hooks.html 3.79 kB 3.79 kB
index.js 882 kB 882 kB
link.js 924 kB 924 kB
routerDirect.js 918 kB 918 kB
withRouter.js 918 kB 918 kB
Overall change 4.53 MB 4.53 MB
Commit: 4de93b3

@ijjk
Copy link
Member

ijjk commented Jul 15, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary lfades/next.js fix/document-chunk Change
buildDuration 11.1s 10.9s -169ms
nodeModulesSize 66.5 MB 66.5 MB -54 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary lfades/next.js fix/document-chunk Change
/ failed reqs 0 0
/ total time (seconds) 1.799 1.783 -0.02
/ avg req/sec 1390 1402.02 +12.02
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.074 1.088 ⚠️ +0.01
/error-in-render avg req/sec 2327.54 2297.43 ⚠️ -30.11
Client Bundles (main, webpack, commons)
vercel/next.js canary lfades/next.js fix/document-chunk Change
main-HASH.js gzip 6.72 kB 6.72 kB
webpack-HASH.js gzip 751 B 751 B
19b7e98f51cc..cead.js gzip 9.77 kB 9.77 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 56.4 kB 56.4 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary lfades/next.js fix/document-chunk Change
main-HASH.module.js gzip 5.8 kB 5.8 kB
webpack-HASH..dule.js gzip 751 B 751 B
19b7e98f51cc..dule.js gzip 6.17 kB 6.17 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.9 kB 51.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary lfades/next.js fix/document-chunk Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB
Overall change 26.4 kB 26.4 kB
Client Build Manifests
vercel/next.js canary lfades/next.js fix/document-chunk Change
_buildManifest.js gzip 267 B 267 B
_buildManife..dule.js gzip 273 B 273 B
Overall change 540 B 540 B
Rendered Page Sizes
vercel/next.js canary lfades/next.js fix/document-chunk Change
index.html gzip 954 B 954 B
link.html gzip 960 B 960 B
withRouter.html gzip 947 B 947 B
Overall change 2.86 kB 2.86 kB

Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary lfades/next.js fix/document-chunk Change
buildDuration 11.7s 11.7s ⚠️ +30ms
nodeModulesSize 66.5 MB 66.5 MB -54 B
Client Bundles (main, webpack, commons)
vercel/next.js canary lfades/next.js fix/document-chunk Change
main-HASH.js gzip 6.72 kB 6.72 kB
webpack-HASH.js gzip 751 B 751 B
19b7e98f51cc..cead.js gzip 9.77 kB 9.77 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 56.4 kB 56.4 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary lfades/next.js fix/document-chunk Change
main-HASH.module.js gzip 5.8 kB 5.8 kB
webpack-HASH..dule.js gzip 751 B 751 B
19b7e98f51cc..dule.js gzip 6.17 kB 6.17 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.9 kB 51.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary lfades/next.js fix/document-chunk Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB
Overall change 26.4 kB 26.4 kB
Client Build Manifests
vercel/next.js canary lfades/next.js fix/document-chunk Change
_buildManifest.js gzip 267 B 267 B
_buildManife..dule.js gzip 273 B 273 B
Overall change 540 B 540 B
Serverless bundles
vercel/next.js canary lfades/next.js fix/document-chunk Change
_error.js 882 kB 882 kB
404.html 4.17 kB 4.17 kB
hooks.html 3.79 kB 3.79 kB
index.js 882 kB 882 kB
link.js 924 kB 924 kB
routerDirect.js 918 kB 918 kB
withRouter.js 918 kB 918 kB
Overall change 4.53 MB 4.53 MB
Commit: d05af5f

@kodiakhq kodiakhq bot merged commit 6639b8f into vercel:canary Jul 15, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants