Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use HEAD req for isUrlOk check #14994

Merged
merged 3 commits into from
Jul 9, 2020
Merged

Use HEAD req for isUrlOk check #14994

merged 3 commits into from
Jul 9, 2020

Conversation

cristiand391
Copy link
Contributor

@cristiand391 cristiand391 commented Jul 8, 2020 •
edited
Loading

Fix #14901

It now makes a HEAD request when checking example's url.

@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Jul 8, 2020
@ijjk
Copy link
Member

ijjk commented Jul 9, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary cristiand391/next.js use-head-method-for-url-check Change
buildDuration 14s 13.7s -246ms
nodeModulesSize 66.1 MB 66.1 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary cristiand391/next.js use-head-method-for-url-check Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.474 2.411 -0.06
/ avg req/sec 1010.54 1036.97 +26.43
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.638 1.623 -0.01
/error-in-render avg req/sec 1526.45 1540.38 +13.93
Client Bundles (main, webpack, commons)
vercel/next.js canary cristiand391/next.js use-head-method-for-url-check Change
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..e4a8.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary cristiand391/next.js use-head-method-for-url-check Change
main-HASH.module.js gzip 5.72 kB 5.72 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.1 kB 7.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary cristiand391/next.js use-head-method-for-url-check Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB ✓
Overall change 26.4 kB 26.4 kB ✓
Client Build Manifests
vercel/next.js canary cristiand391/next.js use-head-method-for-url-check Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Rendered Page Sizes
vercel/next.js canary cristiand391/next.js use-head-method-for-url-check Change
index.html gzip 953 B 953 B ✓
link.html gzip 961 B 961 B ✓
withRouter.html gzip 946 B 946 B ✓
Overall change 2.86 kB 2.86 kB ✓
Serverless Mode
General
vercel/next.js canary cristiand391/next.js use-head-method-for-url-check Change
buildDuration 14.7s 14.6s -91ms
nodeModulesSize 66.1 MB 66.1 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary cristiand391/next.js use-head-method-for-url-check Change
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..e4a8.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary cristiand391/next.js use-head-method-for-url-check Change
main-HASH.module.js gzip 5.72 kB 5.72 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.1 kB 7.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary cristiand391/next.js use-head-method-for-url-check Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB ✓
Overall change 26.4 kB 26.4 kB ✓
Client Build Manifests
vercel/next.js canary cristiand391/next.js use-head-method-for-url-check Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Serverless bundles
vercel/next.js canary cristiand391/next.js use-head-method-for-url-check Change
_error.js 876 kB 876 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 877 kB 877 kB ✓
link.js 916 kB 916 kB ✓
routerDirect.js 909 kB 909 kB ✓
withRouter.js 910 kB 910 kB ✓
Overall change 4.5 MB 4.5 MB ✓
Commit: 4539dbd

@ijjk
Copy link
Member

ijjk commented Jul 9, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary cristiand391/next.js use-head-method-for-url-check Change
buildDuration 13.3s 13.4s ⚠️ +106ms
nodeModulesSize 66.1 MB 66.1 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary cristiand391/next.js use-head-method-for-url-check Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.272 2.206 -0.07
/ avg req/sec 1100.39 1133.44 +33.05
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.528 1.524 0
/error-in-render avg req/sec 1635.78 1640.2 +4.42
Client Bundles (main, webpack, commons)
vercel/next.js canary cristiand391/next.js use-head-method-for-url-check Change
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..e4a8.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary cristiand391/next.js use-head-method-for-url-check Change
main-HASH.module.js gzip 5.72 kB 5.72 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.1 kB 7.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary cristiand391/next.js use-head-method-for-url-check Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB ✓
Overall change 26.4 kB 26.4 kB ✓
Client Build Manifests
vercel/next.js canary cristiand391/next.js use-head-method-for-url-check Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Rendered Page Sizes
vercel/next.js canary cristiand391/next.js use-head-method-for-url-check Change
index.html gzip 953 B 953 B ✓
link.html gzip 961 B 961 B ✓
withRouter.html gzip 945 B 945 B ✓
Overall change 2.86 kB 2.86 kB ✓
Serverless Mode
General
vercel/next.js canary cristiand391/next.js use-head-method-for-url-check Change
buildDuration 14.3s 16.2s ⚠️ +1.9s
nodeModulesSize 66.1 MB 66.1 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary cristiand391/next.js use-head-method-for-url-check Change
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..e4a8.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary cristiand391/next.js use-head-method-for-url-check Change
main-HASH.module.js gzip 5.72 kB 5.72 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.1 kB 7.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary cristiand391/next.js use-head-method-for-url-check Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB ✓
Overall change 26.4 kB 26.4 kB ✓
Client Build Manifests
vercel/next.js canary cristiand391/next.js use-head-method-for-url-check Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Serverless bundles
vercel/next.js canary cristiand391/next.js use-head-method-for-url-check Change
_error.js 876 kB 876 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 877 kB 877 kB ✓
link.js 916 kB 916 kB ✓
routerDirect.js 909 kB 909 kB ✓
withRouter.js 910 kB 910 kB ✓
Overall change 4.5 MB 4.5 MB ✓
Commit: c73545e

@Timer Timer merged commit 887d436 into vercel:canary Jul 9, 2020
@cristiand391 cristiand391 deleted the use-head-method-for-url-check branch July 9, 2020 17:00
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@cristiand391 @rokinsky
Use HEAD req for isUrlOk check (vercel#14994)
8a89bf1 
Co-authored-by: Cristian Dominguez <[email protected]>
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens timneutkens approved these changes

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

recommendation: use HEAD requests for isUrlOk check
4 participants
@cristiand391 @ijjk @timneutkens @Timer