Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basePath documentation #14882

Merged
merged 2 commits into from
Jul 6, 2020
Merged

Add basePath documentation #14882

merged 2 commits into from
Jul 6, 2020

Conversation

timneutkens
Copy link
Member

Fixes #14453

Timer
Timer approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ijjk
Copy link
Member

ijjk commented Jul 6, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary timneutkens/next.js add/basepath-documentation Change
buildDuration 12s 11.6s -375ms
nodeModulesSize 66.1 MB 66.1 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/basepath-documentation Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.906 1.965 ⚠️ +0.06
/ avg req/sec 1311.32 1272.49 ⚠️ -38.83
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.217 1.243 ⚠️ +0.03
/error-in-render avg req/sec 2055.01 2011.63 ⚠️ -43.38
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/basepath-documentation Change
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..18e4.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js add/basepath-documentation Change
main-HASH.module.js gzip 5.71 kB 5.71 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.09 kB 7.09 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/basepath-documentation Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB ✓
Overall change 26.4 kB 26.4 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/basepath-documentation Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/basepath-documentation Change
index.html gzip 954 B 954 B ✓
link.html gzip 958 B 958 B ✓
withRouter.html gzip 945 B 945 B ✓
Overall change 2.86 kB 2.86 kB ✓
Serverless Mode
General
vercel/next.js canary timneutkens/next.js add/basepath-documentation Change
buildDuration 12.9s 12.5s -379ms
nodeModulesSize 66.1 MB 66.1 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/basepath-documentation Change
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..18e4.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js add/basepath-documentation Change
main-HASH.module.js gzip 5.71 kB 5.71 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.09 kB 7.09 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/basepath-documentation Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB ✓
Overall change 26.4 kB 26.4 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/basepath-documentation Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js add/basepath-documentation Change
_error.js 876 kB 876 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 876 kB 876 kB ✓
link.js 915 kB 915 kB ✓
routerDirect.js 908 kB 908 kB ✓
withRouter.js 908 kB 908 kB ✓
Overall change 4.49 MB 4.49 MB ✓
Commit: 62a7edd

@ijjk
Copy link
Member

ijjk commented Jul 6, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary timneutkens/next.js add/basepath-documentation Change
buildDuration 12s 12.7s ⚠️ +747ms
nodeModulesSize 66.1 MB 66.1 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/basepath-documentation Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.997 2.132 ⚠️ +0.14
/ avg req/sec 1251.68 1172.58 ⚠️ -79.1
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.233 1.213 -0.02
/error-in-render avg req/sec 2026.77 2061.83 +35.06
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/basepath-documentation Change
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..18e4.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js add/basepath-documentation Change
main-HASH.module.js gzip 5.71 kB 5.71 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.09 kB 7.09 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/basepath-documentation Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB ✓
Overall change 26.4 kB 26.4 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/basepath-documentation Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/basepath-documentation Change
index.html gzip 954 B 954 B ✓
link.html gzip 958 B 958 B ✓
withRouter.html gzip 945 B 945 B ✓
Overall change 2.86 kB 2.86 kB ✓
Serverless Mode
General
vercel/next.js canary timneutkens/next.js add/basepath-documentation Change
buildDuration 13.2s 13.6s ⚠️ +408ms
nodeModulesSize 66.1 MB 66.1 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/basepath-documentation Change
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..18e4.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js add/basepath-documentation Change
main-HASH.module.js gzip 5.71 kB 5.71 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.09 kB 7.09 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/basepath-documentation Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB ✓
Overall change 26.4 kB 26.4 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/basepath-documentation Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js add/basepath-documentation Change
_error.js 876 kB 876 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 876 kB 876 kB ✓
link.js 915 kB 915 kB ✓
routerDirect.js 908 kB 908 kB ✓
withRouter.js 908 kB 908 kB ✓
Overall change 4.49 MB 4.49 MB ✓
Commit: ff6b97a

@kodiakhq kodiakhq bot merged commit 6fe1260 into vercel:canary Jul 6, 2020
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@timneutkens @rokinsky
Add basePath documentation (vercel#14882)
a2a1b5b 
Fixes vercel#14453
@timneutkens timneutkens deleted the add/basepath-documentation branch February 12, 2021 13:33
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation for basePath
3 participants
@timneutkens @ijjk @Timer