Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add webpack peerdependency to react-dev-overlay #14842

Merged
merged 2 commits into from
Jul 5, 2020
Merged

Add webpack peerdependency to react-dev-overlay #14842

merged 2 commits into from
Jul 5, 2020

Conversation

timneutkens
Copy link
Member

Fixes #14833

@timneutkens timneutkens requested review from ijjk, lfades and Timer as code owners July 4, 2020 09:20
@ijjk ijjk added the type: next label Jul 4, 2020
@ijjk
Copy link
Member

ijjk commented Jul 4, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary timneutkens/next.js fix/peerdeps Change
buildDuration 12.5s 12.8s ⚠️ +318ms
nodeModulesSize 66.1 MB 66.1 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/peerdeps Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.265 2.2 -0.06
/ avg req/sec 1103.78 1136.16 +32.38
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.496 1.421 -0.07
/error-in-render avg req/sec 1670.84 1759.43 +88.59
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/peerdeps Change
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..18e4.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/peerdeps Change
main-HASH.module.js gzip 5.71 kB 5.71 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.09 kB 7.09 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/peerdeps Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/peerdeps Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/peerdeps Change
index.html gzip 954 B 954 B ✓
link.html gzip 959 B 959 B ✓
withRouter.html gzip 946 B 946 B ✓
Overall change 2.86 kB 2.86 kB ✓
Serverless Mode
General
vercel/next.js canary timneutkens/next.js fix/peerdeps Change
buildDuration 13.7s 13.7s -30ms
nodeModulesSize 66.1 MB 66.1 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/peerdeps Change
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..18e4.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/peerdeps Change
main-HASH.module.js gzip 5.71 kB 5.71 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.09 kB 7.09 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/peerdeps Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/peerdeps Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/peerdeps Change
_error.js 876 kB 876 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 876 kB 876 kB ✓
link.js 915 kB 915 kB ✓
routerDirect.js 908 kB 908 kB ✓
withRouter.js 908 kB 908 kB ✓
Overall change 4.49 MB 4.49 MB ✓
Commit: d9e5df6

@ijjk
Copy link
Member

ijjk commented Jul 5, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary timneutkens/next.js fix/peerdeps Change
buildDuration 10.4s 10.3s -52ms
nodeModulesSize 66.1 MB 66.1 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/peerdeps Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.82 1.767 -0.05
/ avg req/sec 1373.6 1414.86 +41.26
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.22 1.22 ✓
/error-in-render avg req/sec 2048.79 2049.94 +1.15
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/peerdeps Change
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..18e4.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/peerdeps Change
main-HASH.module.js gzip 5.71 kB 5.71 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.09 kB 7.09 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/peerdeps Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB ✓
Overall change 26.4 kB 26.4 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/peerdeps Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/peerdeps Change
index.html gzip 954 B 954 B ✓
link.html gzip 958 B 958 B ✓
withRouter.html gzip 945 B 945 B ✓
Overall change 2.86 kB 2.86 kB ✓
Serverless Mode
General
vercel/next.js canary timneutkens/next.js fix/peerdeps Change
buildDuration 11.7s 11.2s -433ms
nodeModulesSize 66.1 MB 66.1 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/peerdeps Change
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..18e4.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/peerdeps Change
main-HASH.module.js gzip 5.71 kB 5.71 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.09 kB 7.09 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/peerdeps Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB ✓
Overall change 26.4 kB 26.4 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/peerdeps Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/peerdeps Change
_error.js 876 kB 876 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 876 kB 876 kB ✓
link.js 915 kB 915 kB ✓
routerDirect.js 908 kB 908 kB ✓
withRouter.js 908 kB 908 kB ✓
Overall change 4.49 MB 4.49 MB ✓
Commit: c889a4f

@Timer Timer merged commit 55bfafc into vercel:canary Jul 5, 2020
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@timneutkens @rokinsky
Add webpack peerdependency to react-dev-overlay (vercel#14842)
3f75d14
@timneutkens timneutkens deleted the fix/peerdeps branch February 12, 2021 13:33
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

webpack dependency in @next/react-dev-overlay
3 participants
@timneutkens @ijjk @Timer