Replace extra source line in webpack 5 #14793

timneutkens · 2020-07-02T10:27:48Z

webpack:// is included instead of webpack:///, this fixes that.

Added sourcemaps for a few of the React Refresh packages to make Node.js debugging in vscode work with those.
Made ReactRefreshPlugin.ts no-op when using webpack 5, need to discuss with @Timer if it's needed in webpack 5.

ijjk · 2020-07-02T10:35:51Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
buildDuration	10.9s	12.1s	⚠️ +1.2s
nodeModulesSize	66 MB	66 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.918	2.157	⚠️ +0.24
/ avg req/sec	1303.33	1159.27	⚠️ -144.06
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.315	1.381	⚠️ +0.07
/error-in-render avg req/sec	1901.25	1810.02	⚠️ -91.23

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..18e4.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
main-HASH.module.js gzip	5.71 kB	5.71 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.09 kB	7.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
index.html gzip	953 B	953 B	✓
link.html gzip	959 B	959 B	✓
withRouter.html gzip	946 B	946 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode

General

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
buildDuration	11.2s	11.5s	⚠️ +263ms
nodeModulesSize	66 MB	66 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..18e4.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
main-HASH.module.js gzip	5.71 kB	5.71 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.09 kB	7.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Serverless bundles

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
_error.js	876 kB	876 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	876 kB	876 kB	✓
link.js	914 kB	914 kB	✓
routerDirect.js	908 kB	908 kB	✓
withRouter.js	908 kB	908 kB	✓
Overall change	4.49 MB	4.49 MB	✓

Commit: 3b3afd8

ijjk · 2020-07-02T14:26:03Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
buildDuration	11.7s	11.9s	⚠️ +130ms
nodeModulesSize	66 MB	66 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.999	1.961	-0.04
/ avg req/sec	1250.72	1274.76	+24.04
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.317	1.343	⚠️ +0.03
/error-in-render avg req/sec	1897.59	1861.65	⚠️ -35.94

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..18e4.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
main-HASH.module.js gzip	5.71 kB	5.71 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.09 kB	7.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
index.html gzip	953 B	953 B	✓
link.html gzip	959 B	959 B	✓
withRouter.html gzip	946 B	946 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode

General

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
buildDuration	12.3s	12.1s	-199ms
nodeModulesSize	66 MB	66 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..18e4.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
main-HASH.module.js gzip	5.71 kB	5.71 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.09 kB	7.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Serverless bundles

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
_error.js	876 kB	876 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	876 kB	876 kB	✓
link.js	914 kB	914 kB	✓
routerDirect.js	908 kB	908 kB	✓
withRouter.js	908 kB	908 kB	✓
Overall change	4.49 MB	4.49 MB	✓

Commit: f939902

…imneutkens/next.js into fix/react-fast-refresh-plugin-webpack5

ijjk · 2020-07-03T09:25:56Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
buildDuration	12.4s	12.4s	-22ms
nodeModulesSize	66 MB	66 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.031	2.01	-0.02
/ avg req/sec	1230.92	1243.73	+12.81
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.202	1.164	-0.04
/error-in-render avg req/sec	2080.15	2148.07	+67.92

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..18e4.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
main-HASH.module.js gzip	5.71 kB	5.71 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.09 kB	7.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
index.html gzip	955 B	955 B	✓
link.html gzip	961 B	961 B	✓
withRouter.html gzip	948 B	948 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode

General

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
buildDuration	12.9s	13.1s	⚠️ +189ms
nodeModulesSize	66 MB	66 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..18e4.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
main-HASH.module.js gzip	5.71 kB	5.71 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.09 kB	7.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Serverless bundles

	vercel/next.js canary	timneutkens/next.js fix/react-fast-refresh-plugin-webpack5	Change
_error.js	876 kB	876 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	876 kB	876 kB	✓
link.js	915 kB	915 kB	✓
routerDirect.js	908 kB	908 kB	✓
withRouter.js	908 kB	908 kB	✓
Overall change	4.49 MB	4.49 MB	✓

Commit: 7978e5d

Co-authored-by: Joe Haddad <[email protected]> Co-authored-by: Joe Haddad <[email protected]>

timneutkens added 5 commits July 2, 2020 11:52

Add sourcemaps to make debugger work

623d5ba

Remove devDependency on webpack to avoid conflicts with next

3c5282d

Add webpack 5 case that is a no-op for now

87bfbbc

Add sourcemaps for debugging

5b9e59a

Replace new webpack:// output

3b3afd8

timneutkens requested review from ijjk, lfades and Timer as code owners July 2, 2020 10:27

ijjk added the type: next label Jul 2, 2020

Update .gitignore

f939902

timneutkens and others added 7 commits July 2, 2020 17:45

Make ReactRefreshPlugin compatible with webpack 5

6437f39

Merge branch 'fix/react-fast-refresh-plugin-webpack5' of github.com:t…

7ecf195

…imneutkens/next.js into fix/react-fast-refresh-plugin-webpack5

Fix typescript errors

fdee121

Emit as class

1fa2f8d

Add correct module id

8f2a127

Fix type errors

e1b50eb

Fix type error

b10310e

This comment has been minimized.

Sign in to view

Move class

7978e5d

timneutkens merged commit c5e1e48 into vercel:canary Jul 3, 2020

timneutkens deleted the fix/react-fast-refresh-plugin-webpack5 branch July 3, 2020 11:30

timneutkens mentioned this pull request Jul 4, 2020

feat: Webpack 5 Experimental Support #10885

Closed

9 tasks

rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020

Replace extra source line in webpack 5 (vercel#14793)

c52f2fa

Co-authored-by: Joe Haddad <[email protected]> Co-authored-by: Joe Haddad <[email protected]>

vercel locked as resolved and limited conversation to collaborators Jan 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace extra source line in webpack 5 #14793

Replace extra source line in webpack 5 #14793

timneutkens commented Jul 2, 2020

ijjk commented Jul 2, 2020

ijjk commented Jul 2, 2020

This comment has been minimized.

This comment has been minimized.

ijjk commented Jul 3, 2020

Replace extra source line in webpack 5 #14793

Replace extra source line in webpack 5 #14793

Conversation

timneutkens commented Jul 2, 2020

ijjk commented Jul 2, 2020

Stats from current PR

ijjk commented Jul 2, 2020

Stats from current PR

This comment has been minimized.

This comment has been minimized.

ijjk commented Jul 3, 2020

Stats from current PR