Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add etag support for getServerSideProps/getStaticProps pages #14760

Merged
merged 6 commits into from
Jul 1, 2020
Merged

Add etag support for getServerSideProps/getStaticProps pages #14760

merged 6 commits into from
Jul 1, 2020

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Jul 1, 2020 •
edited
Loading

Fixes #11711

Also cleaned up some extra code.

This was already supported on the Vercel edge network.

@timneutkens timneutkens requested review from ijjk, lfades and Timer as code owners July 1, 2020 09:13
@ijjk ijjk added the type: next label Jul 1, 2020
@ijjk
Copy link
Member

ijjk commented Jul 1, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
buildDuration 13.7s 13.3s -334ms
nodeModulesSize 66 MB 66 MB -196 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.311 2.295 -0.02
/ avg req/sec 1081.57 1089.36 +7.79
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.593 1.66 ⚠️ +0.07
/error-in-render avg req/sec 1569.38 1506.18 ⚠️ -63.2
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..769f.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
main-HASH.module.js gzip 5.68 kB 5.68 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.09 kB 7.09 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
index.html gzip 953 B 953 B ✓
link.html gzip 962 B 962 B ✓
withRouter.html gzip 946 B 946 B ✓
Overall change 2.86 kB 2.86 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
buildDuration 14.3s 14.7s ⚠️ +355ms
nodeModulesSize 66 MB 66 MB -196 B
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..769f.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
main-HASH.module.js gzip 5.68 kB 5.68 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.09 kB 7.09 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
_error.js 875 kB 875 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 876 kB 876 kB ✓
link.js 915 kB 915 kB ✓
routerDirect.js 907 kB 907 kB ✓
withRouter.js 907 kB 907 kB ✓
Overall change 4.49 MB 4.49 MB ✓
Commit: 4e5e804

@timneutkens timneutkens changed the title Remove unused comment Add etag support for getServerSideProps/getStaticProps pages Jul 1, 2020
@ijjk
Copy link
Member

ijjk commented Jul 1, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
buildDuration 13.4s 13.4s -3ms
nodeModulesSize 66 MB 66 MB ⚠️ +2.02 kB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.345 2.308 -0.04
/ avg req/sec 1066.08 1083.05 +16.97
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.572 1.547 -0.03
/error-in-render avg req/sec 1590.59 1616.28 +25.69
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..769f.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
main-HASH.module.js gzip 5.68 kB 5.68 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.09 kB 7.09 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
index.html gzip 953 B 953 B ✓
link.html gzip 962 B 962 B ✓
withRouter.html gzip 946 B 946 B ✓
Overall change 2.86 kB 2.86 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
buildDuration 14.8s 14.7s -25ms
nodeModulesSize 66 MB 66 MB ⚠️ +2.02 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..769f.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
main-HASH.module.js gzip 5.68 kB 5.68 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.09 kB 7.09 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
_error.js 875 kB 876 kB ⚠️ +394 B
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 876 kB 876 kB ⚠️ +394 B
link.js 915 kB 915 kB ⚠️ +394 B
routerDirect.js 907 kB 908 kB ⚠️ +394 B
withRouter.js 907 kB 908 kB ⚠️ +394 B
Overall change 4.49 MB 4.49 MB ⚠️ +1.97 kB
Commit: 70d0dde

@ijjk
Copy link
Member

ijjk commented Jul 1, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
buildDuration 13.1s 13.2s ⚠️ +66ms
nodeModulesSize 66 MB 66 MB ⚠️ +2.27 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.336 2.32 -0.02
/ avg req/sec 1070.14 1077.77 +7.63
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.552 1.58 ⚠️ +0.03
/error-in-render avg req/sec 1611.2 1582.01 ⚠️ -29.19
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..769f.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
main-HASH.module.js gzip 5.68 kB 5.68 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.09 kB 7.09 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
index.html gzip 953 B 953 B ✓
link.html gzip 962 B 962 B ✓
withRouter.html gzip 946 B 946 B ✓
Overall change 2.86 kB 2.86 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
buildDuration 14.9s 14.5s -398ms
nodeModulesSize 66 MB 66 MB ⚠️ +2.27 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..769f.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
main-HASH.module.js gzip 5.68 kB 5.68 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.09 kB 7.09 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/unused-comment Change
_error.js 875 kB 876 kB ⚠️ +393 B
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 876 kB 876 kB ⚠️ +393 B
link.js 915 kB 915 kB ⚠️ +393 B
routerDirect.js 907 kB 908 kB ⚠️ +393 B
withRouter.js 907 kB 908 kB ⚠️ +393 B
Overall change 4.49 MB 4.49 MB ⚠️ +1.97 kB
Commit: f2b76a8

@kodiakhq kodiakhq bot merged commit 260707d into vercel:canary Jul 1, 2020
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@timneutkens @rokinsky
Add etag support for getServerSideProps/getStaticProps pages (vercel#…
65a2d76 
…14760)

Fixes vercel#11711

Also cleaned up some extra code.

This was already supported on the Vercel edge network.
@timneutkens timneutkens deleted the fix/unused-comment branch February 12, 2021 13:33
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No eTag for HTML in SSR mode from 9.3.1
3 participants
@timneutkens @ijjk @Timer