Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URL being updated with basePath for 404 page #14740

Merged
merged 2 commits into from
Jul 2, 2020
Merged

Fix URL being updated with basePath for 404 page #14740

merged 2 commits into from
Jul 2, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jun 30, 2020

This makes sure we aren't updating the URL when a 404 is encountered and basePath is used

Closes: #14735

@ijjk
Copy link
Member Author

ijjk commented Jun 30, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/basepath-404-url Change
buildDuration 12.7s 12.7s ⚠️ +60ms
nodeModulesSize 66 MB 66 MB ⚠️ +544 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/basepath-404-url Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.143 2.135 -0.01
/ avg req/sec 1166.67 1170.95 +4.28
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.487 1.47 -0.02
/error-in-render avg req/sec 1681.6 1700.12 +18.52
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/basepath-404-url Change
main-HASH.js gzip 6.59 kB 6.63 kB ⚠️ +40 B
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..769f.js gzip 10.7 kB 10.7 kB -2 B
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ⚠️ +38 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/basepath-404-url Change
main-HASH.module.js gzip 5.68 kB 5.71 kB ⚠️ +39 B
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.09 kB 7.09 kB -1 B
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.7 kB 52.7 kB ⚠️ +38 B
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/basepath-404-url Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/basepath-404-url Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/basepath-404-url Change
index.html gzip 952 B 954 B ⚠️ +2 B
link.html gzip 961 B 960 B -1 B
withRouter.html gzip 945 B 946 B ⚠️ +1 B
Overall change 2.86 kB 2.86 kB ⚠️ +2 B

Diffs

Diff for 19b7e98f51cc..635f89339.js 
@@ -1036,7 +1036,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
                   pathname: addBasePath(_pathname),
                   query: _query
                 }),
-                addBasePath(_as)
+                (0, _utils.getURL)()
               );
             }
Diff for 19b7e98f51cc..ae.module.js 
@@ -899,7 +899,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
                   pathname: addBasePath(_pathname),
                   query: _query
                 }),
-                addBasePath(_as)
+                (0, _utils.getURL)()
               );
             }
Diff for main-HASH.js 
@@ -315,7 +315,19 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
         serverRuntimeConfig: {},
         publicRuntimeConfig: runtimeConfig || {}
       });
-      var asPath = (0, _router2.delBasePath)((0, _utils.getURL)());
+      var asPath = (0, _utils.getURL)(); // make sure not to attempt stripping basePath for 404s
+
+      if (
+        page !== "/404" &&
+        !(
+          page === "/_error" &&
+          hydrateProps &&
+          hydrateProps.pageProps.statusCode === "404"
+        )
+      ) {
+        asPath = (0, _router2.delBasePath)(asPath);
+      }
+
       var pageLoader = new _pageLoader["default"](buildId, prefix, page);
 
       var register = function register(_ref) {
Diff for main-HASH.module.js 
@@ -235,7 +235,19 @@
         serverRuntimeConfig: {},
         publicRuntimeConfig: runtimeConfig || {}
       });
-      var asPath = (0, _router2.delBasePath)((0, _utils.getURL)());
+      var asPath = (0, _utils.getURL)(); // make sure not to attempt stripping basePath for 404s
+
+      if (
+        page !== "/404" &&
+        !(
+          page === "/_error" &&
+          hydrateProps &&
+          hydrateProps.pageProps.statusCode === "404"
+        )
+      ) {
+        asPath = (0, _router2.delBasePath)(asPath);
+      }
+
       var pageLoader = new _pageLoader.default(buildId, prefix, page);
 
       var register = _ref => {
Diff for index.html 
@@ -6,7 +6,7 @@
     <meta name="next-head-count" content="2" />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-a694334f15bc9664aff4.module.js"
+      href="/_next/static/runtime/main-f41dd4b1c8480a45095e.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.9c6456595c07d734f6ae.module.js"
+      href="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.71ed17adb342dbac10f3.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -81,13 +81,13 @@
       src="/_next/static/runtime/polyfills-e77205bd3f87781c0279.js"
     ></script>
     <script
-      src="/_next/static/runtime/main-b5c056d5401b7d541afe.js"
+      src="/_next/static/runtime/main-af2e67e20222b4038d50.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/runtime/main-a694334f15bc9664aff4.module.js"
+      src="/_next/static/runtime/main-f41dd4b1c8480a45095e.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
@@ -117,13 +117,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.998e901c20c635f89339.js"
+      src="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.b3df11c7b7f7aaff5f36.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.9c6456595c07d734f6ae.module.js"
+      src="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.71ed17adb342dbac10f3.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -6,7 +6,7 @@
     <meta name="next-head-count" content="2" />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-a694334f15bc9664aff4.module.js"
+      href="/_next/static/runtime/main-f41dd4b1c8480a45095e.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.9c6456595c07d734f6ae.module.js"
+      href="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.71ed17adb342dbac10f3.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -86,13 +86,13 @@
       src="/_next/static/runtime/polyfills-e77205bd3f87781c0279.js"
     ></script>
     <script
-      src="/_next/static/runtime/main-b5c056d5401b7d541afe.js"
+      src="/_next/static/runtime/main-af2e67e20222b4038d50.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/runtime/main-a694334f15bc9664aff4.module.js"
+      src="/_next/static/runtime/main-f41dd4b1c8480a45095e.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
@@ -122,13 +122,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.998e901c20c635f89339.js"
+      src="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.b3df11c7b7f7aaff5f36.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.9c6456595c07d734f6ae.module.js"
+      src="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.71ed17adb342dbac10f3.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -6,7 +6,7 @@
     <meta name="next-head-count" content="2" />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-a694334f15bc9664aff4.module.js"
+      href="/_next/static/runtime/main-f41dd4b1c8480a45095e.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.9c6456595c07d734f6ae.module.js"
+      href="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.71ed17adb342dbac10f3.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -81,13 +81,13 @@
       src="/_next/static/runtime/polyfills-e77205bd3f87781c0279.js"
     ></script>
     <script
-      src="/_next/static/runtime/main-b5c056d5401b7d541afe.js"
+      src="/_next/static/runtime/main-af2e67e20222b4038d50.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/runtime/main-a694334f15bc9664aff4.module.js"
+      src="/_next/static/runtime/main-f41dd4b1c8480a45095e.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
@@ -117,13 +117,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.998e901c20c635f89339.js"
+      src="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.b3df11c7b7f7aaff5f36.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.9c6456595c07d734f6ae.module.js"
+      src="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.71ed17adb342dbac10f3.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/basepath-404-url Change
buildDuration 13.7s 13.6s -125ms
nodeModulesSize 66 MB 66 MB ⚠️ +544 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/basepath-404-url Change
main-HASH.js gzip 6.59 kB 6.63 kB ⚠️ +40 B
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..769f.js gzip 10.7 kB N/A N/A
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
19b7e98f51cc..eb6a.js gzip N/A 10.7 kB N/A
Overall change 57.2 kB 57.2 kB ⚠️ +38 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/basepath-404-url Change
main-HASH.module.js gzip 5.68 kB 5.71 kB ⚠️ +39 B
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.09 kB N/A N/A
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
19b7e98f51cc..dule.js gzip N/A 7.09 kB N/A
Overall change 52.7 kB 52.7 kB ⚠️ +38 B
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/basepath-404-url Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/basepath-404-url Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js fix/basepath-404-url Change
_error.js 875 kB 875 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 876 kB 876 kB ✓
link.js 915 kB 915 kB ✓
routerDirect.js 907 kB 907 kB ✓
withRouter.js 907 kB 907 kB ✓
Overall change 4.49 MB 4.49 MB ✓
Commit: 40e4977

@ijjk
Copy link
Member Author

ijjk commented Jul 2, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/basepath-404-url Change
buildDuration 10.7s 10.9s ⚠️ +150ms
nodeModulesSize 66 MB 66 MB ⚠️ +544 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/basepath-404-url Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.738 1.797 ⚠️ +0.06
/ avg req/sec 1438.08 1391.01 ⚠️ -47.07
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.057 1.072 ⚠️ +0.02
/error-in-render avg req/sec 2365.22 2332.29 ⚠️ -32.93
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/basepath-404-url Change
main-HASH.js gzip 6.59 kB 6.63 kB ⚠️ +40 B
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..b4c5.js gzip 10.7 kB 10.7 kB -3 B
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ⚠️ +37 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/basepath-404-url Change
main-HASH.module.js gzip 5.68 kB 5.71 kB ⚠️ +39 B
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.09 kB 7.09 kB -2 B
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.7 kB 52.7 kB ⚠️ +37 B
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/basepath-404-url Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/basepath-404-url Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/basepath-404-url Change
index.html gzip 952 B 953 B ⚠️ +1 B
link.html gzip 958 B 961 B ⚠️ +3 B
withRouter.html gzip 945 B 946 B ⚠️ +1 B
Overall change 2.85 kB 2.86 kB ⚠️ +5 B

Diffs

Diff for 19b7e98f51cc..79c601a31.js 
@@ -1036,7 +1036,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
                   pathname: addBasePath(_pathname),
                   query: _query
                 }),
-                addBasePath(_as)
+                (0, _utils.getURL)()
               );
             }
Diff for 19b7e98f51cc..2f.module.js 
@@ -899,7 +899,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
                   pathname: addBasePath(_pathname),
                   query: _query
                 }),
-                addBasePath(_as)
+                (0, _utils.getURL)()
               );
             }
Diff for main-HASH.js 
@@ -315,7 +315,19 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
         serverRuntimeConfig: {},
         publicRuntimeConfig: runtimeConfig || {}
       });
-      var asPath = (0, _router2.delBasePath)((0, _utils.getURL)());
+      var asPath = (0, _utils.getURL)(); // make sure not to attempt stripping basePath for 404s
+
+      if (
+        page !== "/404" &&
+        !(
+          page === "/_error" &&
+          hydrateProps &&
+          hydrateProps.pageProps.statusCode === "404"
+        )
+      ) {
+        asPath = (0, _router2.delBasePath)(asPath);
+      }
+
       var pageLoader = new _pageLoader["default"](buildId, prefix, page);
 
       var register = function register(_ref) {
Diff for main-HASH.module.js 
@@ -235,7 +235,19 @@
         serverRuntimeConfig: {},
         publicRuntimeConfig: runtimeConfig || {}
       });
-      var asPath = (0, _router2.delBasePath)((0, _utils.getURL)());
+      var asPath = (0, _utils.getURL)(); // make sure not to attempt stripping basePath for 404s
+
+      if (
+        page !== "/404" &&
+        !(
+          page === "/_error" &&
+          hydrateProps &&
+          hydrateProps.pageProps.statusCode === "404"
+        )
+      ) {
+        asPath = (0, _router2.delBasePath)(asPath);
+      }
+
       var pageLoader = new _pageLoader.default(buildId, prefix, page);
 
       var register = _ref => {
Diff for index.html 
@@ -6,7 +6,7 @@
     <meta name="next-head-count" content="2" />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-b3469e24ceb470ee7a74.module.js"
+      href="/_next/static/runtime/main-3ded133333b846351ff5.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.7b7753d866184925532f.module.js"
+      href="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.12a66c28dfec2bca8613.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -81,13 +81,13 @@
       src="/_next/static/runtime/polyfills-e77205bd3f87781c0279.js"
     ></script>
     <script
-      src="/_next/static/runtime/main-4acf5af77a3955aa98db.js"
+      src="/_next/static/runtime/main-ba5b6ced9961fae765a4.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/runtime/main-b3469e24ceb470ee7a74.module.js"
+      src="/_next/static/runtime/main-3ded133333b846351ff5.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
@@ -117,13 +117,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.187255446fb79c601a31.js"
+      src="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.15dc873ded6079014588.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.7b7753d866184925532f.module.js"
+      src="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.12a66c28dfec2bca8613.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -6,7 +6,7 @@
     <meta name="next-head-count" content="2" />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-b3469e24ceb470ee7a74.module.js"
+      href="/_next/static/runtime/main-3ded133333b846351ff5.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.7b7753d866184925532f.module.js"
+      href="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.12a66c28dfec2bca8613.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -86,13 +86,13 @@
       src="/_next/static/runtime/polyfills-e77205bd3f87781c0279.js"
     ></script>
     <script
-      src="/_next/static/runtime/main-4acf5af77a3955aa98db.js"
+      src="/_next/static/runtime/main-ba5b6ced9961fae765a4.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/runtime/main-b3469e24ceb470ee7a74.module.js"
+      src="/_next/static/runtime/main-3ded133333b846351ff5.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
@@ -122,13 +122,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.187255446fb79c601a31.js"
+      src="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.15dc873ded6079014588.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.7b7753d866184925532f.module.js"
+      src="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.12a66c28dfec2bca8613.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -6,7 +6,7 @@
     <meta name="next-head-count" content="2" />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-b3469e24ceb470ee7a74.module.js"
+      href="/_next/static/runtime/main-3ded133333b846351ff5.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.7b7753d866184925532f.module.js"
+      href="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.12a66c28dfec2bca8613.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -81,13 +81,13 @@
       src="/_next/static/runtime/polyfills-e77205bd3f87781c0279.js"
     ></script>
     <script
-      src="/_next/static/runtime/main-4acf5af77a3955aa98db.js"
+      src="/_next/static/runtime/main-ba5b6ced9961fae765a4.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/runtime/main-b3469e24ceb470ee7a74.module.js"
+      src="/_next/static/runtime/main-3ded133333b846351ff5.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
@@ -117,13 +117,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.187255446fb79c601a31.js"
+      src="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.15dc873ded6079014588.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.7b7753d866184925532f.module.js"
+      src="/_next/static/chunks/19b7e98f51cc0d86c45d01159bbbfb942bfe49b8.12a66c28dfec2bca8613.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/basepath-404-url Change
buildDuration 10.5s 11.3s ⚠️ +758ms
nodeModulesSize 66 MB 66 MB ⚠️ +544 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/basepath-404-url Change
main-HASH.js gzip 6.59 kB 6.63 kB ⚠️ +40 B
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..b4c5.js gzip 10.7 kB N/A N/A
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
19b7e98f51cc..18e4.js gzip N/A 10.7 kB N/A
Overall change 57.2 kB 57.2 kB ⚠️ +37 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/basepath-404-url Change
main-HASH.module.js gzip 5.68 kB 5.71 kB ⚠️ +39 B
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.09 kB N/A N/A
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
19b7e98f51cc..dule.js gzip N/A 7.09 kB N/A
Overall change 52.7 kB 52.7 kB ⚠️ +37 B
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/basepath-404-url Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/basepath-404-url Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js fix/basepath-404-url Change
_error.js 876 kB 876 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 876 kB 876 kB ✓
link.js 916 kB 916 kB ✓
routerDirect.js 908 kB 908 kB ✓
withRouter.js 908 kB 908 kB ✓
Overall change 4.49 MB 4.49 MB ✓
Commit: 2bf5455

@timneutkens timneutkens merged commit a0c6832 into vercel:canary Jul 2, 2020
@timneutkens timneutkens deleted the fix/basepath-404-url branch July 2, 2020 09:12
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@ijjk @kodiakhq @rokinsky
Fix URL being updated with basePath for 404 page (vercel#14740)
9708532 
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@tm1000 tm1000 mentioned this pull request Aug 5, 2020
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The URL should not be updated for the 404 page when using basePath
3 participants
@ijjk @Timer @timneutkens