Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up plugins #14676

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Clean up plugins #14676

merged 1 commit into from
Jun 29, 2020

Conversation

timneutkens
Copy link
Member

Preparation for a larger rewrite

@timneutkens
Clean up plugins
bff2771 
Preparation for a larger rewrite
@ijjk
Copy link
Member

ijjk commented Jun 29, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/clean-up-plugins Change
buildDuration 10.7s 10.2s -584ms
nodeModulesSize 67.1 MB 67.1 MB -2.69 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/clean-up-plugins Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.706 1.635 -0.07
/ avg req/sec 1465.72 1528.73 +63.01
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 0.935 1.013 ⚠️ +0.08
/error-in-render avg req/sec 2673.63 2467.7 ⚠️ -205.93
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/clean-up-plugins Change
main-HASH.js gzip 6.51 kB 6.51 kB -4 B
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..558d.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.1 kB 57.1 kB -4 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/clean-up-plugins Change
main-HASH.module.js gzip 5.59 kB 5.59 kB -2 B
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.08 kB 7.08 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.6 kB 52.6 kB -2 B
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/clean-up-plugins Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/clean-up-plugins Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/clean-up-plugins Change
index.html gzip 954 B 954 B ✓
link.html gzip 959 B 959 B ✓
withRouter.html gzip 947 B 946 B -1 B
Overall change 2.86 kB 2.86 kB -1 B

Diffs

Diff for main-HASH.js 
@@ -247,12 +247,12 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
         "default"
       ] = exports.emitter = exports.router = exports.version = void 0;
 
-      var _extends2 = _interopRequireDefault(__webpack_require__("pVnL"));
-
       var _interopRequireWildcard2 = _interopRequireDefault(
         __webpack_require__("284h")
       );
 
+      var _extends2 = _interopRequireDefault(__webpack_require__("pVnL"));
+
       var _router = __webpack_require__("nOHt");
 
       var _querystring = __webpack_require__("s4NR");
@@ -371,10 +371,7 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
           {
             key: "componentDidMount",
             value: function componentDidMount() {
-              this.scrollToHash();
-
-              if (false) {
-              } // We need to replace the router state if:
+              this.scrollToHash(); // We need to replace the router state if:
               // - the page was (auto) exported and has a query string or search (hash)
               // - it was auto exported and is a dynamic route (to provide params)
               // - if it is a client-side skeleton (fallback render)
Diff for main-HASH.module.js 
@@ -165,12 +165,12 @@
       exports.renderError = renderError;
       exports.default = exports.emitter = exports.router = exports.version = void 0;
 
-      var _extends2 = _interopRequireDefault(__webpack_require__("pVnL"));
-
       var _interopRequireWildcard2 = _interopRequireDefault(
         __webpack_require__("284h")
       );
 
+      var _extends2 = _interopRequireDefault(__webpack_require__("pVnL"));
+
       var _router = __webpack_require__("nOHt");
 
       var _querystring = __webpack_require__("s4NR");
@@ -267,10 +267,7 @@
         }
 
         componentDidMount() {
-          this.scrollToHash();
-
-          if (false) {
-          } // We need to replace the router state if:
+          this.scrollToHash(); // We need to replace the router state if:
           // - the page was (auto) exported and has a query string or search (hash)
           // - it was auto exported and is a dynamic route (to provide params)
           // - if it is a client-side skeleton (fallback render)
Diff for index.html 
@@ -6,7 +6,7 @@
     <meta name="next-head-count" content="2" />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-fd17916cd0614b81f6d3.module.js"
+      href="/_next/static/runtime/main-9ec4f16ab966aac3b436.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -81,13 +81,13 @@
       src="/_next/static/runtime/polyfills-e77205bd3f87781c0279.js"
     ></script>
     <script
-      src="/_next/static/runtime/main-9af73f4e48de86eb2a2a.js"
+      src="/_next/static/runtime/main-e535c7ca56db95621a7e.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/runtime/main-fd17916cd0614b81f6d3.module.js"
+      src="/_next/static/runtime/main-9ec4f16ab966aac3b436.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -6,7 +6,7 @@
     <meta name="next-head-count" content="2" />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-fd17916cd0614b81f6d3.module.js"
+      href="/_next/static/runtime/main-9ec4f16ab966aac3b436.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -86,13 +86,13 @@
       src="/_next/static/runtime/polyfills-e77205bd3f87781c0279.js"
     ></script>
     <script
-      src="/_next/static/runtime/main-9af73f4e48de86eb2a2a.js"
+      src="/_next/static/runtime/main-e535c7ca56db95621a7e.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/runtime/main-fd17916cd0614b81f6d3.module.js"
+      src="/_next/static/runtime/main-9ec4f16ab966aac3b436.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -6,7 +6,7 @@
     <meta name="next-head-count" content="2" />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-fd17916cd0614b81f6d3.module.js"
+      href="/_next/static/runtime/main-9ec4f16ab966aac3b436.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -81,13 +81,13 @@
       src="/_next/static/runtime/polyfills-e77205bd3f87781c0279.js"
     ></script>
     <script
-      src="/_next/static/runtime/main-9af73f4e48de86eb2a2a.js"
+      src="/_next/static/runtime/main-e535c7ca56db95621a7e.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/runtime/main-fd17916cd0614b81f6d3.module.js"
+      src="/_next/static/runtime/main-9ec4f16ab966aac3b436.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/clean-up-plugins Change
buildDuration 10.3s 10.2s -127ms
nodeModulesSize 67.1 MB 67.1 MB -2.69 kB
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/clean-up-plugins Change
main-HASH.js gzip 6.51 kB 6.51 kB -4 B
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..558d.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.1 kB 57.1 kB -4 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/clean-up-plugins Change
main-HASH.module.js gzip 5.59 kB 5.59 kB -2 B
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.08 kB 7.08 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.6 kB 52.6 kB -2 B
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/clean-up-plugins Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/clean-up-plugins Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/clean-up-plugins Change
_error.js 875 kB 875 kB -158 B
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 876 kB 876 kB -158 B
link.js 916 kB 916 kB -158 B
routerDirect.js 908 kB 908 kB -158 B
withRouter.js 908 kB 908 kB -158 B
Overall change 4.49 MB 4.49 MB -790 B
Commit: bff2771

@kodiakhq kodiakhq bot merged commit 327f6ee into vercel:canary Jun 29, 2020
@timneutkens timneutkens deleted the fix/clean-up-plugins branch June 29, 2020 14:59
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@timneutkens @rokinsky
Clean up plugins (vercel#14676)
6b9d918 
Preparation for a larger rewrite
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timneutkens @ijjk @Timer