Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove next-cookies and prop-types #14579

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

matamatanot
Copy link
Contributor

And update dependancies.

@ijjk ijjk added the examples Issue was opened via the examples template. label Jun 26, 2020
@ijjk
Copy link
Member

ijjk commented Jun 26, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary matamatanot/next.js remove-next-cookies Change
buildDuration 12.4s 12.6s ⚠️ +165ms
nodeModulesSize 67.1 MB 67.1 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary matamatanot/next.js remove-next-cookies Change
/ failed reqs 0 0
/ total time (seconds) 2.034 2.048 ⚠️ +0.01
/ avg req/sec 1228.94 1220.52 -8.42
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.256 1.4 ⚠️ +0.14
/error-in-render avg req/sec 1989.81 1785.17 -204.64
Client Bundles (main, webpack, commons)
vercel/next.js canary matamatanot/next.js remove-next-cookies Change
main-HASH.js gzip 6.51 kB 6.51 kB
webpack-HASH.js gzip 751 B 751 B
19b7e98f51cc..558d.js gzip 10.7 kB 10.7 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.1 kB 57.1 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary matamatanot/next.js remove-next-cookies Change
main-HASH.module.js gzip 5.59 kB 5.59 kB
webpack-HASH..dule.js gzip 751 B 751 B
19b7e98f51cc..dule.js gzip 7.08 kB 7.08 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.6 kB 52.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary matamatanot/next.js remove-next-cookies Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Build Manifests
vercel/next.js canary matamatanot/next.js remove-next-cookies Change
_buildManifest.js gzip 268 B 268 B
_buildManife..dule.js gzip 272 B 272 B
Overall change 540 B 540 B
Rendered Page Sizes
vercel/next.js canary matamatanot/next.js remove-next-cookies Change
index.html gzip 955 B 955 B
link.html gzip 959 B 959 B
withRouter.html gzip 946 B 946 B
Overall change 2.86 kB 2.86 kB

Serverless Mode
General
vercel/next.js canary matamatanot/next.js remove-next-cookies Change
buildDuration 13.1s 13.3s ⚠️ +126ms
nodeModulesSize 67.1 MB 67.1 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary matamatanot/next.js remove-next-cookies Change
main-HASH.js gzip 6.51 kB 6.51 kB
webpack-HASH.js gzip 751 B 751 B
19b7e98f51cc..558d.js gzip 10.7 kB 10.7 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.1 kB 57.1 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary matamatanot/next.js remove-next-cookies Change
main-HASH.module.js gzip 5.59 kB 5.59 kB
webpack-HASH..dule.js gzip 751 B 751 B
19b7e98f51cc..dule.js gzip 7.08 kB 7.08 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.6 kB 52.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary matamatanot/next.js remove-next-cookies Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Build Manifests
vercel/next.js canary matamatanot/next.js remove-next-cookies Change
_buildManifest.js gzip 268 B 268 B
_buildManife..dule.js gzip 272 B 272 B
Overall change 540 B 540 B
Serverless bundles
vercel/next.js canary matamatanot/next.js remove-next-cookies Change
_error.js 875 kB 875 kB
404.html 4.17 kB 4.17 kB
hooks.html 3.79 kB 3.79 kB
index.js 876 kB 876 kB
link.js 916 kB 916 kB
routerDirect.js 908 kB 908 kB
withRouter.js 908 kB 908 kB
Overall change 4.49 MB 4.49 MB
Commit: 965a969

@timneutkens timneutkens merged commit 87bb11c into vercel:canary Jun 26, 2020
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants