Remove buildId from server-side files #14413

timneutkens · 2020-06-21T15:54:19Z

Gets rid of the custom function for naming files by removing buildId from the file paths.

…d-from-server-bundles

…imneutkens/next.js into add/remove-buildid-from-server-bundles

ijjk · 2020-06-22T20:40:33Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-from-server-bundles	Change
buildDuration	11.3s	10.8s	-525ms
nodeModulesSize	67.1 MB	67.1 MB	-505 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-from-server-bundles	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.918	2.062	⚠️ +0.14
/ avg req/sec	1303.35	1212.39	-90.96
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.3	1.351	⚠️ +0.05
/error-in-render avg req/sec	1923.68	1850.26	-73.42

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-from-server-bundles	Change
main-HASH.js gzip	6.52 kB	6.52 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
19b7e98f51cc..62e5.js gzip	10.6 kB	10.6 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-from-server-bundles	Change
main-HASH.module.js gzip	5.61 kB	5.61 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
19b7e98f51cc..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-from-server-bundles	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-from-server-bundles	Change
_buildManifest.js gzip	267 B	267 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	539 B	539 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-from-server-bundles	Change
index.html gzip	956 B	956 B	✓
link.html gzip	962 B	962 B	✓
withRouter.html gzip	946 B	946 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-from-server-bundles	Change
buildDuration	11.8s	11.9s	⚠️ +31ms
nodeModulesSize	67.1 MB	67.1 MB	-505 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-from-server-bundles	Change
main-HASH.js gzip	6.52 kB	6.52 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
19b7e98f51cc..62e5.js gzip	10.6 kB	10.6 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-from-server-bundles	Change
main-HASH.module.js gzip	5.61 kB	5.61 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
19b7e98f51cc..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-from-server-bundles	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-from-server-bundles	Change
_buildManifest.js gzip	267 B	267 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	539 B	539 B	✓

Serverless bundles

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-from-server-bundles	Change
_error.js	875 kB	875 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	875 kB	875 kB	✓
link.js	914 kB	914 kB	✓
routerDirect.js	906 kB	906 kB	✓
withRouter.js	906 kB	906 kB	✓
Overall change	4.48 MB	4.48 MB	✓

Commit: 0c70493

ijjk · 2020-06-22T21:04:51Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-from-server-bundles	Change
buildDuration	14.4s	14.9s	⚠️ +531ms
nodeModulesSize	67.1 MB	67.1 MB	-505 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-from-server-bundles	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.484	2.513	⚠️ +0.03
/ avg req/sec	1006.44	994.65	-11.79
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.6	1.819	⚠️ +0.22
/error-in-render avg req/sec	1562.98	1374.63	-188.35

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-from-server-bundles	Change
main-HASH.js gzip	6.52 kB	6.52 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
19b7e98f51cc..62e5.js gzip	10.6 kB	10.6 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-from-server-bundles	Change
main-HASH.module.js gzip	5.61 kB	5.61 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
19b7e98f51cc..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-from-server-bundles	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-from-server-bundles	Change
_buildManifest.js gzip	267 B	267 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	539 B	539 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-from-server-bundles	Change
index.html gzip	956 B	956 B	✓
link.html gzip	962 B	962 B	✓
withRouter.html gzip	946 B	946 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-from-server-bundles	Change
buildDuration	13s	11.9s	-1.1s
nodeModulesSize	67.1 MB	67.1 MB	-505 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-from-server-bundles	Change
main-HASH.js gzip	6.52 kB	6.52 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
19b7e98f51cc..62e5.js gzip	10.6 kB	10.6 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-from-server-bundles	Change
main-HASH.module.js gzip	5.61 kB	5.61 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
19b7e98f51cc..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-from-server-bundles	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-from-server-bundles	Change
_buildManifest.js gzip	267 B	267 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	539 B	539 B	✓

Serverless bundles

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-from-server-bundles	Change
_error.js	875 kB	875 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	875 kB	875 kB	✓
link.js	914 kB	914 kB	✓
routerDirect.js	906 kB	906 kB	✓
withRouter.js	906 kB	906 kB	✓
Overall change	4.48 MB	4.48 MB	✓

Commit: 5602fb5

Janpot · 2020-06-23T07:19:15Z

packages/next/next-server/server/get-route-from-entrypoint.ts

@@ -19,12 +19,10 @@ function matchBundle(regex: RegExp, input: string): string | null {

 export default function getRouteFromEntrypoint(
  entryFile: string,
-  isServerlessLike: boolean = false
+  // TODO: Remove this parameter


Gets rid of the custom function for naming files by removing buildId from the file paths.

Remove buildId from server-side files

49c096b

timneutkens requested review from ijjk, lfades and Timer as code owners June 21, 2020 15:54

ijjk added the type: next label Jun 21, 2020

timneutkens added 8 commits June 21, 2020 19:07

Bring back parameter temporarily

4dd78ac

Move 404 page with _app test into separate suite

3e3cad1

Use helper instead of using buildId

b2914d9

Use helper instead of buildId

25b7560

Update to use helper instead of buildId

5b652a7

Update chunking tests to no longer rely on buildId

40049e4

Update builtServerPagesDir to reflect path changes

4a9f1cd

Add todo for @ijjk

6a5cea3

timneutkens marked this pull request as draft June 21, 2020 21:55

Remove skip

752ce6c