Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change authors member and links #14367

Merged
merged 2 commits into from
Jul 5, 2020
Merged

Change authors member and links #14367

merged 2 commits into from
Jul 5, 2020

Conversation

matamatanot
Copy link
Contributor

If you are already logged in, Vercel Link will take you to your dashboard.
It looks like Tony Kovanen has already on another team.

I respect Vercel member's intention.

@ijjk
Copy link
Member

ijjk commented Jun 19, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
buildDuration 13.7s 13.5s -182ms
nodeModulesSize 67 MB 67 MB -35 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.406 2.438 ⚠️ +0.03
/ avg req/sec 1038.93 1025.59 -13.34
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.601 1.734 ⚠️ +0.13
/error-in-render avg req/sec 1561.11 1441.55 -119.56
Client Bundles (main, webpack, commons)
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
main-HASH.js gzip 6.51 kB 6.51 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..4dd5.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
main-HASH.module.js gzip 5.6 kB 5.6 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
_error.js gzip 3.37 kB 3.37 kB ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
hooks.js gzip 881 B 881 B ✓
_app.js gzip 1.26 kB 1.26 kB ✓
Overall change 8.34 kB 8.34 kB ✓
Client Pages Modern
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
index.module.js gzip 223 B 223 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
hooks.module.js gzip 383 B 383 B ✓
_error.module.js gzip 2.21 kB 2.21 kB ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
_app.module.js gzip 604 B 604 B ✓
Overall change 5.49 kB 5.49 kB ✓
Client Build Manifests
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
_buildManifest.js gzip 270 B 270 B ✓
_buildManife..dule.js gzip 274 B 274 B ✓
Overall change 544 B 544 B ✓
Rendered Page Sizes
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
index.html gzip 953 B 953 B ✓
link.html gzip 960 B 960 B ✓
withRouter.html gzip 947 B 947 B ✓
Overall change 2.86 kB 2.86 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
buildDuration 14.5s 15.7s ⚠️ +1.2s
nodeModulesSize 67 MB 67 MB -35 B
Client Bundles (main, webpack, commons)
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
main-HASH.js gzip 6.51 kB 6.51 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..4dd5.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
main-HASH.module.js gzip 5.6 kB 5.6 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
_error.js gzip 3.37 kB 3.37 kB ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
hooks.js gzip 881 B 881 B ✓
_app.js gzip 1.26 kB 1.26 kB ✓
Overall change 8.34 kB 8.34 kB ✓
Client Pages Modern
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
index.module.js gzip 223 B 223 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
hooks.module.js gzip 383 B 383 B ✓
_error.module.js gzip 2.21 kB 2.21 kB ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
_app.module.js gzip 604 B 604 B ✓
Overall change 5.49 kB 5.49 kB ✓
Client Build Manifests
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
_buildManifest.js gzip 270 B 270 B ✓
_buildManife..dule.js gzip 274 B 274 B ✓
Overall change 544 B 544 B ✓
Serverless bundles
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
_error.js 875 kB 875 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 875 kB 875 kB ✓
link.js 914 kB 914 kB ✓
routerDirect.js 906 kB 906 kB ✓
withRouter.js 906 kB 906 kB ✓
Overall change 4.48 MB 4.48 MB ✓
Commit: ce56474

lfades
lfades requested changes Jun 19, 2020
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but Tony has to stay in authors.

@matamatanot
Copy link
Contributor Author

@lfades
Is he still enrolled in Vercel? I cannot find about page.

@ijjk
Copy link
Member

ijjk commented Jun 20, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
buildDuration 11.8s 12s ⚠️ +181ms
nodeModulesSize 67 MB 67 MB ⚠️ +63 B
Page Load Tests Overall increase ✓
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.104 2.159 ⚠️ +0.05
/ avg req/sec 1188.35 1157.73 -30.62
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.428 1.378 -0.05
/error-in-render avg req/sec 1750.85 1813.57 ⚠️ +62.72
Client Bundles (main, webpack, commons)
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
main-HASH.js gzip 6.51 kB 6.51 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..75a9.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
main-HASH.module.js gzip 5.6 kB 5.6 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
_error.js gzip 3.37 kB 3.37 kB ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
hooks.js gzip 881 B 881 B ✓
_app.js gzip 1.26 kB 1.26 kB ✓
Overall change 8.34 kB 8.34 kB ✓
Client Pages Modern
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
index.module.js gzip 223 B 223 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
hooks.module.js gzip 383 B 383 B ✓
_error.module.js gzip 2.21 kB 2.21 kB ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
_app.module.js gzip 604 B 604 B ✓
Overall change 5.49 kB 5.49 kB ✓
Client Build Manifests
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
_buildManifest.js gzip 270 B 270 B ✓
_buildManife..dule.js gzip 274 B 274 B ✓
Overall change 544 B 544 B ✓
Rendered Page Sizes
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
index.html gzip 955 B 955 B ✓
link.html gzip 961 B 961 B ✓
withRouter.html gzip 948 B 948 B ✓
Overall change 2.86 kB 2.86 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
buildDuration 12.9s 12.7s -205ms
nodeModulesSize 67 MB 67 MB ⚠️ +63 B
Client Bundles (main, webpack, commons)
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
main-HASH.js gzip 6.51 kB 6.51 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..75a9.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
main-HASH.module.js gzip 5.6 kB 5.6 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
_error.js gzip 3.37 kB 3.37 kB ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
hooks.js gzip 881 B 881 B ✓
_app.js gzip 1.26 kB 1.26 kB ✓
Overall change 8.34 kB 8.34 kB ✓
Client Pages Modern
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
index.module.js gzip 223 B 223 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
hooks.module.js gzip 383 B 383 B ✓
_error.module.js gzip 2.21 kB 2.21 kB ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
_app.module.js gzip 604 B 604 B ✓
Overall change 5.49 kB 5.49 kB ✓
Client Build Manifests
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
_buildManifest.js gzip 270 B 270 B ✓
_buildManife..dule.js gzip 274 B 274 B ✓
Overall change 544 B 544 B ✓
Serverless bundles
vercel/next.js canary matamatanot/next.js memberTeamLinks Change
_error.js 875 kB 875 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 875 kB 875 kB ✓
link.js 914 kB 914 kB ✓
routerDirect.js 906 kB 906 kB ✓
withRouter.js 906 kB 906 kB ✓
Overall change 4.48 MB 4.48 MB ✓
Commit: 2a9b017

@timneutkens timneutkens merged commit 62ef872 into vercel:canary Jul 5, 2020
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@matamatanot @rokinsky
Change authors member and links (vercel#14367)
3e31795
@matamatanot matamatanot deleted the memberTeamLinks branch October 30, 2021 09:54
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfades lfades lfades requested changes

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matamatanot @ijjk @lfades @timneutkens