Warn/revert custom devtool in development mode #14285

jamesmosier · 2020-06-17T20:05:52Z

Warn users and revert their devtool when they manually change the devtool in development mode. For this addition, I check to ensure the devtool is custom (i.e. different than what is set by Next) and has a value (false is fine as a custom devtool!).

As described in this issue (13963), changing the devtool in development mode can cause issues with performance.

Fixes #13963

ijjk · 2020-06-17T20:14:22Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
buildDuration	11.9s	12.4s	⚠️ +531ms
nodeModulesSize	67 MB	67 MB	⚠️ +1.09 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.01	2.011	0
/ avg req/sec	1243.65	1243.28	-0.37
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.201	1.2	0
/error-in-render avg req/sec	2082.11	2082.64	⚠️ +0.53

Client Bundles (main, webpack, commons)

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
main-HASH.js gzip	6.51 kB	6.51 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..4dd5.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
main-HASH.module.js gzip	5.6 kB	5.6 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.92 kB	6.92 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
_error.js gzip	3.37 kB	3.37 kB	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
hooks.js gzip	881 B	881 B	✓
_app.js gzip	1.26 kB	1.26 kB	✓
Overall change	8.34 kB	8.34 kB	✓

Client Pages Modern

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
index.module.js gzip	223 B	223 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
hooks.module.js gzip	383 B	383 B	✓
_error.module.js gzip	2.21 kB	2.21 kB	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
_app.module.js gzip	604 B	604 B	✓
Overall change	5.49 kB	5.49 kB	✓

Client Build Manifests

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
_buildManifest.js gzip	270 B	270 B	✓
_buildManife..dule.js gzip	274 B	274 B	✓
Overall change	544 B	544 B	✓

Rendered Page Sizes

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
index.html gzip	953 B	953 B	✓
link.html gzip	960 B	960 B	✓
withRouter.html gzip	947 B	947 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
buildDuration	12.8s	12.8s	⚠️ +35ms
nodeModulesSize	67 MB	67 MB	⚠️ +1.09 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
main-HASH.js gzip	6.51 kB	6.51 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..4dd5.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
main-HASH.module.js gzip	5.6 kB	5.6 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.92 kB	6.92 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
_error.js gzip	3.37 kB	3.37 kB	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
hooks.js gzip	881 B	881 B	✓
_app.js gzip	1.26 kB	1.26 kB	✓
Overall change	8.34 kB	8.34 kB	✓

Client Pages Modern

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
index.module.js gzip	223 B	223 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
hooks.module.js gzip	383 B	383 B	✓
_error.module.js gzip	2.21 kB	2.21 kB	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
_app.module.js gzip	604 B	604 B	✓
Overall change	5.49 kB	5.49 kB	✓

Client Build Manifests

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
_buildManifest.js gzip	270 B	270 B	✓
_buildManife..dule.js gzip	274 B	274 B	✓
Overall change	544 B	544 B	✓

Serverless bundles

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
_error.js	875 kB	875 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	875 kB	875 kB	✓
link.js	914 kB	914 kB	✓
routerDirect.js	906 kB	906 kB	✓
withRouter.js	906 kB	906 kB	✓
Overall change	4.48 MB	4.48 MB	✓

packages/next/build/webpack-config.ts

Co-authored-by: Tim Neutkens <[email protected]>

ijjk · 2020-06-18T13:25:51Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
buildDuration	12s	11.6s	-469ms
nodeModulesSize	67 MB	67 MB	⚠️ +1.09 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.962	1.972	⚠️ +0.01
/ avg req/sec	1274.29	1267.94	-6.35
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.202	1.229	⚠️ +0.03
/error-in-render avg req/sec	2080.49	2033.74	-46.75

Client Bundles (main, webpack, commons)

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
main-HASH.js gzip	6.51 kB	6.51 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..4dd5.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
main-HASH.module.js gzip	5.6 kB	5.6 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.92 kB	6.92 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
_error.js gzip	3.37 kB	3.37 kB	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
hooks.js gzip	881 B	881 B	✓
_app.js gzip	1.26 kB	1.26 kB	✓
Overall change	8.34 kB	8.34 kB	✓

Client Pages Modern

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
index.module.js gzip	223 B	223 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
hooks.module.js gzip	383 B	383 B	✓
_error.module.js gzip	2.21 kB	2.21 kB	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
_app.module.js gzip	604 B	604 B	✓
Overall change	5.49 kB	5.49 kB	✓

Client Build Manifests

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
_buildManifest.js gzip	270 B	270 B	✓
_buildManife..dule.js gzip	274 B	274 B	✓
Overall change	544 B	544 B	✓

Rendered Page Sizes

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
index.html gzip	953 B	953 B	✓
link.html gzip	960 B	960 B	✓
withRouter.html gzip	947 B	947 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
buildDuration	12.8s	12.5s	-272ms
nodeModulesSize	67 MB	67 MB	⚠️ +1.09 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
main-HASH.js gzip	6.51 kB	6.51 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..4dd5.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
main-HASH.module.js gzip	5.6 kB	5.6 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.92 kB	6.92 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
_error.js gzip	3.37 kB	3.37 kB	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
hooks.js gzip	881 B	881 B	✓
_app.js gzip	1.26 kB	1.26 kB	✓
Overall change	8.34 kB	8.34 kB	✓

Client Pages Modern

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
index.module.js gzip	223 B	223 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
hooks.module.js gzip	383 B	383 B	✓
_error.module.js gzip	2.21 kB	2.21 kB	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
_app.module.js gzip	604 B	604 B	✓
Overall change	5.49 kB	5.49 kB	✓

Client Build Manifests

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
_buildManifest.js gzip	270 B	270 B	✓
_buildManife..dule.js gzip	274 B	274 B	✓
Overall change	544 B	544 B	✓

Serverless bundles

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
_error.js	875 kB	875 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	875 kB	875 kB	✓
link.js	914 kB	914 kB	✓
routerDirect.js	906 kB	906 kB	✓
withRouter.js	906 kB	906 kB	✓
Overall change	4.48 MB	4.48 MB	✓

ijjk · 2020-06-18T13:31:49Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
buildDuration	12s	12.8s	⚠️ +819ms
nodeModulesSize	67 MB	67 MB	⚠️ +1.09 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.041	2.086	⚠️ +0.04
/ avg req/sec	1224.66	1198.38	-26.28
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.24	1.236	0
/error-in-render avg req/sec	2016.83	2022.47	⚠️ +5.64

Client Bundles (main, webpack, commons)

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
main-HASH.js gzip	6.51 kB	6.51 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..4dd5.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
main-HASH.module.js gzip	5.6 kB	5.6 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.92 kB	6.92 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
_error.js gzip	3.37 kB	3.37 kB	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
hooks.js gzip	881 B	881 B	✓
_app.js gzip	1.26 kB	1.26 kB	✓
Overall change	8.34 kB	8.34 kB	✓

Client Pages Modern

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
index.module.js gzip	223 B	223 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
hooks.module.js gzip	383 B	383 B	✓
_error.module.js gzip	2.21 kB	2.21 kB	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
_app.module.js gzip	604 B	604 B	✓
Overall change	5.49 kB	5.49 kB	✓

Client Build Manifests

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
_buildManifest.js gzip	270 B	270 B	✓
_buildManife..dule.js gzip	274 B	274 B	✓
Overall change	544 B	544 B	✓

Rendered Page Sizes

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
index.html gzip	953 B	953 B	✓
link.html gzip	960 B	960 B	✓
withRouter.html gzip	947 B	947 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
buildDuration	13s	13.1s	⚠️ +64ms
nodeModulesSize	67 MB	67 MB	⚠️ +1.09 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
main-HASH.js gzip	6.51 kB	6.51 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..4dd5.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
main-HASH.module.js gzip	5.6 kB	5.6 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.92 kB	6.92 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
_error.js gzip	3.37 kB	3.37 kB	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
hooks.js gzip	881 B	881 B	✓
_app.js gzip	1.26 kB	1.26 kB	✓
Overall change	8.34 kB	8.34 kB	✓

Client Pages Modern

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
index.module.js gzip	223 B	223 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
hooks.module.js gzip	383 B	383 B	✓
_error.module.js gzip	2.21 kB	2.21 kB	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
_app.module.js gzip	604 B	604 B	✓
Overall change	5.49 kB	5.49 kB	✓

Client Build Manifests

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
_buildManifest.js gzip	270 B	270 B	✓
_buildManife..dule.js gzip	274 B	274 B	✓
Overall change	544 B	544 B	✓

Serverless bundles

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
_error.js	875 kB	875 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	875 kB	875 kB	✓
link.js	914 kB	914 kB	✓
routerDirect.js	906 kB	906 kB	✓
withRouter.js	906 kB	906 kB	✓
Overall change	4.48 MB	4.48 MB	✓

packages/next/build/webpack-config.ts

ijjk · 2020-06-22T13:43:05Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
buildDuration	11.9s	11.8s	-69ms
nodeModulesSize	67 MB	67 MB	⚠️ +1.34 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.995	2.017	⚠️ +0.02
/ avg req/sec	1253.38	1239.2	-14.18
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.164	1.158	-0.01
/error-in-render avg req/sec	2148.17	2158.67	⚠️ +10.5

Client Bundles (main, webpack, commons)

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
main-HASH.js gzip	6.54 kB	6.54 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
19b7e98f51cc..33d5.js gzip	10.6 kB	10.6 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
main-HASH.module.js gzip	5.62 kB	5.62 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
19b7e98f51cc..dule.js gzip	6.94 kB	6.94 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Build Manifests

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
_buildManifest.js gzip	267 B	267 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	539 B	539 B	✓

Rendered Page Sizes

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
index.html gzip	954 B	954 B	✓
link.html gzip	959 B	959 B	✓
withRouter.html gzip	946 B	946 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
buildDuration	12.6s	12.6s	⚠️ +6ms
nodeModulesSize	67 MB	67 MB	⚠️ +1.34 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
main-HASH.js gzip	6.54 kB	6.54 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
19b7e98f51cc..33d5.js gzip	10.6 kB	10.6 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
main-HASH.module.js gzip	5.62 kB	5.62 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
19b7e98f51cc..dule.js gzip	6.94 kB	6.94 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Build Manifests

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
_buildManifest.js gzip	267 B	267 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	539 B	539 B	✓

Serverless bundles

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
_error.js	875 kB	875 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	875 kB	875 kB	✓
link.js	914 kB	914 kB	✓
routerDirect.js	906 kB	906 kB	✓
withRouter.js	906 kB	906 kB	✓
Overall change	4.48 MB	4.48 MB	✓

Commit: 7c06ee0

packages/next/build/webpack-config.ts

test/integration/config-devtool-dev/test/index.test.js

packages/next/build/webpack-config.ts

Co-authored-by: Joe Haddad <[email protected]>

Timer

Thanks!

ijjk · 2020-06-24T04:02:51Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
buildDuration	10.9s	11.1s	⚠️ +252ms
nodeModulesSize	67.1 MB	67.1 MB	⚠️ +1.67 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.823	1.879	⚠️ +0.06
/ avg req/sec	1371.06	1330.55	-40.51
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.119	1.082	-0.04
/error-in-render avg req/sec	2233.58	2309.96	⚠️ +76.38

Client Bundles (main, webpack, commons)

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
main-HASH.js gzip	6.49 kB	6.49 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
19b7e98f51cc..14a7.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.1 kB	57.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
main-HASH.module.js gzip	5.57 kB	5.57 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
19b7e98f51cc..dule.js gzip	7.07 kB	7.07 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Build Manifests

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
_buildManifest.js gzip	267 B	267 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	539 B	539 B	✓

Rendered Page Sizes

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
index.html gzip	954 B	954 B	✓
link.html gzip	962 B	962 B	✓
withRouter.html gzip	947 B	947 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
buildDuration	13.8s	13.1s	-749ms
nodeModulesSize	67.1 MB	67.1 MB	⚠️ +1.67 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
main-HASH.js gzip	6.49 kB	6.49 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
19b7e98f51cc..14a7.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.1 kB	57.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
main-HASH.module.js gzip	5.57 kB	5.57 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
19b7e98f51cc..dule.js gzip	7.07 kB	7.07 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Build Manifests

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
_buildManifest.js gzip	267 B	267 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	539 B	539 B	✓

Serverless bundles

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
_error.js	875 kB	875 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	876 kB	876 kB	✓
link.js	916 kB	916 kB	✓
routerDirect.js	908 kB	908 kB	✓
withRouter.js	908 kB	908 kB	✓
Overall change	4.49 MB	4.49 MB	✓

Commit: 5a40e5b

ijjk · 2020-06-24T04:08:45Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
buildDuration	12.2s	12.3s	⚠️ +146ms
nodeModulesSize	67.1 MB	67.1 MB	⚠️ +1.67 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.141	2.111	-0.03
/ avg req/sec	1167.71	1184	⚠️ +16.29
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.443	1.384	-0.06
/error-in-render avg req/sec	1732.71	1806.36	⚠️ +73.65

Client Bundles (main, webpack, commons)

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
main-HASH.js gzip	6.49 kB	6.49 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
19b7e98f51cc..14a7.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.1 kB	57.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
main-HASH.module.js gzip	5.57 kB	5.57 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
19b7e98f51cc..dule.js gzip	7.07 kB	7.07 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Build Manifests

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
_buildManifest.js gzip	267 B	267 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	539 B	539 B	✓

Rendered Page Sizes

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
index.html gzip	954 B	954 B	✓
link.html gzip	962 B	962 B	✓
withRouter.html gzip	947 B	947 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
buildDuration	13.4s	13s	-444ms
nodeModulesSize	67.1 MB	67.1 MB	⚠️ +1.67 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
main-HASH.js gzip	6.49 kB	6.49 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
19b7e98f51cc..14a7.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.1 kB	57.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
main-HASH.module.js gzip	5.57 kB	5.57 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
19b7e98f51cc..dule.js gzip	7.07 kB	7.07 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Build Manifests

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
_buildManifest.js gzip	267 B	267 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	539 B	539 B	✓

Serverless bundles

	vercel/next.js canary	jamesmosier/next.js fix/devtool-revert	Change
_error.js	875 kB	875 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	876 kB	876 kB	✓
link.js	916 kB	916 kB	✓
routerDirect.js	908 kB	908 kB	✓
withRouter.js	908 kB	908 kB	✓
Overall change	4.49 MB	4.49 MB	✓

Commit: 2b05d27

Warn users and revert their `devtool` when they manually change the `devtool` in development mode. For this addition, I check to ensure the `devtool` is custom (i.e. different than what is set by Next) and has a value (`false` is fine as a custom `devtool`!). As described in [this issue (13963)](vercel#13963), changing the `devtool` in development mode can cause issues with performance. Fixes vercel#13963

jamesmosier added 2 commits June 16, 2020 19:55

revert devtool in dev mode if user set

81efcea

devtool tests

dd52b07

jamesmosier requested review from ijjk, lfades, Timer and timneutkens as code owners June 17, 2020 20:05

ijjk added the type: next label Jun 17, 2020

timneutkens reviewed Jun 18, 2020

View reviewed changes

packages/next/build/webpack-config.ts Outdated Show resolved Hide resolved

jamesmosier and others added 2 commits June 18, 2020 09:17

update verbiage in warning msg

63d937b

Co-authored-by: Tim Neutkens <[email protected]>

Merge branch 'canary' into fix/devtool-revert

98d9c41

Timer requested changes Jun 22, 2020

View reviewed changes

packages/next/build/webpack-config.ts Outdated Show resolved Hide resolved

packages/next/build/webpack-config.ts Outdated Show resolved Hide resolved

always revert devtool in dev but only log once on server build

7c06ee0

Timer requested changes Jun 22, 2020

View reviewed changes

packages/next/build/webpack-config.ts Outdated Show resolved Hide resolved

test/integration/config-devtool-dev/test/index.test.js Outdated Show resolved Hide resolved

jamesmosier added 2 commits June 22, 2020 16:10

warn once via execOnce 💥

6bb9294

checking for existence of sourcemaps to verify revert

f891b8d

jamesmosier commented Jun 22, 2020

View reviewed changes

packages/next/build/webpack-config.ts Outdated Show resolved Hide resolved

Merge branch 'canary' into fix/devtool-revert

b29948c

Timer requested changes Jun 23, 2020

View reviewed changes

packages/next/build/webpack-config.ts Outdated Show resolved Hide resolved

packages/next/build/webpack-config.ts Outdated Show resolved Hide resolved

jamesmosier and others added 2 commits June 23, 2020 13:00

remove conditional check

b4ebf6b

Co-authored-by: Joe Haddad <[email protected]>

added err.sh page for improper devtool usage

fd1c7ce

ijjk added the type: documentation label Jun 23, 2020

Timer added 5 commits June 23, 2020 23:43

Fix types

f60570c

Better default error

752898e

update tests

9edbaf4

Test with false source map instead

94773d5

Update test

5a40e5b

Timer approved these changes Jun 24, 2020

View reviewed changes

Merge branch 'canary' into fix/devtool-revert

2b05d27

kodiakhq bot merged commit 435bf65 into vercel:canary Jun 24, 2020

jamesmosier deleted the fix/devtool-revert branch December 30, 2021 00:23

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Warn/revert custom devtool in development mode #14285

Warn/revert custom devtool in development mode #14285

jamesmosier commented Jun 17, 2020 •

edited by Timer

Loading

ijjk commented Jun 17, 2020

ijjk commented Jun 18, 2020

ijjk commented Jun 18, 2020

ijjk commented Jun 22, 2020

Timer left a comment

ijjk commented Jun 24, 2020

ijjk commented Jun 24, 2020

Warn/revert custom devtool in development mode #14285

Warn/revert custom devtool in development mode #14285

Conversation

jamesmosier commented Jun 17, 2020 • edited by Timer Loading

ijjk commented Jun 17, 2020

Stats from current PR

ijjk commented Jun 18, 2020

Stats from current PR

ijjk commented Jun 18, 2020

Stats from current PR

ijjk commented Jun 22, 2020

Stats from current PR

Timer left a comment

Choose a reason for hiding this comment

ijjk commented Jun 24, 2020

Stats from current PR

ijjk commented Jun 24, 2020

Stats from current PR

jamesmosier commented Jun 17, 2020 •

edited by Timer

Loading