-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Data Fetching Method #14190
Update Data Fetching Method #14190
Conversation
Stats from current PRDefault Server Mode (Increase detected
|
vercel/next.js canary | MLH-Fellowship/next.js arsalan/41 | Change | |
---|---|---|---|
buildDuration | 14.1s | 13.9s | -188ms |
nodeModulesSize | 65.2 MB | 65.2 MB | ✓ |
Page Load Tests Overall increase ✓
vercel/next.js canary | MLH-Fellowship/next.js arsalan/41 | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.545 | 2.469 | -0.08 |
/ avg req/sec | 982.18 | 1012.62 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.703 | 1.593 | -0.11 |
/error-in-render avg req/sec | 1467.58 | 1569.51 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | MLH-Fellowship/next.js arsalan/41 | Change | |
---|---|---|---|
main-HASH.js gzip | 6.51 kB | 6.51 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..0538.js gzip | 10.5 kB | 10.5 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 56.9 kB | 56.9 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | MLH-Fellowship/next.js arsalan/41 | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.6 kB | 5.6 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..dule.js gzip | 6.93 kB | 6.93 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 52.4 kB | 52.4 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | MLH-Fellowship/next.js arsalan/41 | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
vercel/next.js canary | MLH-Fellowship/next.js arsalan/41 | Change | |
---|---|---|---|
routerDirect.js gzip | 279 B | 279 B | ✓ |
withRouter.js gzip | 278 B | 278 B | ✓ |
_error.js gzip | 3.37 kB | 3.37 kB | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.05 kB | 2.05 kB | ✓ |
hooks.js gzip | 881 B | 881 B | ✓ |
_app.js gzip | 1.26 kB | 1.26 kB | ✓ |
Overall change | 8.34 kB | 8.34 kB | ✓ |
Client Pages Modern
vercel/next.js canary | MLH-Fellowship/next.js arsalan/41 | Change | |
---|---|---|---|
index.module.js gzip | 223 B | 223 B | ✓ |
routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
hooks.module.js gzip | 383 B | 383 B | ✓ |
_error.module.js gzip | 2.21 kB | 2.21 kB | ✓ |
link.module.js gzip | 1.52 kB | 1.52 kB | ✓ |
_app.module.js gzip | 604 B | 604 B | ✓ |
Overall change | 5.49 kB | 5.49 kB | ✓ |
Client Build Manifests
vercel/next.js canary | MLH-Fellowship/next.js arsalan/41 | Change | |
---|---|---|---|
_buildManifest.js gzip | 270 B | 270 B | ✓ |
_buildManife..dule.js gzip | 274 B | 274 B | ✓ |
Overall change | 544 B | 544 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | MLH-Fellowship/next.js arsalan/41 | Change | |
---|---|---|---|
index.html gzip | 956 B | 956 B | ✓ |
link.html gzip | 963 B | 963 B | ✓ |
withRouter.html gzip | 949 B | 949 B | ✓ |
Overall change | 2.87 kB | 2.87 kB | ✓ |
Serverless Mode
General
vercel/next.js canary | MLH-Fellowship/next.js arsalan/41 | Change | |
---|---|---|---|
buildDuration | 15.3s | 15.2s | -152ms |
nodeModulesSize | 65.2 MB | 65.2 MB | ✓ |
Client Bundles (main, webpack, commons)
vercel/next.js canary | MLH-Fellowship/next.js arsalan/41 | Change | |
---|---|---|---|
main-HASH.js gzip | 6.51 kB | 6.51 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..0538.js gzip | 10.5 kB | 10.5 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 56.9 kB | 56.9 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | MLH-Fellowship/next.js arsalan/41 | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.6 kB | 5.6 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..dule.js gzip | 6.93 kB | 6.93 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 52.4 kB | 52.4 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | MLH-Fellowship/next.js arsalan/41 | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
vercel/next.js canary | MLH-Fellowship/next.js arsalan/41 | Change | |
---|---|---|---|
routerDirect.js gzip | 279 B | 279 B | ✓ |
withRouter.js gzip | 278 B | 278 B | ✓ |
_error.js gzip | 3.37 kB | 3.37 kB | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.05 kB | 2.05 kB | ✓ |
hooks.js gzip | 881 B | 881 B | ✓ |
_app.js gzip | 1.26 kB | 1.26 kB | ✓ |
Overall change | 8.34 kB | 8.34 kB | ✓ |
Client Pages Modern
vercel/next.js canary | MLH-Fellowship/next.js arsalan/41 | Change | |
---|---|---|---|
index.module.js gzip | 223 B | 223 B | ✓ |
routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
hooks.module.js gzip | 383 B | 383 B | ✓ |
_error.module.js gzip | 2.21 kB | 2.21 kB | ✓ |
link.module.js gzip | 1.52 kB | 1.52 kB | ✓ |
_app.module.js gzip | 604 B | 604 B | ✓ |
Overall change | 5.49 kB | 5.49 kB | ✓ |
Client Build Manifests
vercel/next.js canary | MLH-Fellowship/next.js arsalan/41 | Change | |
---|---|---|---|
_buildManifest.js gzip | 270 B | 270 B | ✓ |
_buildManife..dule.js gzip | 274 B | 274 B | ✓ |
Overall change | 544 B | 544 B | ✓ |
Serverless bundles
vercel/next.js canary | MLH-Fellowship/next.js arsalan/41 | Change | |
---|---|---|---|
_error.js | 875 kB | 875 kB | ✓ |
404.html | 4.17 kB | 4.17 kB | ✓ |
hooks.html | 3.79 kB | 3.79 kB | ✓ |
index.js | 875 kB | 875 kB | ✓ |
link.js | 913 kB | 913 kB | ✓ |
routerDirect.js | 905 kB | 905 kB | ✓ |
withRouter.js | 905 kB | 905 kB | ✓ |
Overall change | 4.48 MB | 4.48 MB | ✓ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicated of #13887 - The other has not been updated so feel free to keep working on this PR.
I'm going to put the same requested changes from the other PR as they also apply here:
Let's remove getServerSideProps/getInitialProps entirely, we can't use SSG here because the data depends on the user, but SSR is also not necessary so let's do CSR instead, you can use swr for this. Check the other auth examples for more details.
You can use with-passport as a good point of reference.
I didn't know there already exists a PR. I was actually told my Tim about to update it.
I'll update it with swr. |
Replaced getInitialProps with getServerSideProps for with-cookie-auth-fauna