Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link with-polyfills example to updated polyfill docs #13943

Merged
merged 4 commits into from
Jul 25, 2020
Merged

Link with-polyfills example to updated polyfill docs #13943

merged 4 commits into from
Jul 25, 2020

Conversation

karlhorky
Copy link
Contributor

@karlhorky karlhorky commented Jun 9, 2020 •
edited
Loading

Link to the new polyfill docs that @Timer added in #13766.

Please don't merge until the docs from #13766 are deployed!

@ijjk ijjk added the examples Issue was opened via the examples template. label Jun 9, 2020
@karlhorky karlhorky changed the title Link to updated polyfill docs Link with-polyfills example to updated polyfill docs Jun 9, 2020
@karlhorky karlhorky mentioned this pull request Jun 9, 2020
Merged
Timer
Timer requested changes Jun 9, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking as the docs site hasn't been rolled yet (so link 404s), thanks for this tho!

@ijjk
Copy link
Member

ijjk commented Jun 9, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary karlhorky/next.js patch-1 Change
buildDuration 11.6s 13.9s ⚠️ +2.3s
nodeModulesSize 64.9 MB 64.9 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary karlhorky/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.981 2.431 ⚠️ +0.45
/ avg req/sec 1261.93 1028.39 -233.54
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.371 1.51 ⚠️ +0.14
/error-in-render avg req/sec 1823.5 1655.99 -167.51
Client Bundles (main, webpack, commons)
vercel/next.js canary karlhorky/next.js patch-1 Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..ec24.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary karlhorky/next.js patch-1 Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary karlhorky/next.js patch-1 Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary karlhorky/next.js patch-1 Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
vercel/next.js canary karlhorky/next.js patch-1 Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
vercel/next.js canary karlhorky/next.js patch-1 Change
_buildManifest.js gzip 171 B 171 B ✓
_buildManife..dule.js gzip 180 B 180 B ✓
Overall change 351 B 351 B ✓
Rendered Page Sizes
vercel/next.js canary karlhorky/next.js patch-1 Change
index.html gzip 901 B 901 B ✓
link.html gzip 906 B 906 B ✓
withRouter.html gzip 894 B 894 B ✓
Overall change 2.7 kB 2.7 kB ✓
Serverless Mode
General
vercel/next.js canary karlhorky/next.js patch-1 Change
buildDuration 15s 14.7s -217ms
nodeModulesSize 64.9 MB 64.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary karlhorky/next.js patch-1 Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..ec24.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary karlhorky/next.js patch-1 Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary karlhorky/next.js patch-1 Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary karlhorky/next.js patch-1 Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
vercel/next.js canary karlhorky/next.js patch-1 Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
vercel/next.js canary karlhorky/next.js patch-1 Change
_buildManifest.js gzip 171 B 171 B ✓
_buildManife..dule.js gzip 180 B 180 B ✓
Overall change 351 B 351 B ✓
Serverless bundles
vercel/next.js canary karlhorky/next.js patch-1 Change
_error.js 874 kB 874 kB ✓
404.html 4.13 kB 4.13 kB ✓
hooks.html 3.71 kB 3.71 kB ✓
index.js 875 kB 875 kB ✓
link.js 913 kB 913 kB ✓
routerDirect.js 905 kB 905 kB ✓
withRouter.js 905 kB 905 kB ✓
Overall change 4.48 MB 4.48 MB ✓

@karlhorky
Copy link
Contributor Author

Yeah noticed that, I've now mentioned explicitly in this PR's description.

@ijjk
Copy link
Member

ijjk commented Jun 29, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary ralphilius/next.js patch-1 Change
buildDuration 11.7s 11.8s ⚠️ +143ms
nodeModulesSize 66 MB 66 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ralphilius/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.003 2.097 ⚠️ +0.09
/ avg req/sec 1248.34 1192.2 ⚠️ -56.14
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.387 1.375 -0.01
/error-in-render avg req/sec 1801.84 1817.84 +16
Client Bundles (main, webpack, commons)
vercel/next.js canary ralphilius/next.js patch-1 Change
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..65e3.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ralphilius/next.js patch-1 Change
main-HASH.module.js gzip 5.68 kB 5.68 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.08 kB 7.08 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ralphilius/next.js patch-1 Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Build Manifests
vercel/next.js canary ralphilius/next.js patch-1 Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Rendered Page Sizes
vercel/next.js canary ralphilius/next.js patch-1 Change
index.html gzip 951 B 951 B ✓
link.html gzip 956 B 956 B ✓
withRouter.html gzip 944 B 944 B ✓
Overall change 2.85 kB 2.85 kB ✓
Serverless Mode
General
vercel/next.js canary ralphilius/next.js patch-1 Change
buildDuration 12.7s 12.9s ⚠️ +224ms
nodeModulesSize 66 MB 66 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary ralphilius/next.js patch-1 Change
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..65e3.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ralphilius/next.js patch-1 Change
main-HASH.module.js gzip 5.68 kB 5.68 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.08 kB 7.08 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ralphilius/next.js patch-1 Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Build Manifests
vercel/next.js canary ralphilius/next.js patch-1 Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Serverless bundles
vercel/next.js canary ralphilius/next.js patch-1 Change
_error.js 875 kB 875 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 876 kB 876 kB ✓
link.js 915 kB 915 kB ✓
routerDirect.js 907 kB 907 kB ✓
withRouter.js 907 kB 907 kB ✓
Overall change 4.49 MB 4.49 MB ✓
Commit: 531b39b

@ijjk
Copy link
Member

ijjk commented Jul 13, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary abhik-b/next.js patch-1 Change
buildDuration 13s 13.1s ⚠️ +77ms
nodeModulesSize 66.5 MB 66.5 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary abhik-b/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.264 2.296 ⚠️ +0.03
/ avg req/sec 1104.21 1088.94 ⚠️ -15.27
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.537 1.552 ⚠️ +0.02
/error-in-render avg req/sec 1627.04 1611.27 ⚠️ -15.77
Client Bundles (main, webpack, commons)
vercel/next.js canary abhik-b/next.js patch-1 Change
main-HASH.js gzip 6.72 kB 6.72 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..cead.js gzip 9.77 kB 9.77 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.4 kB 56.4 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary abhik-b/next.js patch-1 Change
main-HASH.module.js gzip 5.79 kB 5.79 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 6.17 kB 6.17 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.9 kB 51.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary abhik-b/next.js patch-1 Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB ✓
Overall change 26.4 kB 26.4 kB ✓
Client Build Manifests
vercel/next.js canary abhik-b/next.js patch-1 Change
_buildManifest.js gzip 267 B 267 B ✓
_buildManife..dule.js gzip 273 B 273 B ✓
Overall change 540 B 540 B ✓
Rendered Page Sizes
vercel/next.js canary abhik-b/next.js patch-1 Change
index.html gzip 955 B 955 B ✓
link.html gzip 962 B 962 B ✓
withRouter.html gzip 947 B 947 B ✓
Overall change 2.86 kB 2.86 kB ✓
Serverless Mode
General
vercel/next.js canary abhik-b/next.js patch-1 Change
buildDuration 13.4s 14.7s ⚠️ +1.3s
nodeModulesSize 66.5 MB 66.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary abhik-b/next.js patch-1 Change
main-HASH.js gzip 6.72 kB 6.72 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..cead.js gzip 9.77 kB 9.77 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.4 kB 56.4 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary abhik-b/next.js patch-1 Change
main-HASH.module.js gzip 5.79 kB 5.79 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 6.17 kB 6.17 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.9 kB 51.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary abhik-b/next.js patch-1 Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB ✓
Overall change 26.4 kB 26.4 kB ✓
Client Build Manifests
vercel/next.js canary abhik-b/next.js patch-1 Change
_buildManifest.js gzip 267 B 267 B ✓
_buildManife..dule.js gzip 273 B 273 B ✓
Overall change 540 B 540 B ✓
Serverless bundles
vercel/next.js canary abhik-b/next.js patch-1 Change
_error.js 881 kB 881 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 881 kB 881 kB ✓
link.js 923 kB 923 kB ✓
routerDirect.js 917 kB 917 kB ✓
withRouter.js 917 kB 917 kB ✓
Overall change 4.53 MB 4.53 MB ✓
Commit: 2cc7d92

@Timer Timer added this to the iteration 5 milestone Jul 16, 2020
@ijjk
Copy link
Member

ijjk commented Jul 24, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary rupertrutland/next.js patch-1 Change
buildDuration 9.4s 9.7s ⚠️ +330ms
nodeModulesSize 66.4 MB 66.4 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary rupertrutland/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.627 1.562 -0.06
/ avg req/sec 1536.77 1600.11 +63.34
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 0.948 0.906 -0.04
/error-in-render avg req/sec 2638.49 2759.4 +120.91
Client Bundles (main, webpack, commons)
vercel/next.js canary rupertrutland/next.js patch-1 Change
677f882d2ed8..d2f7.js gzip 10.1 kB 10.1 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-8da3811..3b61.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.6 kB 87.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary rupertrutland/next.js patch-1 Change
677f882d2ed8..dule.js gzip 6.1 kB 6.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-43a8e8b..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary rupertrutland/next.js patch-1 Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary rupertrutland/next.js patch-1 Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary rupertrutland/next.js patch-1 Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary rupertrutland/next.js patch-1 Change
index.html gzip 946 B 946 B ✓
link.html gzip 952 B 952 B ✓
withRouter.html gzip 938 B 938 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary rupertrutland/next.js patch-1 Change
buildDuration 10.7s 10.7s ⚠️ +10ms
nodeModulesSize 66.4 MB 66.4 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary rupertrutland/next.js patch-1 Change
677f882d2ed8..d2f7.js gzip 10.1 kB 10.1 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-8da3811..3b61.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.6 kB 87.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary rupertrutland/next.js patch-1 Change
677f882d2ed8..dule.js gzip 6.1 kB 6.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-43a8e8b..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary rupertrutland/next.js patch-1 Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary rupertrutland/next.js patch-1 Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary rupertrutland/next.js patch-1 Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary rupertrutland/next.js patch-1 Change
_error.js 881 kB 881 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 881 kB 881 kB ✓
link.js 922 kB 922 kB ✓
routerDirect.js 916 kB 916 kB ✓
withRouter.js 916 kB 916 kB ✓
Overall change 4.52 MB 4.52 MB ✓
Commit: b333632

@Timer Timer self-assigned this Jul 25, 2020
@Timer
Copy link
Member

Timer commented Jul 25, 2020

This should be OK to land since we're releasing the new release Monday morning!

@ijjk
Copy link
Member

ijjk commented Jul 25, 2020

Stats from current PR

Default Server Mode
General
vercel/next.js canary karlhorky/next.js patch-1 Change
buildDuration 10.2s 10.2s ⚠️ +15ms
nodeModulesSize 66.4 MB 66.4 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary karlhorky/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.73 1.725 0
/ avg req/sec 1444.78 1448.86 +4.08
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.001 1.001 ✓
/error-in-render avg req/sec 2498.09 2497.87 ⚠️ -0.22
Client Bundles (main, webpack, commons)
vercel/next.js canary karlhorky/next.js patch-1 Change
677f882d2ed8..d2f7.js gzip 10.1 kB 10.1 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-8da3811..3b61.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.6 kB 87.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary karlhorky/next.js patch-1 Change
677f882d2ed8..dule.js gzip 6.1 kB 6.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-43a8e8b..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary karlhorky/next.js patch-1 Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary karlhorky/next.js patch-1 Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary karlhorky/next.js patch-1 Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary karlhorky/next.js patch-1 Change
index.html gzip 946 B 946 B ✓
link.html gzip 952 B 952 B ✓
withRouter.html gzip 938 B 938 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary karlhorky/next.js patch-1 Change
buildDuration 12.1s 11.6s -503ms
nodeModulesSize 66.4 MB 66.4 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary karlhorky/next.js patch-1 Change
677f882d2ed8..d2f7.js gzip 10.1 kB 10.1 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-8da3811..3b61.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.6 kB 87.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary karlhorky/next.js patch-1 Change
677f882d2ed8..dule.js gzip 6.1 kB 6.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-43a8e8b..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary karlhorky/next.js patch-1 Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary karlhorky/next.js patch-1 Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary karlhorky/next.js patch-1 Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary karlhorky/next.js patch-1 Change
_error.js 881 kB 881 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 881 kB 881 kB ✓
link.js 922 kB 922 kB ✓
routerDirect.js 916 kB 916 kB ✓
withRouter.js 916 kB 916 kB ✓
Overall change 4.52 MB 4.52 MB ✓
Commit: 60c27d5

@ijjk
Copy link
Member

ijjk commented Jul 25, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary karlhorky/next.js patch-1 Change
buildDuration 13s 12.7s -286ms
nodeModulesSize 66.4 MB 66.4 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary karlhorky/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.134 2.072 -0.06
/ avg req/sec 1171.25 1206.83 +35.58
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.444 1.403 -0.04
/error-in-render avg req/sec 1731.62 1781.28 +49.66
Client Bundles (main, webpack, commons)
vercel/next.js canary karlhorky/next.js patch-1 Change
677f882d2ed8..d2f7.js gzip 10.1 kB 10.1 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-8da3811..3b61.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.6 kB 87.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary karlhorky/next.js patch-1 Change
677f882d2ed8..dule.js gzip 6.1 kB 6.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-43a8e8b..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary karlhorky/next.js patch-1 Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary karlhorky/next.js patch-1 Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary karlhorky/next.js patch-1 Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary karlhorky/next.js patch-1 Change
index.html gzip 946 B 946 B ✓
link.html gzip 952 B 952 B ✓
withRouter.html gzip 938 B 938 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary karlhorky/next.js patch-1 Change
buildDuration 14s 13.9s -143ms
nodeModulesSize 66.4 MB 66.4 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary karlhorky/next.js patch-1 Change
677f882d2ed8..d2f7.js gzip 10.1 kB 10.1 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-8da3811..3b61.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.6 kB 87.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary karlhorky/next.js patch-1 Change
677f882d2ed8..dule.js gzip 6.1 kB 6.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-43a8e8b..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary karlhorky/next.js patch-1 Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary karlhorky/next.js patch-1 Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary karlhorky/next.js patch-1 Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary karlhorky/next.js patch-1 Change
_error.js 881 kB 881 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 881 kB 881 kB ✓
link.js 922 kB 922 kB ✓
routerDirect.js 916 kB 916 kB ✓
withRouter.js 916 kB 916 kB ✓
Overall change 4.52 MB 4.52 MB ✓
Commit: 234a310

@ijjk
Copy link
Member

ijjk commented Jul 25, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary karlhorky/next.js patch-1 Change
buildDuration 13.9s 14.1s ⚠️ +158ms
nodeModulesSize 66.4 MB 66.4 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary karlhorky/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.326 2.38 ⚠️ +0.05
/ avg req/sec 1074.7 1050.63 ⚠️ -24.07
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.486 1.513 ⚠️ +0.03
/error-in-render avg req/sec 1682.49 1652.71 ⚠️ -29.78
Client Bundles (main, webpack, commons)
vercel/next.js canary karlhorky/next.js patch-1 Change
677f882d2ed8..d2f7.js gzip 10.1 kB 10.1 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-8da3811..3b61.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.6 kB 87.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary karlhorky/next.js patch-1 Change
677f882d2ed8..dule.js gzip 6.1 kB 6.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-43a8e8b..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary karlhorky/next.js patch-1 Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary karlhorky/next.js patch-1 Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary karlhorky/next.js patch-1 Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary karlhorky/next.js patch-1 Change
index.html gzip 946 B 946 B ✓
link.html gzip 952 B 952 B ✓
withRouter.html gzip 938 B 938 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary karlhorky/next.js patch-1 Change
buildDuration 15.2s 14.9s -376ms
nodeModulesSize 66.4 MB 66.4 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary karlhorky/next.js patch-1 Change
677f882d2ed8..d2f7.js gzip 10.1 kB 10.1 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-8da3811..3b61.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.6 kB 87.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary karlhorky/next.js patch-1 Change
677f882d2ed8..dule.js gzip 6.1 kB 6.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-43a8e8b..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary karlhorky/next.js patch-1 Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary karlhorky/next.js patch-1 Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary karlhorky/next.js patch-1 Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary karlhorky/next.js patch-1 Change
_error.js 881 kB 881 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 881 kB 881 kB ✓
link.js 922 kB 922 kB ✓
routerDirect.js 916 kB 916 kB ✓
withRouter.js 916 kB 916 kB ✓
Overall change 4.52 MB 4.52 MB ✓
Commit: ae3ac1d

@Timer Timer merged commit c983667 into vercel:canary Jul 25, 2020
@karlhorky
Copy link
Contributor Author

Great, thanks @Timer!

@karlhorky karlhorky deleted the patch-1 branch July 27, 2020 08:54
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees

@Timer Timer

Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
iteration 5
Development

Successfully merging this pull request may close these issues.
3 participants
@karlhorky @ijjk @Timer