Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add plugin to recommended eslint-plugin-next config #13926

Merged
merged 6 commits into from
Jun 10, 2020
Merged

fix: add plugin to recommended eslint-plugin-next config #13926

merged 6 commits into from
Jun 10, 2020

Conversation

stefanprobst
Copy link
Contributor

allow extending the recommended eslint-plugin-next config, without having to specify the plugin name in the plugins array. eslint does not do this automatically, see the note here

@ijjk
Copy link
Member

ijjk commented Jun 9, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
buildDuration 12.9s 12.6s -276ms
nodeModulesSize 66 MB 66 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.11 2.143 ⚠️ +0.03
/ avg req/sec 1184.79 1166.52 -18.27
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.455 1.414 -0.04
/error-in-render avg req/sec 1718.6 1768.09 ⚠️ +49.49
Client Bundles (main, webpack, commons)
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..ec24.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
_buildManifest.js gzip 171 B 171 B ✓
_buildManife..dule.js gzip 180 B 180 B ✓
Overall change 351 B 351 B ✓
Rendered Page Sizes
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
index.html gzip 901 B 901 B ✓
link.html gzip 906 B 906 B ✓
withRouter.html gzip 894 B 894 B ✓
Overall change 2.7 kB 2.7 kB ✓
Serverless Mode
General
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
buildDuration 13.4s 13.3s -163ms
nodeModulesSize 66 MB 66 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..ec24.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
_buildManifest.js gzip 171 B 171 B ✓
_buildManife..dule.js gzip 180 B 180 B ✓
Overall change 351 B 351 B ✓
Serverless bundles
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
_error.js 874 kB 874 kB ✓
404.html 4.13 kB 4.13 kB ✓
hooks.html 3.71 kB 3.71 kB ✓
index.js 875 kB 875 kB ✓
link.js 913 kB 913 kB ✓
routerDirect.js 905 kB 905 kB ✓
withRouter.js 905 kB 905 kB ✓
Overall change 4.48 MB 4.48 MB ✓

@Timer Timer requested a review from janicklas-ralph June 9, 2020 18:18
@ijjk
Copy link
Member

ijjk commented Jun 9, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
buildDuration 12.2s 12.2s -35ms
nodeModulesSize 64.9 MB 64.9 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.156 2.082 -0.07
/ avg req/sec 1159.46 1200.89 ⚠️ +41.43
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.37 1.435 ⚠️ +0.06
/error-in-render avg req/sec 1824.65 1742.04 -82.61
Client Bundles (main, webpack, commons)
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..ec24.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
_buildManifest.js gzip 171 B 171 B ✓
_buildManife..dule.js gzip 180 B 180 B ✓
Overall change 351 B 351 B ✓
Rendered Page Sizes
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
index.html gzip 901 B 901 B ✓
link.html gzip 906 B 906 B ✓
withRouter.html gzip 894 B 894 B ✓
Overall change 2.7 kB 2.7 kB ✓
Serverless Mode
General
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
buildDuration 13.6s 13.1s -572ms
nodeModulesSize 64.9 MB 64.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..ec24.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
_buildManifest.js gzip 171 B 171 B ✓
_buildManife..dule.js gzip 180 B 180 B ✓
Overall change 351 B 351 B ✓
Serverless bundles
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
_error.js 874 kB 874 kB ✓
404.html 4.13 kB 4.13 kB ✓
hooks.html 3.71 kB 3.71 kB ✓
index.js 875 kB 875 kB ✓
link.js 913 kB 913 kB ✓
routerDirect.js 905 kB 905 kB ✓
withRouter.js 905 kB 905 kB ✓
Overall change 4.48 MB 4.48 MB ✓

@ijjk
Copy link
Member

ijjk commented Jun 9, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
buildDuration 13.1s 13.7s ⚠️ +552ms
nodeModulesSize 64.9 MB 64.9 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.253 2.294 ⚠️ +0.04
/ avg req/sec 1109.54 1089.88 -19.66
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.471 1.52 ⚠️ +0.05
/error-in-render avg req/sec 1699.49 1644.68 -54.81
Client Bundles (main, webpack, commons)
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..ec24.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
_buildManifest.js gzip 171 B 171 B ✓
_buildManife..dule.js gzip 180 B 180 B ✓
Overall change 351 B 351 B ✓
Rendered Page Sizes
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
index.html gzip 901 B 901 B ✓
link.html gzip 906 B 906 B ✓
withRouter.html gzip 894 B 894 B ✓
Overall change 2.7 kB 2.7 kB ✓
Serverless Mode
General
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
buildDuration 14.8s 14.2s -635ms
nodeModulesSize 64.9 MB 64.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..ec24.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
_buildManifest.js gzip 171 B 171 B ✓
_buildManife..dule.js gzip 180 B 180 B ✓
Overall change 351 B 351 B ✓
Serverless bundles
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
_error.js 874 kB 874 kB ✓
404.html 4.13 kB 4.13 kB ✓
hooks.html 3.71 kB 3.71 kB ✓
index.js 875 kB 875 kB ✓
link.js 913 kB 913 kB ✓
routerDirect.js 905 kB 905 kB ✓
withRouter.js 905 kB 905 kB ✓
Overall change 4.48 MB 4.48 MB ✓

@ijjk
Copy link
Member

ijjk commented Jun 10, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
buildDuration 11.3s 11s -210ms
nodeModulesSize 64.9 MB 64.9 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.968 2.016 ⚠️ +0.05
/ avg req/sec 1270.07 1240.34 -29.73
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.293 1.301 ⚠️ +0.01
/error-in-render avg req/sec 1933.7 1922.12 -11.58
Client Bundles (main, webpack, commons)
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..4b11.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 7.26 kB 7.26 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
_buildManifest.js gzip 171 B 171 B ✓
_buildManife..dule.js gzip 180 B 180 B ✓
Overall change 351 B 351 B ✓
Rendered Page Sizes
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
index.html gzip 895 B 895 B ✓
link.html gzip 901 B 901 B ✓
withRouter.html gzip 888 B 888 B ✓
Overall change 2.68 kB 2.68 kB ✓
Serverless Mode
General
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
buildDuration 12.7s 12.2s -563ms
nodeModulesSize 64.9 MB 64.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..4b11.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 7.26 kB 7.26 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
_buildManifest.js gzip 171 B 171 B ✓
_buildManife..dule.js gzip 180 B 180 B ✓
Overall change 351 B 351 B ✓
Serverless bundles
vercel/next.js canary stefanprobst/next.js fix/eslint-config-add-plugin Change
_error.js 875 kB 875 kB ✓
404.html 4.13 kB 4.13 kB ✓
hooks.html 3.71 kB 3.71 kB ✓
index.js 875 kB 875 kB ✓
link.js 915 kB 915 kB ✓
routerDirect.js 907 kB 907 kB ✓
withRouter.js 907 kB 907 kB ✓
Overall change 4.49 MB 4.49 MB ✓

@kodiakhq kodiakhq bot merged commit caddd35 into vercel:canary Jun 10, 2020
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@stefanprobst @rokinsky
fix: add plugin to recommended eslint-plugin-next config (vercel#13926)
1103a43 
allow extending the recommended eslint-plugin-next config, without having to specify the plugin name in the plugins array. eslint does not do this automatically, see the note [here](https://eslint.org/docs/developer-guide/working-with-plugins#configs-in-plugins)
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janicklas-ralph janicklas-ralph janicklas-ralph approved these changes

@lfades lfades lfades approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stefanprobst @ijjk @lfades @janicklas-ralph @Timer