[Example] Deprecate with-sentry in favor of with-sentry-simple #13904

todortotev · 2020-06-08T15:48:56Z

Let me know if there is something you are unhappy with.

Tagging @lfades to confirm everything's OK.

examples/with-sentry-simple/README.md

lfades

Thank you!

ijjk · 2020-06-08T16:53:44Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
buildDuration	12.6s	13.7s	⚠️ +1s
nodeModulesSize	66 MB	66 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.244	2.292	⚠️ +0.05
/ avg req/sec	1113.97	1090.94	-23.03
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.525	1.4	-0.12
/error-in-render avg req/sec	1639.86	1785.97	⚠️ +146.11

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..ec24.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
main-HASH.module.js gzip	5.67 kB	5.67 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.92 kB	6.92 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
index.html gzip	925 B	925 B	✓
link.html gzip	936 B	936 B	✓
withRouter.html gzip	922 B	922 B	✓
Overall change	2.78 kB	2.78 kB	✓

Serverless Mode

General

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
buildDuration	13.8s	14.2s	⚠️ +432ms
nodeModulesSize	66 MB	66 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..ec24.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
main-HASH.module.js gzip	5.67 kB	5.67 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.92 kB	6.92 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
_error.js	877 kB	877 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	877 kB	877 kB	✓
link.js	915 kB	915 kB	✓
routerDirect.js	908 kB	908 kB	✓
withRouter.js	908 kB	908 kB	✓
Overall change	4.49 MB	4.49 MB	✓

lfades

Need to add changes from https://github.com/vercel/next.js/pull/13899/files

examples/with-sentry/README.md

ijjk · 2020-06-08T17:36:47Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
buildDuration	13.1s	13.3s	⚠️ +191ms
nodeModulesSize	66 MB	66 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.276	2.394	⚠️ +0.12
/ avg req/sec	1098.55	1044.19	-54.36
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.55	1.5	-0.05
/error-in-render avg req/sec	1612.93	1667.04	⚠️ +54.11

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..ec24.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
main-HASH.module.js gzip	5.67 kB	5.67 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.92 kB	6.92 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
index.html gzip	925 B	925 B	✓
link.html gzip	936 B	936 B	✓
withRouter.html gzip	922 B	922 B	✓
Overall change	2.78 kB	2.78 kB	✓

Serverless Mode

General

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
buildDuration	14.3s	14.4s	⚠️ +117ms
nodeModulesSize	66 MB	66 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..ec24.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
main-HASH.module.js gzip	5.67 kB	5.67 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.92 kB	6.92 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
_error.js	877 kB	877 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	877 kB	877 kB	✓
link.js	915 kB	915 kB	✓
routerDirect.js	908 kB	908 kB	✓
withRouter.js	908 kB	908 kB	✓
Overall change	4.49 MB	4.49 MB	✓

ijjk · 2020-06-08T18:44:06Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
buildDuration	10s	10.1s	⚠️ +40ms
nodeModulesSize	66 MB	66 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.762	1.742	-0.02
/ avg req/sec	1418.75	1434.93	⚠️ +16.18
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.149	1.197	⚠️ +0.05
/error-in-render avg req/sec	2175.14	2089.42	-85.72

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
main-HASH.js gzip	6.49 kB	6.49 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..ec24.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
main-HASH.module.js gzip	5.58 kB	5.58 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.92 kB	6.92 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
_buildManifest.js gzip	171 B	171 B	✓
_buildManife..dule.js gzip	180 B	180 B	✓
Overall change	351 B	351 B	✓

Rendered Page Sizes

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
index.html gzip	901 B	901 B	✓
link.html gzip	906 B	906 B	✓
withRouter.html gzip	894 B	894 B	✓
Overall change	2.7 kB	2.7 kB	✓

Serverless Mode

General

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
buildDuration	11.3s	11.1s	-249ms
nodeModulesSize	66 MB	66 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
main-HASH.js gzip	6.49 kB	6.49 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..ec24.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
main-HASH.module.js gzip	5.58 kB	5.58 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.92 kB	6.92 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
_buildManifest.js gzip	171 B	171 B	✓
_buildManife..dule.js gzip	180 B	180 B	✓
Overall change	351 B	351 B	✓

Serverless bundles

	vercel/next.js canary	TodorTotev/next.js deprecate-with-sentry	Change
_error.js	874 kB	874 kB	✓
404.html	4.13 kB	4.13 kB	✓
hooks.html	3.71 kB	3.71 kB	✓
index.js	875 kB	875 kB	✓
link.js	913 kB	913 kB	✓
routerDirect.js	905 kB	905 kB	✓
withRouter.js	905 kB	905 kB	✓
Overall change	4.48 MB	4.48 MB	✓

…l#13904) Co-authored-by: Luis Alvarez D <[email protected]> Co-authored-by: Joe Haddad <[email protected]>

todortotev added 3 commits June 8, 2020 18:46

Delete with-sentry stuff

ff4d7bb

Move with-sentry-simple to with-sentry

0bc3cd8

typo

2730f94

todortotev requested review from chibicode, ijjk, lfades, Timer and timneutkens as code owners June 8, 2020 15:48

ijjk added the examples Issue was opened via the examples template. label Jun 8, 2020

lfades reviewed Jun 8, 2020

View reviewed changes

examples/with-sentry-simple/README.md Outdated Show resolved Hide resolved

lfades reviewed Jun 8, 2020

View reviewed changes

examples/with-sentry-simple/README.md Outdated Show resolved Hide resolved

Apply suggestions from code review

059d95b

lfades approved these changes Jun 8, 2020

View reviewed changes

Merge branch 'canary' into deprecate-with-sentry

d85f09f

lfades requested changes Jun 8, 2020

View reviewed changes

examples/with-sentry/README.md Outdated Show resolved Hide resolved

examples/with-sentry/README.md Outdated Show resolved Hide resolved

Apply suggestions from code review

9052d00

lfades approved these changes Jun 8, 2020

View reviewed changes

Timer approved these changes Jun 8, 2020

View reviewed changes

Merge branch 'canary' into deprecate-with-sentry

cfa0792

Timer merged commit 47e2beb into vercel:canary Jun 9, 2020

kachkaev mentioned this pull request Jun 29, 2020

Publish stable version of @zeit/next-source-maps vercel/next-plugins#634

Closed

rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020

[Example] Deprecate with-sentry in favor of with-sentry-simple (verce…

b5895ec

…l#13904) Co-authored-by: Luis Alvarez D <[email protected]> Co-authored-by: Joe Haddad <[email protected]>

vercel locked as resolved and limited conversation to collaborators Jan 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Example] Deprecate with-sentry in favor of with-sentry-simple #13904

[Example] Deprecate with-sentry in favor of with-sentry-simple #13904

todortotev commented Jun 8, 2020 •

edited

Loading

lfades left a comment

ijjk commented Jun 8, 2020

lfades left a comment

ijjk commented Jun 8, 2020

ijjk commented Jun 8, 2020

[Example] Deprecate with-sentry in favor of with-sentry-simple #13904

[Example] Deprecate with-sentry in favor of with-sentry-simple #13904

Conversation

todortotev commented Jun 8, 2020 • edited Loading

lfades left a comment

Choose a reason for hiding this comment

ijjk commented Jun 8, 2020

Stats from current PR

lfades left a comment

Choose a reason for hiding this comment

ijjk commented Jun 8, 2020

Stats from current PR

ijjk commented Jun 8, 2020

Stats from current PR

todortotev commented Jun 8, 2020 •

edited

Loading