Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notify component when route hash changes #13894

Merged
merged 3 commits into from
Aug 6, 2020
Merged

notify component when route hash changes #13894

merged 3 commits into from
Aug 6, 2020

Conversation

tomdohnal
Copy link
Contributor

This resolves #13659

@ijjk ijjk added the type: next label Jun 8, 2020
@ijjk
Copy link
Member

ijjk commented Jun 8, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
buildDuration 12.7s 12.4s -269ms
nodeModulesSize 66 MB 66 MB ⚠️ +148 B
Page Load Tests Overall increase ✓
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.255 2.201 -0.05
/ avg req/sec 1108.64 1136.01 ⚠️ +27.37
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.452 1.452 ✓
/error-in-render avg req/sec 1721.62 1722.28 ⚠️ +0.66
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
main-HASH.js gzip 6.61 kB 6.61 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..9545.js gzip 10.5 kB 10.5 kB ⚠️ +9 B
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ⚠️ +9 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.93 kB ⚠️ +4 B
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ⚠️ +4 B
Legacy Client Bundles (polyfills)
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.21 kB 8.21 kB ✓
Client Pages Modern
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.32 kB 5.32 kB ✓
Client Build Manifests
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
index.html gzip 926 B 925 B -1 B
link.html gzip 936 B 934 B -2 B
withRouter.html gzip 923 B 921 B -2 B
Overall change 2.79 kB 2.78 kB -5 B

Diffs

Diff for de003c3a9d30..afec2141f.js 
@@ -1120,6 +1120,8 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 
                     _this2.scrollToHash(as);
 
+                    _this2.notify(_this2.components[_this2.route]);
+
                     Router.events.emit("hashChangeComplete", as);
                     return resolve(true);
                   }
Diff for de003c3a9d30..58.module.js 
@@ -967,6 +967,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
               Router.events.emit("hashChangeStart", as);
               this.changeState(method, url, as, options);
               this.scrollToHash(as);
+              this.notify(this.components[this.route]);
               Router.events.emit("hashChangeComplete", as);
               return resolve(true);
             }
Diff for index.html 
@@ -30,7 +30,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9a53c0354b7704786358.module.js"
+      href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.aadde96479802cbc2bf3.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -133,13 +133,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0d9426f7161afec2141f.js"
+      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.12640c4791daaab3feab.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9a53c0354b7704786358.module.js"
+      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.aadde96479802cbc2bf3.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -30,7 +30,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9a53c0354b7704786358.module.js"
+      href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.aadde96479802cbc2bf3.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -138,13 +138,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0d9426f7161afec2141f.js"
+      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.12640c4791daaab3feab.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9a53c0354b7704786358.module.js"
+      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.aadde96479802cbc2bf3.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -30,7 +30,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9a53c0354b7704786358.module.js"
+      href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.aadde96479802cbc2bf3.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -133,13 +133,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0d9426f7161afec2141f.js"
+      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.12640c4791daaab3feab.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9a53c0354b7704786358.module.js"
+      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.aadde96479802cbc2bf3.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
buildDuration 13.7s 13.3s -337ms
nodeModulesSize 66 MB 66 MB ⚠️ +148 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
main-HASH.js gzip 6.61 kB 6.61 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..9545.js gzip 10.5 kB N/A N/A
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
de003c3a9d30..0e4a.js gzip N/A 10.5 kB N/A
Overall change 57 kB 57 kB ⚠️ +9 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB N/A N/A
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
de003c3a9d30..dule.js gzip N/A 6.93 kB N/A
Overall change 52.5 kB 52.5 kB ⚠️ +4 B
Legacy Client Bundles (polyfills)
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.21 kB 8.21 kB ✓
Client Pages Modern
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.32 kB 5.32 kB ✓
Client Build Manifests
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
_error.js 877 kB 877 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 877 kB 877 kB ✓
link.js 915 kB 915 kB ⚠️ +50 B
routerDirect.js 907 kB 908 kB ⚠️ +50 B
withRouter.js 907 kB 908 kB ⚠️ +50 B
Overall change 4.49 MB 4.49 MB ⚠️ +150 B

ijjk
ijjk approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks for the PR!

@ijjk
Copy link
Member

ijjk commented Aug 6, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
buildDuration 10.7s 10.8s ⚠️ +102ms
nodeModulesSize 65.9 MB 65.9 MB ⚠️ +144 B
Page Load Tests Overall increase ✓
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.118 2.051 -0.07
/ avg req/sec 1180.23 1219.04 +38.81
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.196 1.218 ⚠️ +0.02
/error-in-render avg req/sec 2090.52 2052.97 ⚠️ -37.55
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
677f882d2ed8..795d.js gzip 9.99 kB 9.99 kB ⚠️ +6 B
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-c30ac70..0d39.js gzip 6.74 kB 6.74 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.6 kB 56.6 kB ⚠️ +6 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
677f882d2ed8..dule.js gzip 5.89 kB 5.89 kB ⚠️ +5 B
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-61da9c7..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.6 kB 51.6 kB ⚠️ +5 B
Legacy Client Bundles (polyfills)
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-f4d2979..e57b.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-653c74f..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 553 B 553 B ✓
Rendered Page Sizes
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
index.html gzip 946 B 946 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 940 B 940 B ✓
Overall change 2.84 kB 2.84 kB ✓

Diffs

Diff for 677f882d2ed8..53.module.js 
@@ -951,6 +951,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
             Router.events.emit("hashChangeStart", as);
             this.changeState(method, url, as, options);
             this.scrollToHash(cleanedAs);
+            this.notify(this.components[this.route]);
             Router.events.emit("hashChangeComplete", as);
             return true;
           }
Diff for 677f882d2ed8..f09d2c87c.js 
@@ -1156,7 +1156,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
                             if (
                               !(!options._h && this.onlyAHashChange(cleanedAs))
                             ) {
-                              _context.next = 15;
+                              _context.next = 16;
                               break;
                             }
 
@@ -1164,20 +1164,21 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
                             Router.events.emit("hashChangeStart", as);
                             this.changeState(method, url, as, options);
                             this.scrollToHash(cleanedAs);
+                            this.notify(this.components[this.route]);
                             Router.events.emit("hashChangeComplete", as);
                             return _context.abrupt("return", true);
 
-                          case 15:
+                          case 16:
                             parsed = tryParseRelativeUrl(url);
 
                             if (parsed) {
-                              _context.next = 18;
+                              _context.next = 19;
                               break;
                             }
 
                             return _context.abrupt("return", false);
 
-                          case 18:
+                          case 19:
                             (pathname = parsed.pathname),
                               (searchParams = parsed.searchParams);
                             query = (0, _querystring.searchParamsToUrlQuery)(
@@ -1212,7 +1213,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
                                   : _options$shallow);
 
                             if (!(0, _isDynamic.isDynamicRoute)(route)) {
-                              _context.next = 36;
+                              _context.next = 37;
                               break;
                             }
 
@@ -1226,7 +1227,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
                             )(asPathname);
 
                             if (routeMatch) {
-                              _context.next = 35;
+                              _context.next = 36;
                               break;
                             }
 
@@ -1237,7 +1238,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
                             });
 
                             if (!(missingParams.length > 0)) {
-                              _context.next = 33;
+                              _context.next = 34;
                               break;
                             }
 
@@ -1254,18 +1255,18 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
                                 "Read more: https://err.sh/vercel/next.js/incompatible-href-as"
                             );
 
-                          case 33:
-                            _context.next = 36;
+                          case 34:
+                            _context.next = 37;
                             break;
 
-                          case 35:
+                          case 36:
                             // Merge params into `query`, overwriting any specified in search
                             Object.assign(query, routeMatch);
 
-                          case 36:
+                          case 37:
                             Router.events.emit("routeChangeStart", as);
-                            _context.prev = 37;
-                            _context.next = 40;
+                            _context.prev = 38;
+                            _context.next = 41;
                             return this.getRouteInfo(
                               route,
                               pathname,
@@ -1274,7 +1275,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
                               shallow
                             );
 
-                          case 40:
+                          case 41:
                             routeInfo = _context.sent;
                             error = routeInfo.error;
                             Router.events.emit("beforeHistoryChange", as);
@@ -1283,7 +1284,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
                             if (false) {
                             }
 
-                            _context.next = 47;
+                            _context.next = 48;
                             return this.set(
                               route,
                               pathname,
@@ -1292,9 +1293,9 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
                               routeInfo
                             );
 
-                          case 47:
+                          case 48:
                             if (!error) {
-                              _context.next = 50;
+                              _context.next = 51;
                               break;
                             }
 
@@ -1305,28 +1306,28 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
                             );
                             throw error;
 
-                          case 50:
+                          case 51:
                             if (false) {
                             }
 
                             Router.events.emit("routeChangeComplete", as);
                             return _context.abrupt("return", true);
 
-                          case 55:
-                            _context.prev = 55;
-                            _context.t0 = _context["catch"](37);
+                          case 56:
+                            _context.prev = 56;
+                            _context.t0 = _context["catch"](38);
 
                             if (!_context.t0.cancelled) {
-                              _context.next = 59;
+                              _context.next = 60;
                               break;
                             }
 
                             return _context.abrupt("return", false);
 
-                          case 59:
+                          case 60:
                             throw _context.t0;
 
-                          case 60:
+                          case 61:
                           case "end":
                             return _context.stop();
                         }
@@ -1334,7 +1335,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
                     },
                     _callee,
                     this,
-                    [[37, 55]]
+                    [[38, 56]]
                   );
                 })
               );
Diff for index.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.abab298279f1577d0b53.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0a0ebfbd41e8343f0e01.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -117,13 +117,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ccd9e85644ff09d2c87c.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.2e522db0023a52e0893d.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.abab298279f1577d0b53.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0a0ebfbd41e8343f0e01.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.abab298279f1577d0b53.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0a0ebfbd41e8343f0e01.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -122,13 +122,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ccd9e85644ff09d2c87c.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.2e522db0023a52e0893d.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.abab298279f1577d0b53.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0a0ebfbd41e8343f0e01.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.abab298279f1577d0b53.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0a0ebfbd41e8343f0e01.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -117,13 +117,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ccd9e85644ff09d2c87c.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.2e522db0023a52e0893d.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.abab298279f1577d0b53.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0a0ebfbd41e8343f0e01.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
buildDuration 12s 12.1s ⚠️ +126ms
nodeModulesSize 65.9 MB 65.9 MB ⚠️ +144 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
677f882d2ed8..795d.js gzip 9.99 kB N/A N/A
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-c30ac70..0d39.js gzip 6.74 kB 6.74 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
677f882d2ed8..ec1a.js gzip N/A 9.99 kB N/A
Overall change 56.6 kB 56.6 kB ⚠️ +6 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
677f882d2ed8..dule.js gzip 5.89 kB N/A N/A
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-61da9c7..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
677f882d2ed8..dule.js gzip N/A 5.89 kB N/A
Overall change 51.6 kB 51.6 kB ⚠️ +5 B
Legacy Client Bundles (polyfills)
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-f4d2979..e57b.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-653c74f..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 553 B 553 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary tomdohnal/next.js update-aspath-on-hash-change Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ⚠️ +48 B
routerDirect.js 1.06 MB 1.06 MB ⚠️ +48 B
withRouter.js 1.06 MB 1.06 MB ⚠️ +48 B
Overall change 5.26 MB 5.26 MB ⚠️ +144 B
Commit: 0250c74

@kodiakhq kodiakhq bot merged commit eb4be22 into vercel:canary Aug 6, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Navigating to hash does not trigger router change
2 participants
@tomdohnal @ijjk