Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine taskr next-server tasks into one #13842

Merged
merged 3 commits into from
Jun 9, 2020
Merged

Combine taskr next-server tasks into one #13842

merged 3 commits into from
Jun 9, 2020

Conversation

timneutkens
Copy link
Member

Because of the recent changes to drop tsc running against published code we can now combine the 2 methods we had to compile next-server

@timneutkens
Combine taskr task into 1
7938165 
Because of the recent changes to drop tsc running against published code we can now combine the 2 methods we had to compile next-server
@timneutkens timneutkens requested review from ijjk, lfades and Timer as code owners June 6, 2020 15:29
@ijjk ijjk added the type: next label Jun 6, 2020
@timneutkens timneutkens changed the title Combine taskr task into 1 Combine taskr next-server tasks into one Jun 6, 2020
@ijjk
Copy link
Member

ijjk commented Jun 6, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
buildDuration 12.9s 12.9s ⚠️ +41ms
nodeModulesSize 66 MB 66 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.348 2.327 -0.02
/ avg req/sec 1064.71 1074.43 ⚠️ +9.72
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.447 1.412 -0.04
/error-in-render avg req/sec 1727.54 1770.19 ⚠️ +42.65
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
main-HASH.js gzip 6.61 kB 6.61 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..9545.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.21 kB 8.21 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.32 kB 5.32 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
index.html gzip 927 B 927 B ✓
link.html gzip 936 B 936 B ✓
withRouter.html gzip 924 B 924 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
buildDuration 13.9s 14s ⚠️ +98ms
nodeModulesSize 66 MB 66 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
main-HASH.js gzip 6.61 kB 6.61 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..9545.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.21 kB 8.21 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.32 kB 5.32 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
_error.js 878 kB 878 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 878 kB 878 kB ✓
link.js 916 kB 916 kB ✓
routerDirect.js 909 kB 909 kB ✓
withRouter.js 909 kB 909 kB ✓
Overall change 4.5 MB 4.5 MB ✓

@ijjk
Copy link
Member

ijjk commented Jun 7, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
buildDuration 13s 12.9s -117ms
nodeModulesSize 66 MB 66 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.293 2.292 0
/ avg req/sec 1090.29 1090.89 ⚠️ +0.6
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.442 1.453 ⚠️ +0.01
/error-in-render avg req/sec 1733.53 1720.61 -12.92
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
main-HASH.js gzip 6.61 kB 6.61 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..9545.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.21 kB 8.21 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.32 kB 5.32 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
index.html gzip 926 B 926 B ✓
link.html gzip 936 B 936 B ✓
withRouter.html gzip 923 B 923 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
buildDuration 14.1s 13.8s -325ms
nodeModulesSize 66 MB 66 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
main-HASH.js gzip 6.61 kB 6.61 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..9545.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.21 kB 8.21 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.32 kB 5.32 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
_error.js 877 kB 877 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 877 kB 877 kB ✓
link.js 915 kB 915 kB ✓
routerDirect.js 907 kB 907 kB ✓
withRouter.js 907 kB 907 kB ✓
Overall change 4.49 MB 4.49 MB ✓

@ijjk
Copy link
Member

ijjk commented Jun 8, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
buildDuration 12.2s 12s -189ms
nodeModulesSize 66 MB 66 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.021 2.009 -0.01
/ avg req/sec 1237.18 1244.53 ⚠️ +7.35
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.226 1.237 ⚠️ +0.01
/error-in-render avg req/sec 2038.66 2020.89 -17.77
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..ec24.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
_buildManifest.js gzip 171 B 171 B ✓
_buildManife..dule.js gzip 180 B 180 B ✓
Overall change 351 B 351 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
index.html gzip 901 B 901 B ✓
link.html gzip 906 B 906 B ✓
withRouter.html gzip 894 B 894 B ✓
Overall change 2.7 kB 2.7 kB ✓
Serverless Mode
General
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
buildDuration 13.4s 13.2s -137ms
nodeModulesSize 66 MB 66 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..ec24.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
_buildManifest.js gzip 171 B 171 B ✓
_buildManife..dule.js gzip 180 B 180 B ✓
Overall change 351 B 351 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js add/remove-extra-build-step Change
_error.js 874 kB 874 kB ✓
404.html 4.13 kB 4.13 kB ✓
hooks.html 3.71 kB 3.71 kB ✓
index.js 875 kB 875 kB ✓
link.js 913 kB 913 kB ✓
routerDirect.js 905 kB 905 kB ✓
withRouter.js 905 kB 905 kB ✓
Overall change 4.48 MB 4.48 MB ✓

@Timer Timer merged commit 2920af7 into vercel:canary Jun 9, 2020
@timneutkens timneutkens deleted the add/remove-extra-build-step branch June 9, 2020 09:10
@ijjk ijjk mentioned this pull request Jun 10, 2020
Merged
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@timneutkens @Timer @rokinsky
Combine taskr next-server tasks into one (vercel#13842)
b43e897 
Co-authored-by: Joe Haddad <[email protected]>
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfades lfades lfades approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timneutkens @ijjk @lfades @Timer