[Examples] Move with-apollo to SSG #13742

lfades · 2020-06-04T02:59:39Z

Based on #13607 - I created a new PR as I can't push changes to the initial PR.

Migrated the Apollo client to use SSG, also removed the link to the live demo because I don't know who the owner is or how to update the deployment.

The implementation is pretty simple and will be added to all the other Apollo examples

It cannot be used anymore, cause it requires getInitialProps

…r-with-apollo

ijjk · 2020-06-04T03:09:12Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
buildDuration	13.4s	13.1s	-254ms
nodeModulesSize	66 MB	66 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.402	2.332	-0.07
/ avg req/sec	1040.66	1071.9	⚠️ +31.24
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.477	1.434	-0.04
/error-in-render avg req/sec	1692.22	1742.88	⚠️ +50.66

Client Bundles (main, webpack, commons)

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..6c2a.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
main-HASH.module.js gzip	5.67 kB	5.67 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
index.html gzip	924 B	924 B	✓
link.html gzip	934 B	934 B	✓
withRouter.html gzip	922 B	922 B	✓
Overall change	2.78 kB	2.78 kB	✓

Serverless Mode

General

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
buildDuration	14.3s	14.5s	⚠️ +212ms
nodeModulesSize	66 MB	66 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..6c2a.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
main-HASH.module.js gzip	5.67 kB	5.67 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_error.js	878 kB	878 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	879 kB	879 kB	✓
link.js	916 kB	916 kB	✓
routerDirect.js	909 kB	909 kB	✓
withRouter.js	909 kB	909 kB	✓
Overall change	4.5 MB	4.5 MB	✓

adamsoffer · 2020-06-04T15:36:04Z

@lfades Super excited to see this example get updated. FYI I'm the owner of the next-with-apollo.now.sh deployment (it's deployed to vercel) and I can update it once this is merged if we want to keep the live demo in the README.

adamsoffer · 2020-06-04T15:52:59Z

Also, we should probably use incremental builds in this example. Right now if you submit a post and refresh the page it's gone.

ijjk · 2020-06-04T22:07:07Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
buildDuration	11.7s	11.5s	-174ms
nodeModulesSize	66 MB	66 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.942	1.976	⚠️ +0.03
/ avg req/sec	1287.14	1265.42	-21.72
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.069	1.124	⚠️ +0.06
/error-in-render avg req/sec	2339.56	2225.11	-114.45

Client Bundles (main, webpack, commons)

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
main-HASH.js gzip	6.61 kB	6.61 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..6c2a.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
main-HASH.module.js gzip	5.69 kB	5.69 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
index.html gzip	925 B	925 B	✓
link.html gzip	935 B	935 B	✓
withRouter.html gzip	923 B	923 B	✓
Overall change	2.78 kB	2.78 kB	✓

Serverless Mode

General

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
buildDuration	12.8s	12.7s	-118ms
nodeModulesSize	66 MB	66 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
main-HASH.js gzip	6.61 kB	6.61 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..6c2a.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
main-HASH.module.js gzip	5.69 kB	5.69 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_error.js	878 kB	878 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	878 kB	878 kB	✓
link.js	916 kB	916 kB	✓
routerDirect.js	909 kB	909 kB	✓
withRouter.js	909 kB	909 kB	✓
Overall change	4.5 MB	4.5 MB	✓

lfades · 2020-06-04T22:40:56Z

@adamsoffer It's ready now, can you check it out and then update the deployment 🙏

ijjk · 2020-06-04T22:47:48Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
buildDuration	10.1s	10.9s	⚠️ +787ms
nodeModulesSize	66 MB	66 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.788	1.852	⚠️ +0.06
/ avg req/sec	1398.08	1349.64	-48.44
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.121	1.23	⚠️ +0.11
/error-in-render avg req/sec	2230.27	2032.34	-197.93

Client Bundles (main, webpack, commons)

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
main-HASH.js gzip	6.61 kB	6.61 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..6c2a.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
main-HASH.module.js gzip	5.69 kB	5.69 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
index.html gzip	925 B	925 B	✓
link.html gzip	935 B	935 B	✓
withRouter.html gzip	923 B	923 B	✓
Overall change	2.78 kB	2.78 kB	✓

Serverless Mode

General

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
buildDuration	12.4s	12.6s	⚠️ +173ms
nodeModulesSize	66 MB	66 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
main-HASH.js gzip	6.61 kB	6.61 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..6c2a.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
main-HASH.module.js gzip	5.69 kB	5.69 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_error.js	878 kB	878 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	878 kB	878 kB	✓
link.js	916 kB	916 kB	✓
routerDirect.js	909 kB	909 kB	✓
withRouter.js	909 kB	909 kB	✓
Overall change	4.5 MB	4.5 MB	✓

adamsoffer · 2020-06-04T23:05:31Z

@lfades done 👍

I notice that after you submit a post you have to refresh the page twice to see reflected in the UI. I understand why this is (the first time you refresh it invalidates the cache and the second time it serves the newly built page) but I'm curious, how would we go about improving this example so that it displays the newly submitted post after a single refresh?

lfades · 2020-06-04T23:08:23Z

@adamsoffer One of the things we're going to release is the possibility to revalidate pages manually, that should address this case and many others.

adamsoffer · 2020-06-04T23:09:12Z

@lfades awesome.

ijjk · 2020-06-05T00:36:53Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
buildDuration	12.7s	13s	⚠️ +238ms
nodeModulesSize	66 MB	66 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.335	2.273	-0.06
/ avg req/sec	1070.46	1099.74	⚠️ +29.28
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.384	1.463	⚠️ +0.08
/error-in-render avg req/sec	1806.17	1708.58	-97.59

Client Bundles (main, webpack, commons)

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
main-HASH.js gzip	6.61 kB	6.61 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..6c2a.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
main-HASH.module.js gzip	5.69 kB	5.69 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
index.html gzip	925 B	925 B	✓
link.html gzip	935 B	935 B	✓
withRouter.html gzip	923 B	923 B	✓
Overall change	2.78 kB	2.78 kB	✓

Serverless Mode

General

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
buildDuration	13.9s	13.8s	-148ms
nodeModulesSize	66 MB	66 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
main-HASH.js gzip	6.61 kB	6.61 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..6c2a.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
main-HASH.module.js gzip	5.69 kB	5.69 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_error.js	878 kB	878 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	878 kB	878 kB	✓
link.js	916 kB	916 kB	✓
routerDirect.js	909 kB	909 kB	✓
withRouter.js	909 kB	909 kB	✓
Overall change	4.5 MB	4.5 MB	✓

adamsoffer · 2020-06-05T00:46:44Z

@lfades thoughts on just adding fetch('/') after createPost() until that release? That invalidates the cache immediately after creating a post.

Timer

LGTM, I trust you that this works.

ijjk · 2020-06-05T15:32:07Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
buildDuration	11.5s	11.2s	-351ms
nodeModulesSize	66 MB	66 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.006	1.955	-0.05
/ avg req/sec	1245.98	1278.71	⚠️ +32.73
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.141	1.144	0
/error-in-render avg req/sec	2191.88	2185.67	-6.21

Client Bundles (main, webpack, commons)

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
main-HASH.js gzip	6.61 kB	6.61 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..6c2a.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
main-HASH.module.js gzip	5.69 kB	5.69 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
index.html gzip	925 B	925 B	✓
link.html gzip	935 B	935 B	✓
withRouter.html gzip	923 B	923 B	✓
Overall change	2.78 kB	2.78 kB	✓

Serverless Mode

General

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
buildDuration	12.6s	12.5s	-82ms
nodeModulesSize	66 MB	66 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
main-HASH.js gzip	6.61 kB	6.61 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..6c2a.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
main-HASH.module.js gzip	5.69 kB	5.69 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	vercel/next.js canary	lfades/next.js ssg/with-apollo	Change
_error.js	878 kB	878 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	878 kB	878 kB	✓
link.js	916 kB	916 kB	✓
routerDirect.js	909 kB	909 kB	✓
withRouter.js	909 kB	909 kB	✓
Overall change	4.5 MB	4.5 MB	✓

Ref: #13742

pix2D · 2020-06-08T06:58:06Z

@lfades Shouldn't an example called with-apollo also showcase SSR and not just SSG?

Ref: #13742

jpedroschmitz · 2020-06-16T13:16:41Z

@pix2D, this example was updated so you can use SSR and SSG. You just need to replace the getStaticProps method to getServerSideProps.

@lfades comment about it

pix2D · 2020-06-16T14:05:24Z

@jpedroschmitz Ah apologies, I did not get to that conclusion from looking at the demo mainly because I didn't see getDataFromTree anywhere. Will test it out.

willwill96 · 2020-06-25T16:48:37Z

@jpedroschmitz It seems like in this approach, you need to know all of the queries ahead of time in order to make SSR/SSG work. Is this intentional? I really liked how with the old withApollo higher order component, it would automatically traverse the app tree and figure out the queries needed to run for you. If you have numerous components with different queries on your page, it seems like it would be extremely tedious and would go against React's dynamic nature to need to put those queries in both places. Maybe I am misunderstanding something though.

Based on vercel#13607 - I created a new PR as I can't push changes to the initial PR. Migrated the Apollo client to use SSG, also removed the link to the live demo because I don't know who the owner is or how to update the deployment. The implementation is pretty simple and will be added to all the other Apollo examples

) Ref: vercel#13742

Ref: vercel#13742

TheRusskiy · 2020-11-01T14:03:47Z

agree with @willwill96, IMHO this change is a step backward in terms of utility :-(
In my opinion getStaticProps support should come as an additional feature instead of the only feature.

jesstelford · 2021-01-20T05:05:33Z

Here is the last commit containing the getInitialProps() version for those looking like I was.

todortotev and others added 14 commits May 31, 2020 16:59

Page no longer needed

9bc00bd

Turned ssr mode to false in favor of SSG

50e8db4

No longer needed

e447c21

the new apollo utility method

1267e9f

Removed the router dependency

8904529

It cannot be used anymore, cause it requires getInitialProps

Addded _app page

0670c61

Edited the about

79d1c12

Adjusted the homepage to the new functionality

07bd8e3

Merge branch 'canary' of https://github.com/zeit/next.js into refacto…

58b4fcb

…r-with-apollo

Hydrate Apollo state

36384e9

hydrate the initial state properly for navigations

83b80d0

Removed old client

f97292f

Updated readme

cea2de6

Removed link to demo

776f95d

lfades requested review from chibicode, ijjk, Timer and timneutkens as code owners June 4, 2020 02:59

lfades changed the title ~~Update with-apollo example~~ [Examples] Move with-apollo to SSG Jun 4, 2020

lfades mentioned this pull request Jun 4, 2020

Refactor with-apollo example #13607

Closed

Timer added the examples Issue was opened via the examples template. label Jun 4, 2020

lfades added 2 commits June 4, 2020 16:51

Don't use getDataFromTree

4993f33

Removed getDataFromTree from the example

3a3e17d

Add revalidation

a65030f

This was referenced Jun 4, 2020

[Examples] Move with-apollo-and-redux to SSG #13779

Merged

[Examples] Move api-routes-apollo-server-and-client to SSG #13782

Merged

Added back demo url

b610d9b

Timer added this to the 9.4.5 milestone Jun 5, 2020

Timer approved these changes Jun 5, 2020

View reviewed changes

Merge branch 'canary' into ssg/with-apollo

57d0259

kodiakhq bot merged commit 2d2c762 into vercel:canary Jun 5, 2020

kodiakhq bot pushed a commit that referenced this pull request Jun 6, 2020

[Examples] Move api-routes-apollo-server-and-client to SSG (#13782)

792a113

Ref: #13742

kodiakhq bot pushed a commit that referenced this pull request Jun 9, 2020

[Examples] Move with-apollo-and-redux to SSG (#13779)

3a9fbd8

Ref: #13742

rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020

[Examples] Move api-routes-apollo-server-and-client to SSG (vercel#13782

945f3b7

) Ref: vercel#13742

rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020

[Examples] Move with-apollo-and-redux to SSG (vercel#13779)

274425f

Ref: vercel#13742

karlhorky mentioned this pull request Jul 16, 2020

TypeScript + Next.js: Switch from getInitialProps to getStaticProps (SSG) prisma/prisma-examples#1875

Closed

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Examples] Move with-apollo to SSG #13742

[Examples] Move with-apollo to SSG #13742

lfades commented Jun 4, 2020 •

edited

Loading

ijjk commented Jun 4, 2020

adamsoffer commented Jun 4, 2020 •

edited

Loading

adamsoffer commented Jun 4, 2020

ijjk commented Jun 4, 2020

lfades commented Jun 4, 2020

ijjk commented Jun 4, 2020

adamsoffer commented Jun 4, 2020

lfades commented Jun 4, 2020

adamsoffer commented Jun 4, 2020

ijjk commented Jun 5, 2020

adamsoffer commented Jun 5, 2020

Timer left a comment

ijjk commented Jun 5, 2020

pix2D commented Jun 8, 2020

jpedroschmitz commented Jun 16, 2020

pix2D commented Jun 16, 2020

willwill96 commented Jun 25, 2020

TheRusskiy commented Nov 1, 2020 •

edited

Loading

jesstelford commented Jan 20, 2021

[Examples] Move with-apollo to SSG #13742

[Examples] Move with-apollo to SSG #13742

Conversation

lfades commented Jun 4, 2020 • edited Loading

ijjk commented Jun 4, 2020

Stats from current PR

adamsoffer commented Jun 4, 2020 • edited Loading

adamsoffer commented Jun 4, 2020

ijjk commented Jun 4, 2020

Stats from current PR

lfades commented Jun 4, 2020

ijjk commented Jun 4, 2020

Stats from current PR

adamsoffer commented Jun 4, 2020

lfades commented Jun 4, 2020

adamsoffer commented Jun 4, 2020

ijjk commented Jun 5, 2020

Stats from current PR

adamsoffer commented Jun 5, 2020

Timer left a comment

Choose a reason for hiding this comment

ijjk commented Jun 5, 2020

Stats from current PR

pix2D commented Jun 8, 2020

jpedroschmitz commented Jun 16, 2020

pix2D commented Jun 16, 2020

willwill96 commented Jun 25, 2020

TheRusskiy commented Nov 1, 2020 • edited Loading

jesstelford commented Jan 20, 2021

lfades commented Jun 4, 2020 •

edited

Loading

adamsoffer commented Jun 4, 2020 •

edited

Loading

TheRusskiy commented Nov 1, 2020 •

edited

Loading