Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support both experimental method names #13740

Closed
wants to merge 3 commits into from
Closed

Support both experimental method names #13740

wants to merge 3 commits into from

Conversation

utxo-detective
Copy link

Not all dependencies have updated to the latest react experimental build. There is an open issue in react-native-web preventing me from updating to the latest experimental build in react, but I can use previous experimental versions

#12669 has more context

@ijjk
Copy link
Member

ijjk commented Jun 4, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary twetch-inc/next.js canary Change
buildDuration 12.5s 11.8s -619ms
nodeModulesSize 66 MB 66 MB ⚠️ +649 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary twetch-inc/next.js canary Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.076 2.034 -0.04
/ avg req/sec 1204.33 1229 ⚠️ +24.67
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.158 1.226 ⚠️ +0.07
/error-in-render avg req/sec 2158.43 2038.34 -120.09
Client Bundles (main, webpack, commons)
vercel/next.js canary twetch-inc/next.js canary Change
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..6c2a.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary twetch-inc/next.js canary Change
main-HASH.module.js gzip 5.67 kB 5.67 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary twetch-inc/next.js canary Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary twetch-inc/next.js canary Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.21 kB 8.21 kB ✓
Client Pages Modern
vercel/next.js canary twetch-inc/next.js canary Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.32 kB 5.32 kB ✓
Client Build Manifests
vercel/next.js canary twetch-inc/next.js canary Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary twetch-inc/next.js canary Change
index.html gzip 924 B 926 B ⚠️ +2 B
link.html gzip 934 B 935 B ⚠️ +1 B
withRouter.html gzip 922 B 923 B ⚠️ +1 B
Overall change 2.78 kB 2.78 kB ⚠️ +4 B

Diffs

Diff for main-HASH.js 
@@ -789,7 +789,7 @@
 
       function renderReactElement(reactEl, domEl) {
         if (false) {
-          var opts;
+          var createBlockingRoot, createRoot, opts;
         } else {
           // mark start of hydrate/render
           if (_utils.ST) {
Diff for main-HASH.module.js 
@@ -536,7 +536,7 @@
 
       function renderReactElement(reactEl, domEl) {
         if (false) {
-          var opts;
+          var createBlockingRoot, createRoot, opts;
         } else {
           // mark start of hydrate/render
           if (_utils.ST) {
Diff for index.html 
@@ -36,7 +36,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-5062a6ab83d04dfd16c2.module.js"
+      href="/_next/static/runtime/main-3550982ef6bcb3e1872e.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -145,13 +145,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/runtime/main-750a8131bb83360bfd80.js"
+      src="/_next/static/runtime/main-a4fee6fa9a4aa77fc527.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/runtime/main-5062a6ab83d04dfd16c2.module.js"
+      src="/_next/static/runtime/main-3550982ef6bcb3e1872e.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -36,7 +36,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-5062a6ab83d04dfd16c2.module.js"
+      href="/_next/static/runtime/main-3550982ef6bcb3e1872e.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -150,13 +150,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/runtime/main-750a8131bb83360bfd80.js"
+      src="/_next/static/runtime/main-a4fee6fa9a4aa77fc527.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/runtime/main-5062a6ab83d04dfd16c2.module.js"
+      src="/_next/static/runtime/main-3550982ef6bcb3e1872e.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -36,7 +36,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-5062a6ab83d04dfd16c2.module.js"
+      href="/_next/static/runtime/main-3550982ef6bcb3e1872e.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -145,13 +145,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/runtime/main-750a8131bb83360bfd80.js"
+      src="/_next/static/runtime/main-a4fee6fa9a4aa77fc527.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/runtime/main-5062a6ab83d04dfd16c2.module.js"
+      src="/_next/static/runtime/main-3550982ef6bcb3e1872e.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary twetch-inc/next.js canary Change
buildDuration 13.3s 13.2s -112ms
nodeModulesSize 66 MB 66 MB ⚠️ +649 B
Client Bundles (main, webpack, commons)
vercel/next.js canary twetch-inc/next.js canary Change
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..6c2a.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary twetch-inc/next.js canary Change
main-HASH.module.js gzip 5.67 kB 5.67 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary twetch-inc/next.js canary Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary twetch-inc/next.js canary Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.21 kB 8.21 kB ✓
Client Pages Modern
vercel/next.js canary twetch-inc/next.js canary Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.32 kB 5.32 kB ✓
Client Build Manifests
vercel/next.js canary twetch-inc/next.js canary Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
vercel/next.js canary twetch-inc/next.js canary Change
_error.js 878 kB 878 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 879 kB 879 kB ✓
link.js 916 kB 916 kB ✓
routerDirect.js 909 kB 909 kB ✓
withRouter.js 909 kB 909 kB ✓
Overall change 4.5 MB 4.5 MB ✓

@ijjk
Copy link
Member

ijjk commented Jun 4, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary twetch-inc/next.js canary Change
buildDuration 12.8s 10.9s -1.9s
nodeModulesSize 66 MB 66 MB ⚠️ +435 B
Page Load Tests Overall increase ✓
vercel/next.js canary twetch-inc/next.js canary Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.129 1.862 -0.27
/ avg req/sec 1174.52 1342.99 ⚠️ +168.47
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.466 1.096 -0.37
/error-in-render avg req/sec 1705.63 2281.9 ⚠️ +576.27
Client Bundles (main, webpack, commons)
vercel/next.js canary twetch-inc/next.js canary Change
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..6c2a.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary twetch-inc/next.js canary Change
main-HASH.module.js gzip 5.67 kB 5.67 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary twetch-inc/next.js canary Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary twetch-inc/next.js canary Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.21 kB 8.21 kB ✓
Client Pages Modern
vercel/next.js canary twetch-inc/next.js canary Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.32 kB 5.32 kB ✓
Client Build Manifests
vercel/next.js canary twetch-inc/next.js canary Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary twetch-inc/next.js canary Change
index.html gzip 924 B 926 B ⚠️ +2 B
link.html gzip 934 B 935 B ⚠️ +1 B
withRouter.html gzip 922 B 924 B ⚠️ +2 B
Overall change 2.78 kB 2.79 kB ⚠️ +5 B

Diffs

Diff for main-HASH.js 
@@ -789,7 +789,7 @@
 
       function renderReactElement(reactEl, domEl) {
         if (false) {
-          var opts;
+          var createBlockingRoot, createRoot, opts;
         } else {
           // mark start of hydrate/render
           if (_utils.ST) {
Diff for main-HASH.module.js 
@@ -536,7 +536,7 @@
 
       function renderReactElement(reactEl, domEl) {
         if (false) {
-          var opts;
+          var createBlockingRoot, createRoot, opts;
         } else {
           // mark start of hydrate/render
           if (_utils.ST) {
Diff for index.html 
@@ -36,7 +36,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-5062a6ab83d04dfd16c2.module.js"
+      href="/_next/static/runtime/main-73d4bac67f5e2b61c4e7.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -145,13 +145,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/runtime/main-750a8131bb83360bfd80.js"
+      src="/_next/static/runtime/main-3f2fbf540e1dca2da683.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/runtime/main-5062a6ab83d04dfd16c2.module.js"
+      src="/_next/static/runtime/main-73d4bac67f5e2b61c4e7.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -36,7 +36,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-5062a6ab83d04dfd16c2.module.js"
+      href="/_next/static/runtime/main-73d4bac67f5e2b61c4e7.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -150,13 +150,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/runtime/main-750a8131bb83360bfd80.js"
+      src="/_next/static/runtime/main-3f2fbf540e1dca2da683.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/runtime/main-5062a6ab83d04dfd16c2.module.js"
+      src="/_next/static/runtime/main-73d4bac67f5e2b61c4e7.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -36,7 +36,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-5062a6ab83d04dfd16c2.module.js"
+      href="/_next/static/runtime/main-73d4bac67f5e2b61c4e7.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -145,13 +145,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/runtime/main-750a8131bb83360bfd80.js"
+      src="/_next/static/runtime/main-3f2fbf540e1dca2da683.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/runtime/main-5062a6ab83d04dfd16c2.module.js"
+      src="/_next/static/runtime/main-73d4bac67f5e2b61c4e7.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary twetch-inc/next.js canary Change
buildDuration 11.3s 11.4s ⚠️ +124ms
nodeModulesSize 66 MB 66 MB ⚠️ +435 B
Client Bundles (main, webpack, commons)
vercel/next.js canary twetch-inc/next.js canary Change
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..6c2a.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary twetch-inc/next.js canary Change
main-HASH.module.js gzip 5.67 kB 5.67 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary twetch-inc/next.js canary Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary twetch-inc/next.js canary Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.21 kB 8.21 kB ✓
Client Pages Modern
vercel/next.js canary twetch-inc/next.js canary Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.32 kB 5.32 kB ✓
Client Build Manifests
vercel/next.js canary twetch-inc/next.js canary Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
vercel/next.js canary twetch-inc/next.js canary Change
_error.js 878 kB 878 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 879 kB 879 kB ✓
link.js 916 kB 916 kB ✓
routerDirect.js 909 kB 909 kB ✓
withRouter.js 909 kB 909 kB ✓
Overall change 4.5 MB 4.5 MB ✓

@timneutkens
Copy link
Member

I don't think we should support "old unstable versions" of React. The experimental build is experimental for a reason and should not be relied upon unless you know things will break with upgrades.

@timneutkens timneutkens closed this Jun 4, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@utxo-detective @ijjk @timneutkens