Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ie11 polyfills #13704

Merged
merged 3 commits into from
Jul 4, 2020
Merged

Ie11 polyfills #13704

merged 3 commits into from
Jul 4, 2020

Conversation

tomdohnal
Copy link
Contributor

This resolves #12713 and #12722

@ijjk
Copy link
Member

ijjk commented Jun 3, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary tomdohnal/next.js ie11-polyfills Change
buildDuration 13.2s 12.7s -462ms
nodeModulesSize 66 MB 66 MB ⚠️ +300 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary tomdohnal/next.js ie11-polyfills Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.275 2.2 -0.07
/ avg req/sec 1098.88 1136.32 ⚠️ +37.44
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.395 1.548 ⚠️ +0.15
/error-in-render avg req/sec 1792.18 1614.84 -177.34
Client Bundles (main, webpack, commons)
vercel/next.js canary tomdohnal/next.js ie11-polyfills Change
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..6c2a.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary tomdohnal/next.js ie11-polyfills Change
main-HASH.module.js gzip 5.67 kB 5.67 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills) Overall increase ⚠️
vercel/next.js canary tomdohnal/next.js ie11-polyfills Change
polyfills-HASH.js gzip 26.3 kB 26.4 kB ⚠️ +94 B
Overall change 26.3 kB 26.4 kB ⚠️ +94 B
Client Pages
vercel/next.js canary tomdohnal/next.js ie11-polyfills Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.21 kB 8.21 kB ✓
Client Pages Modern
vercel/next.js canary tomdohnal/next.js ie11-polyfills Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.32 kB 5.32 kB ✓
Client Build Manifests
vercel/next.js canary tomdohnal/next.js ie11-polyfills Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary tomdohnal/next.js ie11-polyfills Change
index.html gzip 924 B 924 B ✓
link.html gzip 934 B 934 B ✓
withRouter.html gzip 922 B 923 B ⚠️ +1 B
Overall change 2.78 kB 2.78 kB ⚠️ +1 B

Diffs

Diff for polyfills-HASH.js

Diff too large to display

Diff for index.html 
@@ -78,7 +78,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/runtime/polyfills-eaf5488e20ec921d713f.js"
+      src="/_next/static/runtime/polyfills-e88dfbb0e4353a54b76a.js"
     ></script>
     <script
       async=""
Diff for link.html 
@@ -83,7 +83,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/runtime/polyfills-eaf5488e20ec921d713f.js"
+      src="/_next/static/runtime/polyfills-e88dfbb0e4353a54b76a.js"
     ></script>
     <script
       async=""
Diff for withRouter.html 
@@ -78,7 +78,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/runtime/polyfills-eaf5488e20ec921d713f.js"
+      src="/_next/static/runtime/polyfills-e88dfbb0e4353a54b76a.js"
     ></script>
     <script
       async=""
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary tomdohnal/next.js ie11-polyfills Change
buildDuration 14.9s 14.4s -478ms
nodeModulesSize 66 MB 66 MB ⚠️ +300 B
Client Bundles (main, webpack, commons)
vercel/next.js canary tomdohnal/next.js ie11-polyfills Change
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..6c2a.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary tomdohnal/next.js ie11-polyfills Change
main-HASH.module.js gzip 5.67 kB 5.67 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills) Overall increase ⚠️
vercel/next.js canary tomdohnal/next.js ie11-polyfills Change
polyfills-HASH.js gzip 26.3 kB 26.4 kB ⚠️ +94 B
Overall change 26.3 kB 26.4 kB ⚠️ +94 B
Client Pages
vercel/next.js canary tomdohnal/next.js ie11-polyfills Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.21 kB 8.21 kB ✓
Client Pages Modern
vercel/next.js canary tomdohnal/next.js ie11-polyfills Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.32 kB 5.32 kB ✓
Client Build Manifests
vercel/next.js canary tomdohnal/next.js ie11-polyfills Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
vercel/next.js canary tomdohnal/next.js ie11-polyfills Change
_error.js 878 kB 878 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 879 kB 879 kB ✓
link.js 916 kB 916 kB ✓
routerDirect.js 909 kB 909 kB ✓
withRouter.js 909 kB 909 kB ✓
Overall change 4.5 MB 4.5 MB ✓

@timneutkens
Copy link
Member

Thanks!

@ijjk
Copy link
Member

ijjk commented Jul 4, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary tomdohnal/next.js ie11-polyfills Change
buildDuration 11.8s 11.5s -236ms
nodeModulesSize 66.1 MB 66.1 MB ⚠️ +300 B
Page Load Tests Overall increase ✓
vercel/next.js canary tomdohnal/next.js ie11-polyfills Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.936 1.889 -0.05
/ avg req/sec 1291.35 1323.51 +32.16
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.195 1.135 -0.06
/error-in-render avg req/sec 2091.37 2201.98 +110.61
Client Bundles (main, webpack, commons)
vercel/next.js canary tomdohnal/next.js ie11-polyfills Change
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..18e4.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary tomdohnal/next.js ie11-polyfills Change
main-HASH.module.js gzip 5.71 kB 5.71 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.09 kB 7.09 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills) Overall increase ⚠️
vercel/next.js canary tomdohnal/next.js ie11-polyfills Change
polyfills-HASH.js gzip 26.3 kB 26.4 kB ⚠️ +93 B
Overall change 26.3 kB 26.4 kB ⚠️ +93 B
Client Build Manifests
vercel/next.js canary tomdohnal/next.js ie11-polyfills Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary tomdohnal/next.js ie11-polyfills Change
index.html gzip 954 B 954 B ✓
link.html gzip 959 B 958 B -1 B
withRouter.html gzip 946 B 945 B -1 B
Overall change 2.86 kB 2.86 kB -2 B

Diffs

Diff for polyfills-HASH.js

Diff too large to display

Diff for index.html 
@@ -78,7 +78,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/runtime/polyfills-e77205bd3f87781c0279.js"
+      src="/_next/static/runtime/polyfills-fa968511391ff096b874.js"
     ></script>
     <script
       src="/_next/static/runtime/main-a402689d595ce1baa2c7.js"
Diff for link.html 
@@ -83,7 +83,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/runtime/polyfills-e77205bd3f87781c0279.js"
+      src="/_next/static/runtime/polyfills-fa968511391ff096b874.js"
     ></script>
     <script
       src="/_next/static/runtime/main-a402689d595ce1baa2c7.js"
Diff for withRouter.html 
@@ -78,7 +78,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/runtime/polyfills-e77205bd3f87781c0279.js"
+      src="/_next/static/runtime/polyfills-fa968511391ff096b874.js"
     ></script>
     <script
       src="/_next/static/runtime/main-a402689d595ce1baa2c7.js"
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary tomdohnal/next.js ie11-polyfills Change
buildDuration 12.6s 12.3s -325ms
nodeModulesSize 66.1 MB 66.1 MB ⚠️ +300 B
Client Bundles (main, webpack, commons)
vercel/next.js canary tomdohnal/next.js ie11-polyfills Change
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
19b7e98f51cc..18e4.js gzip 10.7 kB 10.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary tomdohnal/next.js ie11-polyfills Change
main-HASH.module.js gzip 5.71 kB 5.71 kB ✓
webpack-HASH..dule.js gzip 751 B 751 B ✓
19b7e98f51cc..dule.js gzip 7.09 kB 7.09 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills) Overall increase ⚠️
vercel/next.js canary tomdohnal/next.js ie11-polyfills Change
polyfills-HASH.js gzip 26.3 kB 26.4 kB ⚠️ +93 B
Overall change 26.3 kB 26.4 kB ⚠️ +93 B
Client Build Manifests
vercel/next.js canary tomdohnal/next.js ie11-polyfills Change
_buildManifest.js gzip 268 B 268 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 540 B 540 B ✓
Serverless bundles
vercel/next.js canary tomdohnal/next.js ie11-polyfills Change
_error.js 876 kB 876 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 876 kB 876 kB ✓
link.js 915 kB 915 kB ✓
routerDirect.js 908 kB 908 kB ✓
withRouter.js 908 kB 908 kB ✓
Overall change 4.49 MB 4.49 MB ✓
Commit: 84ebb6a

@kodiakhq kodiakhq bot merged commit 2a99f59 into vercel:canary Jul 4, 2020
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@tomdohnal @rokinsky
Ie11 polyfills (vercel#13704)
4ef4b88 
This resolves vercel#12713 and vercel#12722
@Timer Timer mentioned this pull request Aug 18, 2020
Closed
@bolatovumar bolatovumar mentioned this pull request Aug 19, 2020
Closed
@StevenMatchett
Copy link

🙌

@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Object.keys non-object coercion not working in IE 11
4 participants
@tomdohnal @ijjk @timneutkens @StevenMatchett