Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip reading filesystem in favor of sourcesContent [ch1898] #13677

Conversation

Timer
Copy link
Member

@Timer Timer commented Jun 2, 2020

This skips reading from the file system because the sourcesContent can be used to access the source code.

I've completely removed the filesystem fallback, because it's probably not our code that'd be syntax highlighted anyway.

@ijjk
Copy link
Member

ijjk commented Jun 2, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
buildDuration 12.6s 12.2s -427ms
nodeModulesSize 66.3 MB 66.3 MB
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
/ failed reqs 0 0
/ total time (seconds) 2.092 2.087 0
/ avg req/sec 1195.01 1197.88 ⚠️ +2.87
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.235 1.165 -0.07
/error-in-render avg req/sec 2024.11 2145.89 ⚠️ +121.78
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
main-HASH.js gzip 6.59 kB 6.59 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..6c2a.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
main-HASH.module.js gzip 5.67 kB 5.67 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.25 kB 3.25 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.05 kB 2.05 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.21 kB 8.21 kB
Client Pages Modern
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.04 kB 2.04 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.51 kB 1.51 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.32 kB 5.32 kB
Client Build Manifests
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
index.html gzip 925 B 925 B
link.html gzip 936 B 936 B
withRouter.html gzip 923 B 923 B
Overall change 2.78 kB 2.78 kB

Serverless Mode
General
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
buildDuration 13.1s 13.2s ⚠️ +81ms
nodeModulesSize 66.3 MB 66.3 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
main-HASH.js gzip 6.59 kB 6.59 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..6c2a.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
main-HASH.module.js gzip 5.67 kB 5.67 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.25 kB 3.25 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.05 kB 2.05 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.21 kB 8.21 kB
Client Pages Modern
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.04 kB 2.04 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.51 kB 1.51 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.32 kB 5.32 kB
Client Build Manifests
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
_error.js 878 kB 878 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 879 kB 879 kB
link.js 916 kB 916 kB
routerDirect.js 909 kB 909 kB
withRouter.js 909 kB 909 kB
Overall change 4.5 MB 4.5 MB

@ijjk
Copy link
Member

ijjk commented Jun 2, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
buildDuration 13.5s 13.6s ⚠️ +62ms
nodeModulesSize 66.3 MB 66.3 MB
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
/ failed reqs 0 0
/ total time (seconds) 2.384 2.4 ⚠️ +0.02
/ avg req/sec 1048.56 1041.81 -6.75
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.504 1.479 -0.02
/error-in-render avg req/sec 1662.03 1690.83 ⚠️ +28.8
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
main-HASH.js gzip 6.59 kB 6.59 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..6c2a.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
main-HASH.module.js gzip 5.67 kB 5.67 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.25 kB 3.25 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.05 kB 2.05 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.21 kB 8.21 kB
Client Pages Modern
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.04 kB 2.04 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.51 kB 1.51 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.32 kB 5.32 kB
Client Build Manifests
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
index.html gzip 925 B 925 B
link.html gzip 936 B 936 B
withRouter.html gzip 923 B 923 B
Overall change 2.78 kB 2.78 kB

Serverless Mode
General
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
buildDuration 14.6s 14.6s -21ms
nodeModulesSize 66.3 MB 66.3 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
main-HASH.js gzip 6.59 kB 6.59 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..6c2a.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
main-HASH.module.js gzip 5.67 kB 5.67 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.25 kB 3.25 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.05 kB 2.05 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.21 kB 8.21 kB
Client Pages Modern
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.04 kB 2.04 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.51 kB 1.51 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.32 kB 5.32 kB
Client Build Manifests
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
_error.js 878 kB 878 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 879 kB 879 kB
link.js 916 kB 916 kB
routerDirect.js 909 kB 909 kB
withRouter.js 909 kB 909 kB
Overall change 4.5 MB 4.5 MB

@ijjk
Copy link
Member

ijjk commented Jun 2, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
buildDuration 11.7s 12.8s ⚠️ +1s
nodeModulesSize 66.3 MB 66.3 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
/ failed reqs 0 0
/ total time (seconds) 2.007 2.036 ⚠️ +0.03
/ avg req/sec 1245.65 1227.96 -17.69
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.129 1.175 ⚠️ +0.05
/error-in-render avg req/sec 2213.86 2128.44 -85.42
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
main-HASH.js gzip 6.59 kB 6.59 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..6c2a.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
main-HASH.module.js gzip 5.67 kB 5.67 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.25 kB 3.25 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.05 kB 2.05 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.21 kB 8.21 kB
Client Pages Modern
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.04 kB 2.04 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.51 kB 1.51 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.32 kB 5.32 kB
Client Build Manifests
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
index.html gzip 925 B 925 B
link.html gzip 936 B 936 B
withRouter.html gzip 923 B 923 B
Overall change 2.78 kB 2.78 kB

Serverless Mode
General
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
buildDuration 12.7s 12.9s ⚠️ +237ms
nodeModulesSize 66.3 MB 66.3 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
main-HASH.js gzip 6.59 kB 6.59 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..6c2a.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
main-HASH.module.js gzip 5.67 kB 5.67 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.25 kB 3.25 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.05 kB 2.05 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.21 kB 8.21 kB
Client Pages Modern
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.04 kB 2.04 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.51 kB 1.51 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.32 kB 5.32 kB
Client Build Manifests
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
vercel/next.js canary Timer/next.js vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent Change
_error.js 878 kB 878 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 879 kB 879 kB
link.js 916 kB 916 kB
routerDirect.js 909 kB 909 kB
withRouter.js 909 kB 909 kB
Overall change 4.5 MB 4.5 MB

@kodiakhq kodiakhq bot merged commit 4cd85a4 into vercel:canary Jun 2, 2020
@Timer Timer deleted the vercel_timer/ch1898/skip-reading-filesystem-if-sourcescontent branch June 2, 2020 16:34
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
…#13677)

This skips reading from the file system because the `sourcesContent` can be used to access the source code.

I've completely removed the filesystem fallback, because it's probably not our code that'd be syntax highlighted anyway.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants