Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remaining granular chunks references #13672

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Remove remaining granular chunks references #13672

merged 1 commit into from
Jun 2, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented Jun 2, 2020

This removes remaining references to granularChunks in configs, error messages, and comments.

Also removed the process.env.__NEXT_GRANULAR_CHUNKS value.

Follow up to: #13663

@Timer Timer added this to the 9.4.5 milestone Jun 2, 2020
@Timer Timer requested review from ijjk, lfades and timneutkens as code owners June 2, 2020 14:21
@ijjk
Copy link
Member

ijjk commented Jun 2, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary Timer/next.js remove-leftover-granular-chunks Change
buildDuration 9.8s 10.4s ⚠️ +599ms
nodeModulesSize 66.3 MB 66.3 MB -303 B
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js remove-leftover-granular-chunks Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.714 1.662 -0.05
/ avg req/sec 1458.61 1504.03 ⚠️ +45.42
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 0.992 0.913 -0.08
/error-in-render avg req/sec 2520.89 2738.52 ⚠️ +217.63
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js remove-leftover-granular-chunks Change
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..6c2a.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js remove-leftover-granular-chunks Change
main-HASH.module.js gzip 5.67 kB 5.67 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js remove-leftover-granular-chunks Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary Timer/next.js remove-leftover-granular-chunks Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.21 kB 8.21 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js remove-leftover-granular-chunks Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.32 kB 5.32 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js remove-leftover-granular-chunks Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary Timer/next.js remove-leftover-granular-chunks Change
index.html gzip 926 B 925 B -1 B
link.html gzip 935 B 936 B ⚠️ +1 B
withRouter.html gzip 924 B 923 B -1 B
Overall change 2.79 kB 2.78 kB -1 B

Diffs

Diff for index.html 
@@ -36,7 +36,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-4189570acee12c8cf5c5.module.js"
+      href="/_next/static/runtime/main-7b2368c2cb86d059d18d.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -145,13 +145,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/runtime/main-1b7280111b939aefc5cc.js"
+      src="/_next/static/runtime/main-a2a1bcf2659323c95e87.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/runtime/main-4189570acee12c8cf5c5.module.js"
+      src="/_next/static/runtime/main-7b2368c2cb86d059d18d.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -36,7 +36,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-4189570acee12c8cf5c5.module.js"
+      href="/_next/static/runtime/main-7b2368c2cb86d059d18d.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -150,13 +150,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/runtime/main-1b7280111b939aefc5cc.js"
+      src="/_next/static/runtime/main-a2a1bcf2659323c95e87.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/runtime/main-4189570acee12c8cf5c5.module.js"
+      src="/_next/static/runtime/main-7b2368c2cb86d059d18d.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -36,7 +36,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-4189570acee12c8cf5c5.module.js"
+      href="/_next/static/runtime/main-7b2368c2cb86d059d18d.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -145,13 +145,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/runtime/main-1b7280111b939aefc5cc.js"
+      src="/_next/static/runtime/main-a2a1bcf2659323c95e87.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/runtime/main-4189570acee12c8cf5c5.module.js"
+      src="/_next/static/runtime/main-7b2368c2cb86d059d18d.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary Timer/next.js remove-leftover-granular-chunks Change
buildDuration 10.4s 10.8s ⚠️ +356ms
nodeModulesSize 66.3 MB 66.3 MB -303 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js remove-leftover-granular-chunks Change
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..6c2a.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js remove-leftover-granular-chunks Change
main-HASH.module.js gzip 5.67 kB 5.67 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js remove-leftover-granular-chunks Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary Timer/next.js remove-leftover-granular-chunks Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.21 kB 8.21 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js remove-leftover-granular-chunks Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.32 kB 5.32 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js remove-leftover-granular-chunks Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js remove-leftover-granular-chunks Change
_error.js 878 kB 878 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 879 kB 879 kB ✓
link.js 916 kB 916 kB ✓
routerDirect.js 909 kB 909 kB ✓
withRouter.js 909 kB 909 kB ✓
Overall change 4.5 MB 4.5 MB ✓

@kodiakhq kodiakhq bot merged commit a92e976 into vercel:canary Jun 2, 2020
@Timer Timer deleted the remove-leftover-granular-chunks branch June 2, 2020 16:38
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@Timer @rokinsky
Remove remaining granular chunks references (vercel#13672)
f29b5a6 
This removes remaining references to `granularChunks` in configs, error messages, and comments.

Also removed the `process.env.__NEXT_GRANULAR_CHUNKS` value.

---

Follow up to: vercel#13663
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens timneutkens approved these changes

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.4.5
Development

Successfully merging this pull request may close these issues.
3 participants
@Timer @ijjk @timneutkens