Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of autodll #13669

Merged
merged 3 commits into from
Jun 2, 2020
Merged

Get rid of autodll #13669

merged 3 commits into from
Jun 2, 2020

Conversation

timneutkens
Copy link
Member

Prepares for the upgrade to webpack 5

@timneutkens timneutkens requested review from ijjk, lfades and Timer as code owners June 2, 2020 14:04
Timer
Timer previously approved these changes Jun 2, 2020
View reviewed changes
@Timer Timer added this to the 9.4.5 milestone Jun 2, 2020
@ijjk
Copy link
Member

ijjk commented Jun 2, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
buildDuration 11s 10.9s -82ms
nodeModulesSize 66.3 MB 66.3 MB -4.52 kB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.958 1.974 ⚠️ +0.02
/ avg req/sec 1276.81 1266.47 -10.34
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.294 1.189 -0.1
/error-in-render avg req/sec 1932.54 2103.49 ⚠️ +170.95
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..6c2a.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
main-HASH.module.js gzip 5.67 kB 5.67 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.21 kB 8.21 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.32 kB 5.32 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
index.html gzip 926 B 926 B ✓
link.html gzip 935 B 935 B ✓
withRouter.html gzip 924 B 924 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
buildDuration 11.7s 11.8s ⚠️ +80ms
nodeModulesSize 66.3 MB 66.3 MB -4.52 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..6c2a.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
main-HASH.module.js gzip 5.67 kB 5.67 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.21 kB 8.21 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.32 kB 5.32 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
_error.js 878 kB 878 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 879 kB 879 kB ✓
link.js 916 kB 916 kB ✓
routerDirect.js 909 kB 909 kB ✓
withRouter.js 909 kB 909 kB ✓
Overall change 4.5 MB 4.5 MB ✓

@ijjk
Copy link
Member

ijjk commented Jun 2, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
buildDuration 11.8s 12.3s ⚠️ +408ms
nodeModulesSize 66.3 MB 66 MB -373 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.06 2.011 -0.05
/ avg req/sec 1213.67 1243.03 ⚠️ +29.36
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.183 1.221 ⚠️ +0.04
/error-in-render avg req/sec 2114 2046.89 -67.11
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..6c2a.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
main-HASH.module.js gzip 5.67 kB 5.67 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.21 kB 8.21 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.32 kB 5.32 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
index.html gzip 926 B 926 B ✓
link.html gzip 935 B 935 B ✓
withRouter.html gzip 924 B 924 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
buildDuration 12.9s 13.1s ⚠️ +130ms
nodeModulesSize 66.3 MB 66 MB -373 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..6c2a.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
main-HASH.module.js gzip 5.67 kB 5.67 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.21 kB 8.21 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.32 kB 5.32 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
_error.js 878 kB 878 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 879 kB 879 kB ✓
link.js 916 kB 916 kB ✓
routerDirect.js 909 kB 909 kB ✓
withRouter.js 909 kB 909 kB ✓
Overall change 4.5 MB 4.5 MB ✓

@ijjk
Copy link
Member

ijjk commented Jun 2, 2020

Failing test suites

test/acceptance/ReactRefreshLogBox.test.js

  • boundaries

Expand output

● boundaries

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  615 |   )
  616 | 
> 617 |   expect(await session.hasRedbox(true)).toBe(true)
      |                                         ^
  618 |   expect(await session.getRedboxSource()).toMatchInlineSnapshot(`
  619 |     "FunctionDefault.js (1:50) @ FunctionDefault
  620 | 

  at Object.<anonymous> (acceptance/ReactRefreshLogBox.test.js:617:41)

Timer
Timer requested changes Jun 2, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ultra slowed down the overlay (see timing out test). Blocking until we figure out why.

@ijjk
Copy link
Member

ijjk commented Jun 2, 2020

Failing test suites

test/acceptance/ReactRefreshLogBox.test.js

  • boundaries

Expand output

● boundaries

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  615 |   )
  616 | 
> 617 |   expect(await session.hasRedbox(true)).toBe(true)
      |                                         ^
  618 |   expect(await session.getRedboxSource()).toMatchInlineSnapshot(`
  619 |     "FunctionDefault.js (1:50) @ FunctionDefault
  620 | 

  at Object.<anonymous> (acceptance/ReactRefreshLogBox.test.js:617:41)

@Timer Timer mentioned this pull request Jun 2, 2020
Merged
@ijjk
Copy link
Member

ijjk commented Jun 2, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
buildDuration 13.3s 13.4s ⚠️ +102ms
nodeModulesSize 66.3 MB 66 MB -373 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.343 2.355 ⚠️ +0.01
/ avg req/sec 1066.79 1061.76 -5.03
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.429 1.495 ⚠️ +0.07
/error-in-render avg req/sec 1749.43 1671.96 -77.47
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..6c2a.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
main-HASH.module.js gzip 5.67 kB 5.67 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.21 kB 8.21 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.32 kB 5.32 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
index.html gzip 926 B 926 B ✓
link.html gzip 936 B 936 B ✓
withRouter.html gzip 924 B 924 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
buildDuration 14.3s 14.4s ⚠️ +51ms
nodeModulesSize 66.3 MB 66 MB -373 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..6c2a.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
main-HASH.module.js gzip 5.67 kB 5.67 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.21 kB 8.21 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.32 kB 5.32 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js add/remove-autodll Change
_error.js 878 kB 878 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 879 kB 879 kB ✓
link.js 916 kB 916 kB ✓
routerDirect.js 909 kB 909 kB ✓
withRouter.js 909 kB 909 kB ✓
Overall change 4.5 MB 4.5 MB ✓

Timer
Timer approved these changes Jun 2, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment •
edited by timneutkens
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now that performance issue was addressed in other #13684.

@kodiakhq kodiakhq bot merged commit 08e7fa1 into vercel:canary Jun 2, 2020
@timneutkens timneutkens deleted the add/remove-autodll branch June 2, 2020 19:26
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@timneutkens @rokinsky
Get rid of autodll (vercel#13669)
8397a8a 
Prepares for the upgrade to webpack 5
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.4.5
Development

Successfully merging this pull request may close these issues.
3 participants
@timneutkens @ijjk @Timer