Enhance with redux thunk example #13576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of passing the state from the parent component, I have used the new redux hooks to retrieve the current state.
lfades
reviewed
May 30, 2020
lfades
requested changes
May 30, 2020
lfades
approved these changes
May 31, 2020
rokinsky
pushed a commit
to rokinsky/next.js
that referenced
this pull request
Jul 11, 2020
* Refactored the store so that it doesnt use getInitialProps * Applied the changes in the _app file * Refactored the wrapper so that it uses the new store flow * Removed the old redux syntax Instead of passing the state from the parent component, I have used the new redux hooks to retrieve the current state. * The clock no longer requires state to be passed too * Updated the variable names * forgot to bring back hot reloading * Applied requested change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @lfades at 11014, there are currently some redux examples that are still using getInitialProps.
In this PR, I have adjusted the store to be similar to with-redux example as requested. The wrapper is removed as it is no longer required.
Also, I believe the Examples component was needlessly passing the state, which would be more reasonable to be acquired by using useSelector.
The clock element was still using connect() syntax, I have refactored it and it uses the hooks API.
If there's anything you don't like or you want me to change something, I'm open to suggestions.